Bugzilla Bug 87553

Please find attached a new ebuild for gimpshop (derived from gimp's ebuild).

Gimpshop is a hack of the gimp to provide an interface more close to Adboe Photoshop  (see http://plasticbugs.com/).

I'm not a portage specialist, so some part of the ebuild are clearly not "clean". Can someone tidy this 2 things:

 -The source package is actually has a .tbz extension. This is not recognized by unpack, so you MUST download and rename the file "manually" to a .tar.bz2 (i can't find a way to do this in my ebuild)
 -When unpacking the source, it creates a "gimp-2.2.4" and not "gimpshop-2.2.4" so i do also rename manually

Except this, build seems to be fine.

I've added an exclusion to gimp to avoid problems. So you CAN'T actually have both gimp and gimpshop. It would be better to patch the source to get install in an alternative directory (for ex /opt/gimpshop as proposed at http://forums.gentoo.org/viewtopic-t-317274-highlight-gimpshop.html).

Reproducible: Always
Steps to Reproduce:
install...
build...
run... hopefully :-)
Actual Results:  
Everything seems fine.

Expected Results:  
nothing

Created an attachment (id=55028) [details]
First ebuild for gimpshop (this is my first ebuild too... You've been warned!)

Definitely need cleaning. Please download the package first and rename to
".tar.bz2" instead of ".tbz" or it won't work...

It seems to me that a better way of handling gimpshop would be as an option for
the gimp-2.4.4.ebuild controlled by a package-specific USE variable "gimpshop".
You'd need a patch file to transform the raw gimp source into the gimpshop
source, but diff should produce that easily enough.

I did exactly what James P. Barrett suggested. 

The ebuild is here:
http://n.ethz.ch/student/homartin/download/gimp-2.2.4.ebuild

Created an attachment (id=55389) [details]
gimp-2.2.4.ebuild with gimpshop

This is the gimp-2.2.4.ebuild by Martin Hoffmann (big thanks!) with some
corrections. The ltmain.sh- and the gimpshop-patch must be manually downloaded
into the /usr/local/portage/media-gfx/gimp/files/ directory.

Created an attachment (id=55390) [details]
gimp-2.2.4-gimpshop.patch

Created an attachment (id=55391) [details]
ltmain_sh-1.5.0-fix-relink.patch

(From update of attachment 55389 [details])
I also removed the pygimp-logo-thing, not necessary anymore, because the logo
is included in the 2.2.4 source.

As the ebuild is right now, the patches do not have to be downloaded or copied
seperately!

The ebuild manages that, but the patches are downloaded to the distfiles
directory. I did not manage to get the patch files (or better said only the 4k
big ltmain_sh-1.5.0-fix-relink.patch) to the files directory. As I heard, this
is not possible. 

Btw, the gimpshop.patch is 128k and should therefore not be in ${FILESDIR}.
But, as we are talking about the overlay emerge sync will not influence it. 

So, after some emailing with Sebastian Wramba, I decided to change the ebuild
in a way, so that the patchfiles have to be copied to gimp's overlay files
directory _manually_, as it seems this is the preferable way of making overlay
ebuild.

Apologies, this is my first ebuild, I wanted to make life for people easier!

The 'fixed' ebuild is online NOW!

I don't believe it is right to add this to portage in its current state. It
isn't officially supported by upstream gimp authors, its still in an early
state of development, no clue what sort of support if any comes from the patch
author, and there really isn't enough dev power to split and track this. 

This doesn't meet any of the requirements for addnig a features patch. Also the
message on the front page of the site stating I am not a programmer and went
about this hack in the totally wrong way isn't exactly comforting for me.

Here are TWO ebuilds from two different people. And not both say the ebuild is
a hack. 

In fact, I changed only some letters and added one line to the
gimp-2.2.3.ebuild. 

The only thing different to 2.2.3, except from installing 2.2.4 instead of
2.2.3, is to apply a patch.

*** Bug 103283 has been marked as a duplicate of this bug. ***

gimpshop just made slashdot again today.

this program is much more stable than most masked packages.

Sorry, nobody has time to test it now and isn't really of primary importance

cinelerra made slashdot but isn't in portage since is too problematic.

Given that gimp has a theme feature it could be exploited to add that look and
feel or extended to allow that. If you proponents have enough time you should
have a look and try that way..

Luca, who are you speaking on behalf of when you say that no one has time to
test it now?

gnome and graphics herd are currently swamped with other issues 

Hopefully one of our osx devs may have enough time to test it.

Anyway don't hold your breath yet.

This version of gimp isn't in the tree anymore. Submitting a cleaner patch
against a current gimp ebuild 
might speed this up a little. 

Not exactly a trivial patch, keeping upstream gimp and the gimpshop patch in
sync via portage could 
prove to be quite time consuming maintenance-wise...

*** Bug 107615 has been marked as a duplicate of this bug. ***

Created an attachment (id=75697) [details]
diff from media-gfx/gimp-2.2.8-r1

hi,
Here is a diff from gimp-2.2.8-r1
- useflag gimpshop is added
- some infos to help users who want same shortcuts than photoshop

In this ebuild, I'm presumming that the patch (obtained with diff -rau, and
compressed with bzip2) will be hosted in gentoo mirrors and not in rsync
severs.
I'm not sure that this is ok to post a 240K file in bugzilla. You can find it
here in plain text : http://www.zouaoui.org/gimpshop-2.2.8.patch , or here in
compressed format : http://www.zouaoui.org/gimpshop-2.2.8.patch.bz2

*** Bug 121591 has been marked as a duplicate of this bug. ***

Created an attachment (id=79299) [details]
Latest Version

Just finished compiling :D

Created an attachment (id=98065) [details]
gimpshop 2.2.11

Created an attachment (id=98066) [details]
patch to libpng >=1.2.10

*** Bug 157556 has been marked as a duplicate of this bug. ***

I have few errors  with latest ebuild:

1. Help file url is not found here's the fix:

Change this:
P_HELP="gimp-help-2-0.9" #gimp-help-2-{version}
S_HELP="$WORKDIR/${P_HELP}"
SRC_URI="http://www.plasticbugs.com/blogimg/gimpshop-${PV}.tar.bz2
doc? ( mirror://gimp/help/testing/${P_HELP}.tar.gz )"
to:
P_HELP="gimp-help-2.4.0" #gimp-help-2-{version}
S_HELP="$WORKDIR/${P_HELP}"
SRC_URI="http://www.plasticbugs.com/blogimg/gimpshop-${PV}.tar.bz2
    doc? (
ftp://unix.hensa.ac.uk/sites/ftp.gimp.org/pub/gimp/help/${P_HELP}.tar.bz2 )"


2. I have an error on 67'th line when emerging this ebuild. I think it have a
wrong directory name here change this:
 mv ${PORTAGE_TMPDIR}/portage/gimpshop-${PV}/work/gimp-${PV}
${PORTAGE_TMPDIR}/portage/gimpshop-${PV}/work/gimpshop-${PV}
to 
 mv ${PORTAGE_TMPDIR}/portage/media-gfx/gimpshop-${PV}/work/gimp-${PV}
${PORTAGE_TMPDIR}/portage/media-gfx/gimpshop-${PV}/work/gimpshop-${PV}


 At least it worked for me