First Last Prev Next    No search results available      Search page      Enter new bug
Bug#: 83779
Alias:
Product:
Component:
Status: RESOLVED
Resolution: FIXED
Assigned To: Lim Swee Tat (RETIRED) <st_lim@gentoo.org>
Hardware:
OS:
Version:
Priority:
Severity:
Reporter: Mike Nerone <mike@nerone.org>
Add CC:
CC:
URL:
Summary:
Status Whiteboard:
Keywords:

Filename Description Type Creator Created Size Actions
dspam-3.4_rc2.ebuild.patch Patch for dspam-3.4_rc2.ebuild patch Mike Nerone 2005-03-02 00:48 0000 999 bytes Details | Diff
dspam-3.4_rc2.ebuild.patch New patch for dspam-3.4_rc2.ebuild patch Mike Nerone 2005-03-02 01:08 0000 1.07 KB Details | Diff
Create a New Attachment (proposed patch, testcase, etc.) View All

Bug 83779 depends on: Show dependency tree
Bug 83779 blocks:
Votes: 0    Show votes for this bug    Vote for this bug

Additional Comments: (this is where you put emerge --info)


Not eligible to see or edit group visibility for this bug.






View Bug Activity   |   Format For Printing   |   XML   |   Clone This Bug

Description:   Opened: 2005-03-02 00:46 0000 
Note that I'm looking at mail-filter/dspam-3.4_rc2, but at a glance it looks
like this applies to all ebuilds currently in the tree.

Basically, there are some big problems with the dodocs:

  1. Things like "dodoc src/tools.mysql_drv/README" overwrite the *main*
README. Big no-no.
  2. "dodoc ${FILESDIR}/README.postfix ${FILESDIR}/README.qmail" overwrites
files with the same names provided by upstream. In the case of README.postfix,
a set of useful and detailed instructions is overwritten by what I can only
describe as a five-line stream-of-consciousness quasi-haiku. :P
  3. The file "UPGRADING" is left out, but contains important info for many
users. In any case, upstream docs should be provided, IMHO.

------- Comment #1 From Mike Nerone 2005-03-02 00:48:21 0000 ------- 
Created an attachment (id=52436) [details]
Patch for dspam-3.4_rc2.ebuild

Here is a patch for dspam-3.4_rc2.ebuild that fixes all of these problems.

Note 1: in FILESDIR, README.* should also be renamed to README.gentoo.* (is the
README.postfix haiku even useful to anybody???). Changing the corresponding
dodoc lines in the older, stable ebuilds is so trivial that it's ok to do so
with care, IMHO. If you disagree, just copy the files to the new names instead.
Then the old names can eventually go away when the old ebuilds are purged from
the tree.

Note 2: I've preserved the behavior of only installing the README.<backend>_drv
indicated by USE, but you might consider just including all of the
upstream-provided docs.

------- Comment #2 From Mike Nerone 2005-03-02 01:08:23 0000 ------- 
Created an attachment (id=52437) [details]
New patch for dspam-3.4_rc2.ebuild

On second thought, I think it should be made clearer that the READMEs from
FILESDIR are provided by gentoo, and not upstream. This patch makes the ebuild
put them in a "gentoo" subdirectory instead. Happily, this also makes it
unnecessary to rename them at all. :)

------- Comment #3 From Lim Swee Tat (RETIRED) 2005-03-08 23:07:25 0000 ------- 
Hi,
  Thank you very much for this help. :)  I'm glad someone caught something I missed all this while. :)

Ciao
ST Lim

------- Comment #4 From Mike Nerone 2005-03-21 01:03:14 0000 ------- 
For anyone reading this later, this comes up again in bug #86099.
First Last Prev Next    No search results available      Search page      Enter new bug