Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 76071 - MPlayer ebuild should enable mmx, 3dnow, and sse for amd64.
Summary: MPlayer ebuild should enable mmx, 3dnow, and sse for amd64.
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: AMD64 All
: High normal (vote)
Assignee: Gentoo Media-video project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-12-29 13:12 UTC by Aaron Gyes
Modified: 2005-01-29 23:21 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
mplayer-1.0_pre6.patch (patch,781 bytes, patch)
2005-01-04 08:12 UTC, Georgi Georgiev
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aaron Gyes 2004-12-29 13:12:14 UTC
The useflags are disabled on AMD64, so it'd probably be useful if the build could detect the arch and enable them.

When I run mplayer I see:

MMX supported but disabled
MMX2 supported but disabled
3DNow supported but disabled
3DNowExt supported but disabled

:(
Comment 1 Georgi Georgiev 2004-12-29 23:10:55 UTC
I'd like to add that I did change the ebuild, compiled mplayer, and it works just fine. It now only says that:

Cannot test OS support for SSE, disabling to be safe.
Comment 2 Roland Bär 2005-01-04 05:09:38 UTC
Georgi, could you please attach your change ebuild? Thanks, Roland
Comment 3 Georgi Georgiev 2005-01-04 08:12:03 UTC
Created attachment 47595 [details, diff]
mplayer-1.0_pre6.patch

Here is the patch for the ebuild. Some of the lines I didn't indent in order to
keep the changes as little as possible.
Comment 4 Aaron Gyes 2005-01-04 17:07:52 UTC
Well, if it's "disabling to be safe" I don't think the changed ebuild matters too much, perhaps someone should hack at mplayer? Should I report upstream?
Comment 5 Aaron Gyes 2005-01-04 17:10:16 UTC
also: For the ebuild to be valid you'll want to add amd64 to IUSE.
Comment 6 Georgi Georgiev 2005-01-05 06:10:15 UTC
Re: comment #4

You only refer to the SSE support in your message. However, the changed ebuild seems to remove the warnings about mmx, mmx2, 3dnow and 3dnowext. That's a plus by itself I think.

Re: comment #5

I didn't know that the keyword-specific use flags need to be added to IUSE. After all, there is "if use ppc64", "use sparc &&" inside the ebuild already, and these are not mentioned in IUSE. Plus, my patch adds an "use amd64" and an "use x86" check to the ebuild (point being, you didn't mention x86).
Comment 7 Herbie Hopkins (RETIRED) gentoo-dev 2005-01-24 04:28:09 UTC
This stuff was added on Jan 11th:

    # mplayer now contains SIMD assembler code for amd64
    # AMD64 Team decided to hardenable SIMD assembler for all users
    # Danny van Dyk <kugelfang@gentoo.org> 2005/01/11
    if use amd64; then
        myconf="${myconf} --enable-3dnow --enable-3dnowex --enable-sse --enable- mmx --enable-mmx2"
    fi

so this bug may as well be closed.
Comment 8 Chris White (RETIRED) gentoo-dev 2005-01-29 23:21:22 UTC
And so it is..