I am getting a compile error when attempting to emerge gtkskan. Here is the emerge output, starting a couple of lines before the error: gcc -march=pentium2 -O2 -pipe -I. -I/usr/include/gtk-1.2 -I/usr/include/glib-1.2 -I/usr/lib/glib/include -I/usr/X11R6/include -DGLIBC22_HEADERS -DDATA_DIR=\"/usr/share/gtkskan\" -c -o skan_config.o skan_config.c skan_config.c:4:31: libgnome/libgnome.h: No such file or directory skan_config.c: In function `gtkskan_load_config': skan_config.c:16: warning: assignment makes pointer from integer without a cast skan_config.c:24: warning: assignment makes pointer from integer without a cast skan_config.c: In function `gtkskan_get_interface_list': skan_config.c:38: error: `FILE' undeclared (first use in this function) skan_config.c:38: error: (Each undeclared identifier is reported only once skan_config.c:38: error: for each function it appears in.) skan_config.c:38: error: `fp' undeclared (first use in this function) skan_config.c:43: error: `EOF' undeclared (first use in this function) make[1]: *** [skan_config.o] Error 1 make[1]: *** Waiting for unfinished jobs.... In file included from scan_data.h:4, from gtkskan.h:5, from gtkskan.c:6: iwcommon.h:244:8: warning: extra tokens at end of #endif directive iwcommon.h:249:8: warning: extra tokens at end of #endif directive In file included from scan_data.h:4, from gtkskan.h:5, from skan.h:5, from skan.c:3: iwcommon.h:244:8: warning: extra tokens at end of #endif directive iwcommon.h:249:8: warning: extra tokens at end of #endif directive make[1]: Leaving directory `/var/tmp/portage/gtkskan-0.2/work/gtkskan-0.2/src' make: *** [all] Error 1 !!! ERROR: net-wireless/gtkskan-0.2 failed. !!! Function src_compile, Line 33, Exitcode 2 !!! (no error message) !!! If you need support, post the topmost build error, NOT this status message. Reproducible: Always Steps to Reproduce: 1. emerge gtkskan 2. 3. Actual Results: Unable to emerge gtkskan due to compile error. Expected Results: Expected compilation to complete and application to be installed. nirvana akruse # emerge info Portage 2.0.51-r3 (default-linux/x86/2004.3, gcc-3.3.4, glibc-2.3.4.20040808-r1, 2.6.9-gentoo-r6 i686) ================================================================= System uname: 2.6.9-gentoo-r6 i686 Mobile Pentium II Gentoo Base System version 1.4.16 distcc 2.16 i686-pc-linux-gnu (protocols 1 and 2) (default port 3632) [disabled] Autoconf: sys-devel/autoconf-2.59-r5 Automake: sys-devel/automake-1.8.5-r1 Binutils: sys-devel/binutils-2.15.90.0.1.1-r3 Headers: sys-kernel/linux-headers-2.4.21-r1 Libtools: sys-devel/libtool-1.5.2-r7 ACCEPT_KEYWORDS="x86" AUTOCLEAN="yes" CFLAGS="-march=pentium2 -O2 -pipe" CHOST="i686-pc-linux-gnu" COMPILER="" CONFIG_PROTECT="/etc /usr/X11R6/lib/X11/xkb /usr/kde/2/share/config /usr/kde/3.3/env /usr/kde/3.3/share/config /usr/kde/3.3/shutdown /usr/kde/3/share/config /usr/share/config /var/qmail/control" CONFIG_PROTECT_MASK="/etc/gconf /etc/terminfo /etc/env.d" CXXFLAGS="-march=pentium2 -O2 -pipe" DISTDIR="/usr/portage/distfiles" FEATURES="autoaddcvs autoconfig ccache distlocks sandbox sfperms" GENTOO_MIRRORS="http://gentoo.osuosl.org http://distro.ibiblio.org/pub/Linux/distributions/gentoo" MAKEOPTS="-j3" PKGDIR="/usr/portage/packages" PORTAGE_TMPDIR="/var/tmp" PORTDIR="/usr/portage" PORTDIR_OVERLAY="" SYNC="rsync://rsync.gentoo.org/gentoo-portage" USE="x86 X acl alsa apm arts avi berkdb bitmap-fonts crypt cups dvd encode foomaticdb fortran gdbm gif gpm gtk gtk2 ipv6 java jpeg kde libwww mad mikmod mmx motif mozdevelop mozilla moznomail mpeg ncurses nls oggvorbis opengl oss pam pdflib perl png python qt quicktime readline samba sdl spell ssl svga tcpd tiff truetype usb xml2 xmms xv zlib"
skan_config.c:4:31: libgnome/libgnome.h: No such file or directory Are we missing a dependency on gnome here? Ebuild only specifies gnome-1 support, ./configure ignores the --without-gnome flag. And compiles fine without gnome-core 1.4 (I have gnome 2.8 installed aswell some of the gnome 1.4 stuff, but not gnome-core 1.4). skan_config.c:38: error: `FILE' undeclared (first use in this function) stdio.h is not included, for me this file is problably included via other libraries Conclusion: Make gnome-libs 1.4 required and not optional Remove gnome-core 1.4 dependency in total. Perhaps patch skan_config.c include stdio.h since it uses FILE *, just for the sanity. OR In general gtkskan should be rewritten for gnome2 or gconf2 support. As far as I can see, it only uses gnome for storing config. I could write that patch if needed.
Created attachment 46940 [details, diff] replace gnome with gconf, and upgrade gtk (configure) Removes gnome 1.4 dependency and replaces it with gconf instead. Also using gtk 2.x instead of gtk 1.x. It makes gconf so much more happy since gconf use glib 2.x due to GError. Please update ebuild and use this patch. It is about time to upgrade all old gtk 1.x apps to 2.x.
Comment on attachment 46940 [details, diff] replace gnome with gconf, and upgrade gtk (configure) >Only in gtkskan-0.2-new/: Makefile >Only in gtkskan-0.2-new/: aclocal.m4 >Only in gtkskan-0.2-new/: config.cache >Only in gtkskan-0.2-new/: config.log >Only in gtkskan-0.2-new/: config.status >diff -ur gtkskan-0.2-orig/configure gtkskan-0.2-new/configure >--- gtkskan-0.2-orig/configure 2004-12-27 06:15:41.316147688 +0100 >+++ gtkskan-0.2-new/configure 2004-12-27 07:01:08.174602192 +0100 >@@ -1355,19 +1355,23 @@ > done > > >-# Extract the first word of "gtk-config", so it can be a program name with args. >-set dummy gtk-config; ac_word=$2 >+ >+ succeeded=no >+ >+ if test -z "$PKG_CONFIG"; then >+ # Extract the first word of "pkg-config", so it can be a program name with args. >+set dummy pkg-config; ac_word=$2 > echo $ac_n "checking for $ac_word""... $ac_c" 1>&6 >-echo "configure:1362: checking for $ac_word" >&5 >-if eval "test \"`echo '$''{'ac_cv_path_gtkpath'+set}'`\" = set"; then >+echo "configure:1366: checking for $ac_word" >&5 >+if eval "test \"`echo '$''{'ac_cv_path_PKG_CONFIG'+set}'`\" = set"; then > echo $ac_n "(cached) $ac_c" 1>&6 > else >- case "$gtkpath" in >+ case "$PKG_CONFIG" in > /*) >- ac_cv_path_gtkpath="$gtkpath" # Let the user override the test with a path. >+ ac_cv_path_PKG_CONFIG="$PKG_CONFIG" # Let the user override the test with a path. > ;; > ?:/*) >- ac_cv_path_gtkpath="$gtkpath" # Let the user override the test with a dos path. >+ ac_cv_path_PKG_CONFIG="$PKG_CONFIG" # Let the user override the test with a dos path. > ;; > *) > IFS="${IFS= }"; ac_save_ifs="$IFS"; IFS=":" >@@ -1375,40 +1379,87 @@ > for ac_dir in $ac_dummy; do > test -z "$ac_dir" && ac_dir=. > if test -f $ac_dir/$ac_word; then >- ac_cv_path_gtkpath="$ac_dir/$ac_word" >+ ac_cv_path_PKG_CONFIG="$ac_dir/$ac_word" > break > fi > done > IFS="$ac_save_ifs" >+ test -z "$ac_cv_path_PKG_CONFIG" && ac_cv_path_PKG_CONFIG="no" > ;; > esac > fi >-gtkpath="$ac_cv_path_gtkpath" >-if test -n "$gtkpath"; then >- echo "$ac_t""$gtkpath" 1>&6 >+PKG_CONFIG="$ac_cv_path_PKG_CONFIG" >+if test -n "$PKG_CONFIG"; then >+ echo "$ac_t""$PKG_CONFIG" 1>&6 > else > echo "$ac_t""no" 1>&6 > fi > >-echo $ac_n "checking for GTK compile flags""... $ac_c" 1>&6 >-echo "configure:1395: checking for GTK compile flags" >&5 >-GTK_CFLAGS=`$gtkpath --cflags 2>/dev/null` >-GTK_LDFLAGS=`$gtkpath --libs gthread 2>/dev/null` >-echo "$ac_t""ok" 1>&6 >+ fi > >-# Extract the first word of "gnome-config", so it can be a program name with args. >-set dummy gnome-config; ac_word=$2 >+ if test "$PKG_CONFIG" = "no" ; then >+ echo "*** The pkg-config script could not be found. Make sure it is" >+ echo "*** in your path, or set the PKG_CONFIG environment variable" >+ echo "*** to the full path to pkg-config." >+ echo "*** Or see http://www.freedesktop.org/software/pkgconfig to get pkg-config." >+ else >+ PKG_CONFIG_MIN_VERSION=0.9.0 >+ if $PKG_CONFIG --atleast-pkgconfig-version $PKG_CONFIG_MIN_VERSION; then >+ echo $ac_n "checking for gtk+-2.0 >= 2.4.0 ""... $ac_c" 1>&6 >+echo "configure:1410: checking for gtk+-2.0 >= 2.4.0 " >&5 >+ >+ if $PKG_CONFIG --exists "gtk+-2.0 >= 2.4.0 " ; then >+ echo "$ac_t""yes" 1>&6 >+ succeeded=yes >+ >+ echo $ac_n "checking GTK_CFLAGS""... $ac_c" 1>&6 >+echo "configure:1417: checking GTK_CFLAGS" >&5 >+ GTK_CFLAGS=`$PKG_CONFIG --cflags "gtk+-2.0 >= 2.4.0 "` >+ echo "$ac_t""$GTK_CFLAGS" 1>&6 >+ >+ echo $ac_n "checking GTK_LIBS""... $ac_c" 1>&6 >+echo "configure:1422: checking GTK_LIBS" >&5 >+ GTK_LIBS=`$PKG_CONFIG --libs "gtk+-2.0 >= 2.4.0 "` >+ echo "$ac_t""$GTK_LIBS" 1>&6 >+ else >+ GTK_CFLAGS="" >+ GTK_LIBS="" >+ ## If we have a custom action on failure, don't print errors, but >+ ## do set a variable so people can do so. >+ GTK_PKG_ERRORS=`$PKG_CONFIG --errors-to-stdout --print-errors "gtk+-2.0 >= 2.4.0 "` >+ echo $GTK_PKG_ERRORS >+ fi >+ >+ >+ >+ else >+ echo "*** Your version of pkg-config is too old. You need version $PKG_CONFIG_MIN_VERSION or newer." >+ echo "*** See http://www.freedesktop.org/software/pkgconfig" >+ fi >+ fi >+ >+ if test $succeeded = yes; then >+ : >+ else >+ { echo "configure: error: Library requirements (gtk+-2.0 >= 2.4.0 ) not met; consider adjusting the PKG_CONFIG_PATH environment variable if your libraries are in a nonstandard prefix so pkg-config can find them." 1>&2; exit 1; } >+ fi >+ >+ succeeded=no >+ >+ if test -z "$PKG_CONFIG"; then >+ # Extract the first word of "pkg-config", so it can be a program name with args. >+set dummy pkg-config; ac_word=$2 > echo $ac_n "checking for $ac_word""... $ac_c" 1>&6 >-echo "configure:1403: checking for $ac_word" >&5 >-if eval "test \"`echo '$''{'ac_cv_path_gnomepath'+set}'`\" = set"; then >+echo "configure:1454: checking for $ac_word" >&5 >+if eval "test \"`echo '$''{'ac_cv_path_PKG_CONFIG'+set}'`\" = set"; then > echo $ac_n "(cached) $ac_c" 1>&6 > else >- case "$gnomepath" in >+ case "$PKG_CONFIG" in > /*) >- ac_cv_path_gnomepath="$gnomepath" # Let the user override the test with a path. >+ ac_cv_path_PKG_CONFIG="$PKG_CONFIG" # Let the user override the test with a path. > ;; > ?:/*) >- ac_cv_path_gnomepath="$gnomepath" # Let the user override the test with a dos path. >+ ac_cv_path_PKG_CONFIG="$PKG_CONFIG" # Let the user override the test with a dos path. > ;; > *) > IFS="${IFS= }"; ac_save_ifs="$IFS"; IFS=":" >@@ -1416,31 +1467,75 @@ > for ac_dir in $ac_dummy; do > test -z "$ac_dir" && ac_dir=. > if test -f $ac_dir/$ac_word; then >- ac_cv_path_gnomepath="$ac_dir/$ac_word" >+ ac_cv_path_PKG_CONFIG="$ac_dir/$ac_word" > break > fi > done > IFS="$ac_save_ifs" >+ test -z "$ac_cv_path_PKG_CONFIG" && ac_cv_path_PKG_CONFIG="no" > ;; > esac > fi >-gnomepath="$ac_cv_path_gnomepath" >-if test -n "$gnomepath"; then >- echo "$ac_t""$gnomepath" 1>&6 >+PKG_CONFIG="$ac_cv_path_PKG_CONFIG" >+if test -n "$PKG_CONFIG"; then >+ echo "$ac_t""$PKG_CONFIG" 1>&6 > else > echo "$ac_t""no" 1>&6 > fi > >-echo $ac_n "checking for Gnome compile flags""... $ac_c" 1>&6 >-echo "configure:1436: checking for Gnome compile flags" >&5 >-GNOME_CFLAGS=`$gnomepath gnome --cflags 2>/dev/null` >-GNOME_LDFLAGS=`$gnomepath gnome --libs 2>/dev/null` >-echo "$ac_t""ok" 1>&6 >+ fi >+ >+ if test "$PKG_CONFIG" = "no" ; then >+ echo "*** The pkg-config script could not be found. Make sure it is" >+ echo "*** in your path, or set the PKG_CONFIG environment variable" >+ echo "*** to the full path to pkg-config." >+ echo "*** Or see http://www.freedesktop.org/software/pkgconfig to get pkg-config." >+ else >+ PKG_CONFIG_MIN_VERSION=0.9.0 >+ if $PKG_CONFIG --atleast-pkgconfig-version $PKG_CONFIG_MIN_VERSION; then >+ echo $ac_n "checking for gconf-2.0 >= 0.15.0 ""... $ac_c" 1>&6 >+echo "configure:1498: checking for gconf-2.0 >= 0.15.0 " >&5 >+ >+ if $PKG_CONFIG --exists "gconf-2.0 >= 0.15.0 " ; then >+ echo "$ac_t""yes" 1>&6 >+ succeeded=yes >+ >+ echo $ac_n "checking GCONF_CFLAGS""... $ac_c" 1>&6 >+echo "configure:1505: checking GCONF_CFLAGS" >&5 >+ GCONF_CFLAGS=`$PKG_CONFIG --cflags "gconf-2.0 >= 0.15.0 "` >+ echo "$ac_t""$GCONF_CFLAGS" 1>&6 >+ >+ echo $ac_n "checking GCONF_LIBS""... $ac_c" 1>&6 >+echo "configure:1510: checking GCONF_LIBS" >&5 >+ GCONF_LIBS=`$PKG_CONFIG --libs "gconf-2.0 >= 0.15.0 "` >+ echo "$ac_t""$GCONF_LIBS" 1>&6 >+ else >+ GCONF_CFLAGS="" >+ GCONF_LIBS="" >+ ## If we have a custom action on failure, don't print errors, but >+ ## do set a variable so people can do so. >+ GCONF_PKG_ERRORS=`$PKG_CONFIG --errors-to-stdout --print-errors "gconf-2.0 >= 0.15.0 "` >+ echo $GCONF_PKG_ERRORS >+ fi >+ >+ >+ >+ else >+ echo "*** Your version of pkg-config is too old. You need version $PKG_CONFIG_MIN_VERSION or newer." >+ echo "*** See http://www.freedesktop.org/software/pkgconfig" >+ fi >+ fi > >+ if test $succeeded = yes; then >+ : >+ else >+ { echo "configure: error: Library requirements (gconf-2.0 >= 0.15.0 ) not met; consider adjusting the PKG_CONFIG_PATH environment variable if your libraries are in a nonstandard prefix so pkg-config can find them." 1>&2; exit 1; } >+ fi >+ > # Extract the first word of "esd-config", so it can be a program name with args. > set dummy esd-config; ac_word=$2 > echo $ac_n "checking for $ac_word""... $ac_c" 1>&6 >-echo "configure:1444: checking for $ac_word" >&5 >+echo "configure:1539: checking for $ac_word" >&5 > if eval "test \"`echo '$''{'ac_cv_path_esdpath'+set}'`\" = set"; then > echo $ac_n "(cached) $ac_c" 1>&6 > else >@@ -1473,13 +1568,13 @@ > fi > > echo $ac_n "checking for ESD compile flags""... $ac_c" 1>&6 >-echo "configure:1477: checking for ESD compile flags" >&5 >+echo "configure:1572: checking for ESD compile flags" >&5 > ESD_CFLAGS=`$esdpath --cflags 2>/dev/null` > ESD_LDFLAGS=`$esdpath --libs 2>/dev/null` > echo "$ac_t""ok" 1>&6 > >-LIBS="$LIBS $ESD_LDFLAGS $GTK_LDFLAGS $GNOME_LDFLAGS" >-CFLAGS="$CFLAGS $ESD_CFLAGS $GTK_CFLAGS $GNOME_CFLAGS" >+LIBS="$LIBS $ESD_LDFLAGS $GTK_LIBS $GCONF_LIBS" >+CFLAGS="$CFLAGS $ESD_CFLAGS $GTK_CFLAGS $GCONF_CFLAGS" > > trap '' 1 2 15 > cat > confcache <<\EOF >@@ -1636,8 +1731,11 @@ > s%@INSTALL_SCRIPT@%$INSTALL_SCRIPT%g > s%@INSTALL_DATA@%$INSTALL_DATA%g > s%@CPP@%$CPP%g >-s%@gtkpath@%$gtkpath%g >-s%@gnomepath@%$gnomepath%g >+s%@PKG_CONFIG@%$PKG_CONFIG%g >+s%@GTK_CFLAGS@%$GTK_CFLAGS%g >+s%@GTK_LIBS@%$GTK_LIBS%g >+s%@GCONF_CFLAGS@%$GCONF_CFLAGS%g >+s%@GCONF_LIBS@%$GCONF_LIBS%g > s%@esdpath@%$esdpath%g > > CEOF >diff -ur gtkskan-0.2-orig/configure.in gtkskan-0.2-new/configure.in >--- gtkskan-0.2-orig/configure.in 2004-12-27 06:15:41.316147688 +0100 >+++ gtkskan-0.2-new/configure.in 2004-12-27 07:01:06.524852992 +0100 >@@ -24,17 +24,8 @@ > AC_PROG_GCC_TRADITIONAL > AC_CHECK_FUNCS(select socket strdup strerror) > >-AC_PATH_PROG(gtkpath, gtk-config) >-AC_MSG_CHECKING(for GTK compile flags) >-GTK_CFLAGS=`$gtkpath --cflags 2>/dev/null` >-GTK_LDFLAGS=`$gtkpath --libs gthread 2>/dev/null` >-AC_MSG_RESULT(ok) >- >-AC_PATH_PROG(gnomepath, gnome-config) >-AC_MSG_CHECKING(for Gnome compile flags) >-GNOME_CFLAGS=`$gnomepath gnome --cflags 2>/dev/null` >-GNOME_LDFLAGS=`$gnomepath gnome --libs 2>/dev/null` >-AC_MSG_RESULT(ok) >+PKG_CHECK_MODULES(GTK, gtk+-2.0 >= 2.4.0 ) dnl what version ? >+PKG_CHECK_MODULES(GCONF, gconf-2.0 >= 0.15.0 ) dnl what version ? > > AC_PATH_PROG(esdpath, esd-config) > AC_MSG_CHECKING(for ESD compile flags) >@@ -42,8 +33,8 @@ > ESD_LDFLAGS=`$esdpath --libs 2>/dev/null` > AC_MSG_RESULT(ok) > >-LIBS="$LIBS $ESD_LDFLAGS $GTK_LDFLAGS $GNOME_LDFLAGS" >-CFLAGS="$CFLAGS $ESD_CFLAGS $GTK_CFLAGS $GNOME_CFLAGS" >+LIBS="$LIBS $ESD_LDFLAGS $GTK_LIBS $GCONF_LIBS" >+CFLAGS="$CFLAGS $ESD_CFLAGS $GTK_CFLAGS $GCONF_CFLAGS" > > AC_OUTPUT([ > Makefile >Only in gtkskan-0.2-new/data: Makefile >Only in gtkskan-0.2-new/src: Makefile >diff -ur gtkskan-0.2-orig/src/Makefile.in gtkskan-0.2-new/src/Makefile.in >--- gtkskan-0.2-orig/src/Makefile.in 2004-12-27 06:15:41.317147536 +0100 >+++ gtkskan-0.2-new/src/Makefile.in 2004-12-27 06:42:30.992439696 +0100 >@@ -19,7 +19,7 @@ > CPPFLAGS = @CPPFLAGS@ > CFLAGS = $(CPPFLAGS) @CFLAGS@ $(DEFINES) > LIBS = @LIBS@ >-LDFLAGS = @LDFLAGS@ $(GNOME_LDFLAGS) $(LIBS) >+LDFLAGS = @LDFLAGS@ $(LIBS) > INSTALL = @INSTALL@ > WIRELESS_TOOLS_DIR = wireless_tools.22 > LIBNMEA = nmea/libnmea.a >diff -ur gtkskan-0.2-orig/src/nmea/Makefile gtkskan-0.2-new/src/nmea/Makefile >--- gtkskan-0.2-orig/src/nmea/Makefile 2004-12-27 06:15:41.318147384 +0100 >+++ gtkskan-0.2-new/src/nmea/Makefile 2004-12-27 07:01:13.286825016 +0100 >@@ -16,9 +16,9 @@ > > CC = gcc > CPPFLAGS = >-CFLAGS = $(CPPFLAGS) -g -O2 -I/usr/include/gtk-1.2 -I/usr/include/glib-1.2 -I/usr/lib/glib/include -I/usr/include -DNEED_GNOMESUPPORT_H -I/usr/lib/gnome-libs/include -I/usr/include/gtk-1.2 -I/usr/include/glib-1.2 -I/usr/lib/glib/include $(DEFINES) >+CFLAGS = $(CPPFLAGS) -g -O2 -DXTHREADS -D_REENTRANT -DXUSE_MTSAFE_API -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/X11R6/include -I/usr/include/atk-1.0 -I/usr/include/pango-1.0 -I/usr/include/freetype2 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -DORBIT2=1 -pthread -I/usr/include/gconf/2 -I/usr/include/orbit-2.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include $(DEFINES) > LDFLAGS = >-INSTALL = /usr/bin/install -c >+INSTALL = /bin/install -c > > # these need static libs: -lXext -lX11 > >diff -ur gtkskan-0.2-orig/src/skan.c gtkskan-0.2-new/src/skan.c >--- gtkskan-0.2-orig/src/skan.c 2004-12-27 06:15:41.317147536 +0100 >+++ gtkskan-0.2-new/src/skan.c 2004-12-27 06:54:41.271420416 +0100 >@@ -176,11 +176,11 @@ > gtk_widget_show (menubar); > > // K,: now for the toolbar >- toolbar = gtk_toolbar_new ( GTK_ORIENTATION_HORIZONTAL, >- GTK_TOOLBAR_BOTH ); >- gtk_container_set_border_width ( GTK_CONTAINER ( toolbar ) , 1 ); >- gtk_toolbar_set_space_size ( GTK_TOOLBAR ( toolbar ), 0 ); >- >+ toolbar = gtk_toolbar_new ( ); >+ gtk_toolbar_set_orientation ( GTK_TOOLBAR(toolbar), GTK_ORIENTATION_HORIZONTAL ); >+ gtk_toolbar_set_style ( GTK_TOOLBAR(toolbar), GTK_TOOLBAR_BOTH ); >+ gtk_container_set_border_width ( GTK_CONTAINER(toolbar), 1 ); >+ > // And now for the go pixmap icon dealy > style = gtk_widget_get_style( window ); > >@@ -254,9 +254,6 @@ > "Exit", "Exit gtkskan", "Private", iconw, > GTK_SIGNAL_FUNC (destroy), NULL ); > >- >- gtk_toolbar_set_space_size (GTK_TOOLBAR(toolbar), 6); >- > // Add the toolbar to the vbox (box1) and a seperator > gtk_box_pack_start(GTK_BOX (box1), toolbar, FALSE, FALSE, 0); > gtk_widget_show(toolbar); >diff -ur gtkskan-0.2-orig/src/skan_config.c gtkskan-0.2-new/src/skan_config.c >--- gtkskan-0.2-orig/src/skan_config.c 2004-12-27 06:15:41.318147384 +0100 >+++ gtkskan-0.2-new/src/skan_config.c 2004-12-27 06:53:18.373022888 +0100 >@@ -1,36 +1,61 @@ > /* gtkskan configuration gui and meaty bits */ > > #include <gtk/gtk.h> >-#include <libgnome/libgnome.h> >+#include <gconf/gconf.h> >+#include <gconf/gconf-client.h> >+#include <stdio.h> > #include "skan_config.h" > > extern gtkskan_config_t skan_conf; > extern GtkWidget *main_window; > > void gtkskan_load_config(gtkskan_config_t *skan_config) { >- gboolean def; >- GString *foo = g_string_new(NULL); >+ GConfClient *gconf=NULL; >+ GConfValue *value; > >- skan_config->interface = >- gnome_config_get_string_with_default("/gtkskan/config/interface=eth0", >- &def); >- skan_config->sound = >- gnome_config_get_bool_with_default("/gtkskan/config/sound=TRUE", &def); >- >- g_string_assign(foo, "/gtkskan/config/snd_path="); >- g_string_append(foo, DATA_DIR); >- g_string_append(foo, "/netfound.wav"); >- skan_config->snd_path = gnome_config_get_string_with_default( >- foo->str, &def); >- g_string_free(foo, TRUE); >- >+ /* default values */ >+ skan_config->interface=g_strdup("eth0"); >+ skan_config->sound=TRUE; >+ skan_config->snd_path=g_strdup(DATA_DIR "/netfound.wav" ); >+ >+ if (!(gconf=gconf_client_get_default ())) >+ { /* we failed to contact gconfd */ >+ return; >+ } >+ >+ if ((value=gconf_client_get(gconf, "/apps/gtkskan/interface", NULL))) >+ { >+ g_free(skan_config->interface); >+ skan_config->interface=g_strdup(gconf_value_get_string(value)); >+ gconf_value_free(value); >+ } >+ >+ if ((value=gconf_client_get(gconf, "/apps/gtkskan/sound", NULL))) >+ { >+ skan_config->sound = gconf_value_get_bool(value); >+ gconf_value_free(value); >+ } >+ >+ if ((value=gconf_client_get(gconf, "/apps/gtkskan/snd_path", NULL))) >+ { >+ g_free(skan_config->snd_path); >+ skan_config->snd_path=g_strdup(gconf_value_get_string(value)); >+ gconf_value_free(value); >+ } >+ g_object_unref(gconf); > } > > void gtkskan_save_config(gtkskan_config_t *skan_config) { >- gnome_config_set_string("/gtkskan/config/interface", skan_config->interface); >- gnome_config_set_bool("/gtkskan/config/sound", skan_config->sound); >- gnome_config_set_string("/gtkskan/config/snd_path", skan_config->snd_path); >- gnome_config_sync(); >+ GConfClient *gconf=NULL; >+ >+ if (!(gconf=gconf_client_get_default ())) >+ { /* we failed to contact gconfd */ >+ return; >+ } >+ gconf_client_set_string(gconf, "/apps/gtkskan/interface", skan_config->interface, NULL); >+ gconf_client_set_bool(gconf, "/apps/gtkskan/sound", skan_config->sound, NULL); >+ gconf_client_set_string(gconf, "/apps/gtkskan/snd_path", skan_config->snd_path, NULL); >+ g_object_unref(gconf); > } > > GList * gtkskan_get_interface_list(void) {
Sorry about that last message. I tried to remove one un-needed thing from the patch. $(GCONF2_LDFLAGS) is not supposed to be in src/Makefile.in since those flags are set in CFLAGS, and it should had been @GCONF2_LDFLAGS@ to even have an effect. Sorry.
Hello, I appreciate all the work that has been put in this bug. However, isn't having =gnome-base/gnome-libs-1.4* in DEPEND enough?
Would be nice to have gtk and gtk2 support. if USE=gtk then it is enough to depend on gnome 1.4, but if USE=gtk2, patch is needed it then depends on gconf instead. (I, and others prefer not to install gtk 1.x and gnome 1.4)
Wrt Bug 48686, Comment #1, I'd suggest that we finally remove this thing from portage. Upstream been dead as a nail in the lamp room door, last and the only release ~5 years ago...
(In reply to comment #7) > Wrt Bug 48686, Comment #1, I'd suggest that we finally remove this thing from > portage. Upstream been dead as a nail in the lamp room door, last and the only > release ~5 years ago... Hear hear.
(In reply to comment #8) > (In reply to comment #7) > > Wrt Bug 48686, Comment #1, I'd suggest that we finally remove this thing from > > portage. Upstream been dead as a nail in the lamp room door, last and the only > > release ~5 years ago... > > Hear hear. > package.masked
(In reply to comment #9) > > package.masked > And removed.
