Bugzilla Bug 75117

ok, here is my promised work. It's still not perfect but much better than
before.

I will first attach all the stuff and then I post some explainations.
If you have any questions or suggestions, then PLEASE ask me!

And please don't fix/change anything w/o asking me before. The code and all
scripts are working perfectly for me and every single line has its story and
reason. There may be BUGs I've overseen, but again, please ask before you
change or fix anything. You could break more than you fix.


Reproducible: Always
Steps to Reproduce:

Created an attachment (id=46492) [details]
isdn-firmware-2004.4.5-r2.ebuild

PLEASE READ MY EXPLANATIONS!

Created an attachment (id=46493) [details]
capi4k-utils-20041006-r4.tar.bz2

Created an attachment (id=46494) [details]
isdn4k-utils-3.5_pre20041219.tar.bz2

ok, now some words...

1. isdn-firmware

I added the fus2base.frm and fus3base.frm to this ebuild. But Alin added them differently also to 'fritzcapi'. I'm not sure about the right place. Both are making sense.

But Alin also added a hotplug-script to fritzcapi. THIS SCRIPT *MUST* BE REMOVED! It is broken and doesn't work, if you have more than 1 card.

I would suggest to remove the hotplug-stuff from fritzcapi, but add the firmwarefiles from my SRC_URI in the attached isdn-firmware ebuild. This ebuild isn't needed then. But 'fritzcapi' has to be fixed.

2. capi4k-utils

basically a better init-script and a *working* hotplug-framework for CAPI based ISDN cards. Currently only for AVM cards, but it's designed to be used also with other cards. I had no time yet, to implement and test the PCMCIA stuff. But I have 4 different cards for testing and I will add this ASAP. But it's no showstopper. 

3. isdn4k-utils

I removed the module-loader stuff, since it was broken by design. It's much more complicated to initialize most of the cards. We need special init-scripts or every type/brand of card. I had no time to write them all yet, but I made a really neat init-script for the whole bunch of HiSax based cards. It works great! Hotplug-stuff is not implemented yet but could basically derived from the capi hotplug stuff. The needed *.usermap files are included for reference purposes in the $FILESDIR but will not be installed yet.

Furthermore: I updated the ebuild to the latest release. ;-)

ok, done. I surely have forgotten many things to mention. So please ask!

oh, yes, I forget this one:

I patch 'capiinit' (capi4k-utils) to look also in /lib/firmware for the firmware-files.

I dont think its the right way to put the fcusb files in isdn-firmware, because
when you emerge fritzcapi and have such a card, you *need* the firmware files.
I agree with you that the hotplug script is broken. But its not such an urgent
issue, because it does not install the usermap currently, so it has no effect
;)
But I agree, that it is fully replaced with your hotplug script and should be
removed asap.

Created an attachment (id=46515) [details]
firtzcapi-linux-mod.diff

I think as linux-mod is ready now, we can simplify the building process of
fritzcapi. But fcpcmcia installs afaik another fcclassic_cs.ko that we would
need to install manually. But fcpcmcia does not compile here currently. Also
all of the  pcmcia scripts are missing, so I think its best if we remove it
from the list for the time being.

ok, I agree with you with the location of the firmware-files. They only have to
be installed, when one choses to install fcusb2.ko. So 'fritzcapi' is a good
place for it.

But it would be cool to use my SRC_URI in the attached isdn-firmware ebuild.
It's a small RPM from SuSE and so we don't need a mirror://gentoo SRC_URI.

btw: have a look @ my isdn-firmware and the last in portage. My version is
slicker. ;-) So perhaps we can add it, but with the fus[23]base.frm firmware
removed.

isdn-firmware: I beautified the ebuild, without adding the fus[23]base.frm to
it.

fritzcapi: applied genstef patch and fixed some problems of the new ebuild:
  - when used FRITZCAPI_CARDS, MODULES_NAMES was empty
  - fixed fcpcmcia; install both .ko files for it
Also, I've changed SRC_URI to include the rpm suggested by sbriesen rather than
our package.

To be continued with capi4k/isdn4k...

great!

if you have any questions or suggestions, please feel free to ask!
and don't "fix" anything before asking...

capi4k-utils-20041006-r4.ebuild submitted with following changes:
  - insert /lib/firmware path as first option without deleting any other path
  - replaced $MY_FILES with $FILESDIR/$PV (no need for that from maintenance point of view)
  - rearranged variables setup order

isdn4k-utils commited with following changes:
 - version is 3.6 (look in Makefile)
 - $MY_FILES -> $FILESDIR/$PV
 - removed workaround for bug #73067 since that one is resolved

great job, Stefan!

ty. And merry xmas! ;-)

installing /etc/capi.conf in 'fritzcapi' is obsolete. Just depend on
'capi4k-utils'.

Created an attachment (id=46745) [details]
capi.initd

f.... ;-)

I uploaded an old init-script. Alin, would you be so kind an replace it with
the attached one? It's from capi4k-utils. All other things are perfect!

new init script commited.