Bugzilla Bug 70592

When starting mpg123 like this:

mpg123 --list playlist.m3u --shuffle --random --control

Upon exiting mpg123, the terminal does not echo back typed text or command history.  The only remedy that I know of is to type 'reset'.  

This behaviour only seems to become apparent when run with the --control option.  If q is pressed while playing the first song, then it exits to the terminal normailly, but if you first press f (or even ctrl-c) to skip to the next song, then press q the terminal malfunctions.  It also malfunctions if its allowed to progress to the next song normally and then exit by pressing q.

Well, after no replys, this bug either cannot be fixed, or cannot be verified.

I only discovered it because my monitor failed and my only recorse was to access my box via a remote terminal.  It was an older machine, but I still wanted to be able to hear my music while I was forced to use the other one.  I have since purchased a new monitor, and this is of little priority to me.  I did notice that there is a new version of this package, and I have decided to test it.  Below are my results:

media-sound/mpg123-0.59s-r9

Same problems, reset must be executed to return to normal operation.

I can remove most of the headaches if i add && reset at the end of the command line.

*** Bug 94494 has been marked as a duplicate of this bug. ***

Created an attachment (id=60986) [details]
Patch to avoid terminal line settings be set more than once

(In reply to comment #0)

This is because in -C mode term_init() is called everytime a new songs starts
playing, so the first run of term_init() saves the original terminal line
properties in a variable but when playing a second song the value gets
overwritten. It also results in registering term_restore() with atexit() as
many times as songs were played, but term_restore() has a check that avoids
executing it more than once.
I attached a patch that fixes it by adding the same check to term_init().

Created an attachment (id=65376) [details]
Plain-text of the above patch

I realized it shouldn't be gzipped so i'm posting the plain-text version of the
patch.
It would be good if someone added it to the ebuild cause the bug can be really
annoying and it's easy to verify, although not many people use the -C option.

This is in portage; Andrzej, thanks for your work.