Bugzilla Bug 67920

build fails on synce-rra-0.9.0, tried on several systems.

Reproducible: Always
Steps to Reproduce:
1.emerge synce-rra
2....
3.make fails

Actual Results:  
if /bin/sh ../libtool --mode=compile i686-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I.
-I. -I..    -g -Wall -Wsign-compare -Wno-long-long -Werror -ansi -march=i686
-I.. -march=i686 -MT environment.lo -MD -MP -MF ".deps/environment.Tpo" -c -o
environment.lo environment.c; \
then mv -f ".deps/environment.Tpo" ".deps/environment.Plo"; else rm -f
".deps/environment.Tpo"; exit 1; fi
appointment.c: In function `rra_appointment_from_vevent':
appointment.c:668: warning: suggest explicit braces to avoid ambiguous `else'
make[2]: *** [appointment.lo] Error 1
make[2]: *** Waiting for unfinished jobs....
 i686-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I. -I.. -g -Wall -Wsign-compare
-Wno-long-long -Werror -ansi -march=i686 -I.. -march=i686 -MT contact.lo -MD -MP
-MF .deps/contact.Tpo -c contact.c  -fPIC -DPIC -o .libs/contact.o
 i686-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I. -I.. -g -Wall -Wsign-compare
-Wno-long-long -Werror -ansi -march=i686 -I.. -march=i686 -MT environment.lo -MD
-MP -MF .deps/environment.Tpo -c environment.c  -fPIC -DPIC -o .libs/environment.o
 i686-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I. -I.. -g -Wall -Wsign-compare
-Wno-long-long -Werror -ansi -march=i686 -I.. -march=i686 -MT environment.lo -MD
-MP -MF .deps/environment.Tpo -c environment.c -o environment.o >/dev/null 2>&1
 i686-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I. -I.. -g -Wall -Wsign-compare
-Wno-long-long -Werror -ansi -march=i686 -I.. -march=i686 -MT contact.lo -MD -MP
-MF .deps/contact.Tpo -c contact.c -o contact.o >/dev/null 2>&1
make[2]: Leaving directory
`/var/tmp/portage/synce-rra-0.9.0/work/synce-rra-0.9.0/lib'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/var/tmp/portage/synce-rra-0.9.0/work/synce-rra-0.9.0'
make: *** [all] Error 2

!!! ERROR: app-pda/synce-rra-0.9.0 failed.
!!! Function src_compile, Line 510, Exitcode 2


Expected Results:  
installed properly

## EMERGE INFO::
Portage 2.0.51_rc9 (default-x86-2004.0, gcc-3.4.2, glibc-2.3.4.20041006-r0,
2.6.8-gentoo-r8 i686)
=================================================================
System uname: 2.6.8-gentoo-r8 i686 Intel(R) Pentium(R) 4 CPU 2.60GHz
Gentoo Base System version 1.5.3
distcc 2.18 i686-pc-linux-gnu (protocols 1 and 2) (default port 3632) [disabled]
ccache version 2.3 [enabled]
Autoconf: sys-devel/autoconf-2.59-r5
Automake: sys-devel/automake-1.8.5-r1
Binutils: sys-devel/binutils-2.15.92.0.2-r1
Headers:  sys-kernel/linux26-headers-2.6.8.1-r1
Libtools: sys-devel/libtool-1.5.2-r5
ACCEPT_KEYWORDS="x86 ~x86"
AUTOCLEAN="yes"
CFLAGS="-march=i686"
CHOST="i686-pc-linux-gnu"
COMPILER=""
CONFIG_PROTECT="/etc /usr/X11R6/lib/X11/xkb /usr/kde/2/share/config
/usr/kde/3.3/env /usr/kde/3.3/share/config /usr/kde/3.3/shutdown
/usr/kde/3/share/config /usr/lib/mozilla/defaults/pref /usr/share/config
/usr/share/texmf/dvipdfm/config/ /usr/share/texmf/dvips/config/
/usr/share/texmf/tex/generic/config/ /usr/share/texmf/tex/platex/config/
/usr/share/texmf/xdvi/ /var/qmail/control"
CONFIG_PROTECT_MASK="/etc/gconf /etc/terminfo /etc/env.d"
CXXFLAGS="-march=i686"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoaddcvs ccache distlocks sandbox"
GENTOO_MIRRORS="http://gentoo.seren.com/gentoo ftp://gentoo.noved.org/
http://gentoo.ccccom.com ftp://gentoo.ccccom.com"
MAKEOPTS="-j3"
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage /usr/local/overlays/bmg-main
/usr/local/overlays/bmg-gnome-current"
SYNC="rsync://rsync.us.gentoo.org/gentoo-portage"
USE="X alsa apache2 apm avi berkdb bitmap-fonts bonobo breakme cdr composite
crypt cups dba dvd encode esd f77 faad foomaticdb gd gdbm gif gnome gphoto2 gpm
gtk gtk2 gtkhtml guile hal imap imlib imlib2 imlib2_loaders ipv6 java jpeg
libg++ libwww livecd-ng mad mikmod mmx motif mozilla mpeg ncurses nls nvidia
offensive oggvorbis opengl oss pam pdflib perl png python quicktime readline
rrdtool samba sdl slang spell ssl svga tcltk tcpd tetex truetype x86 xine
xinerama xml xml2 xmms xorg xorg-x11 xosd xprint xv xvid zlib"

must be a gcc 3.4 issue, more stringent on bracing.  GCC being the standard,
it's _really_ a synce issue ;)

quick fix:
sinope)0) diff appointment.c.old appointment.c                                  
668c668
<       if (event_parser_data.uid)
---
>       if (event_parser_data.uid) {
687c687
<         }
---
>         }}

can you please attach a unified diff using diff -u ?
thanks

--- appointment.c.old   2004-10-17 12:33:44.710825128 -0700
+++ appointment.c       2004-10-17 12:32:31.950886320 -0700
@@ -665,7 +665,7 @@
             event_parser_data.exdates))
         synce_warning("Failed to parse recurrence rule");

-      if (event_parser_data.uid)
+      if (event_parser_data.uid) {
         if (0 == strncmp(event_parser_data.uid->values[0], BLOB0067_STR, strlen(BLOB0067_STR)))
         {
           /* A binary UID from SynCE */
@@ -684,7 +684,7 @@

           parser_add_blob(parser, ID_UNIQUE, buffer, size);
           free(buffer);
-        }
+        }}
         else
         {
           /* A text UID */

sorry for the delay. this is now in portage. thanks for your report.