Bugzilla Bug 66932

BioWare has released version 1.64 of their Dungeons and Dragons multiplayer RPG
Neverwinter Nights has been released. Changes include new skymaps, new
creatures (the bullete and the troglodyte), and fixes for exploits and game
rules (feats/spells).

Reproducible: Always
Steps to Reproduce:
1.
2.
3.

There are reports about fresh installs upgrading to 1.64 having older files
than installs that have been upgraded to 1.62 and then upgraded to 1.64.  As I
recall from previous updates, gentoo installs a fresh 1.29 install and then
upgrades to the latest version, so we would be affected by this.  Here is the
post from the Bioware NWN for linux forums.

From the forums at:
http://nwn.bioware.com/forums/viewtopic.html?topic=387062&forum=72


While working on updating my valid installation guide's md5sums, I noticed some
omissions between the 1.64 and the 1.62 updates, which got me somewhat
concerned. Users who update from 1.62 won't be affected, but new installations
that upgrade from fresh installations will be left with somewhat outdated
files. The exact impact is yet to be evaluated, but here is the list of files
for those concerned.

For vanilla NWN installations:


   1. ./fixinstall - this one might be for the best, as the one found in the
previous 1.29-to-1.62 update was actually less adequate for vanilla NWN as the
one found in the nwclient129.tar.gz (which had patch.key listed as a required
file, while the one in the update didn't)
   2. ./nwm/Chapter1E.nwm
   3. ./nwm/Chapter4.nwm



For SoU installations:


   1. ./fixinstall - this one might be for the best, as the one found in the
previous 1.30-to-1.62 update was actually less adequate for SoU as the one
found in the Data_Linux.zip file found on the SoU CD (which had xp1.key listed
as a required file, while the one in the update didn't)
   2. ./nwm/Chapter1E.nwm
   3. ./nwm/Chapter4.nwm
   4. ./nwm/XP1-Chapter 1.nwm
   5. ./nwm/XP1-Chapter 2.nwm
   6. ./nwm/XP1-Interlude.nwm



For the Chapter1E.nwm and Chapter4.nwm files, previously everyone at 1.62 would
have identical files (identical to the ones found in the nwclienthotu.tar.gz
file of the people with HotU). Now while this will still be true for those who
updated from 1.62 to 1.64, fresh installations will be stuck with old versions
(1.29 versions for vanilla installations, 1.30/original-SoU versions for SoU
installations). BTW, I verified the file contents, and the 1.62 versions did
seem to include bug fixes, which fresh 1.64 installations won't have.

Similar for the XP1-*.nwm files, previously people who had updated using the
1.30-to-162 SoU update after installation would have recieved another version
of these files in the update (which is why I always recommended that people
update SoU before installing HotU, as these new versions are not found in the
HotU updates). I didn't go through the trouble of doing a diff on these since
my previous diff on the OC modules convinced me that there was an unwanted
omission.

Anyway, until we get this cleared up, I won't be updating my md5sums as I have
no way of knowing what a proper installation should be like, since now it
appears that the history of your updates affect the final result, not just your
current version (must be hellish for BioWare to debug NWN in such a setup, when
asking users to update to latest doesn't mean they have the same version you
do).
_________________
- Eyrdan -
NWN Linux Forum Moderator
Member of the OpenKnights Consortium.

For fresh installs that have the "nowin" flag set, it attempts to download a
1.15gig file named nwresources129.tar.gz from ftp.jeuxlinux.com, which rarely
works well.  The same file is on tucows here:

http://www.tucows.iinet.net/pub/games/neverwinter/linux/nwresources129.tar.gz

Can this be changed in the ebuild?  Sorry if this sounds like a stupid request,
this is my first attempt at actually helping!

Seems as to Eyrdan has fixed the issue Jacob Gemmell posted. In the followin
thread, he concludes: "Ok updated the md5sums in my valid installation guide
with instructions to fetch the missing files from the 1.62 update.":
http://nwn.bioware.com/forums/viewtopic.html?topic=387062&forum=72

Eyrdan here.  Thought I'd have a peek since someone on the NWN Linux forum said
he was working on the 1.64 ebuild.  For what is quoted from my posts above, the
proper 'procedure' would be to update to 1.62 prior to updating to 1.64, so the
ebuild should install both updates.  Hopefully BioWare will recognize the
'oops' and re-include the missing files in the next update.  There is still no
word on this from them, so me and David (zzqzzq_zzq, author of NWMovies,
NWUser, NWMouse, etc.), which are the two community NWN gurus, have pretty much
recommended to everyone to update to 1.62 prior to 1.64 until further notice.

BTW, I haven't done so for previous ebuilds, cause I simply didn't have the
time for it, but for this one, if you wish, I'll be glad to verify/test it when
one is proposed.

Created an attachment (id=43728) [details]
Neverwinter Nights 1.64 ebuild

Okay, so here it goes. Sorry for not putting it up before now, but I've had to 
check it myself. It installed okay, but I have no way of knowing if the md5sum
of the troubled files are correct, so it would be ace if you (Eyrdan - Francois
Guimond) could try the ebuild out, check if the md5sums are correct and (if they
are) close this bug report. 

(Just for the record: I did as you suggested; patch up to 1.62 and then patch to
1.64). 

- rafael

Checked the ebuild out... here are my comments:

1.) You fixed a bug in the previous (1.62) ebuild by running "rm -rf override/*", good job at that (not doing so can seriously cripple an installation).

2.) Good spelling corrections ("Neverwinter" instead of "Never Winter").

3.) The final result checks out OK, 'cept for the fixinstall script which I assumed you were gonna use the same one as 1.62 (/usr/portage/games-rpg/nwn/files/nwn-1.62-fixinstall), but I'll get back to that below.

As of now, the installation will 'work', and better than the 1.62 would at that.  Here are a few more comments that could help improve it even more:

4.) You should delete NWNv129.txt and NWNv162.txt.  The patch details for those are included in NWNv164.txt, so it's just wasted space.

5.) A lot of documentation files (including the ones in point 4), unneeded to 'run' the application get put into the /opt/nwn and /opt/nwn/docs dir.  These could be put into /usr/share/doc/nwn-1.64 and gzip'd like is usually done for Gentoo ebuilds. These files are (note that the two readme.txt's are different):
    /opt/nwn/EULA.txt
    /opt/nwn/NWNv164.txt
    /opt/nwn/docs/NWN_OnlineManual.pdf
    /opt/nwn/docs/readme.txt
    /opt/nwn/movies-OC.txt
    /opt/nwn/readme-SDL.txt
    /opt/nwn/readme.linuxclientupdate.txt
    /opt/nwn/readme.linuxserver.txt
    /opt/nwn/readme.txt

6.) In the end result, some data files are left with executable permissions (which they don't need of course).  They seem to be mostly files from the 1.64 update, my guess is the BioWare guys did a chmod -R a+rwx or something similar before tar'ing it up.  Doesn't *break* the installation, but looks bad. ;)  Here they are:
    /opt/nwn/NWNv164.txt
    /opt/nwn/data/patch.bif
    /opt/nwn/dialog.tlk
    /opt/nwn/nwm/Chapter1.nwm
    /opt/nwn/nwm/Chapter2.nwm
    /opt/nwn/nwm/Chapter2E.nwm
    /opt/nwn/nwm/Chapter3.nwm
    /opt/nwn/nwm/Prelude.nwm
    /opt/nwn/patch.key

7.) The altered fixinstall script which was modified to match Gentoo standards is missing some of the functionality from the official version.  For example, it doesn't fix the 'saves' directory for users copying the data files over from a Windows installation.  It also seems to have two bugs the official didn't.  I could post a 'fixed' version if needed.

8.) As every NWN user knows, NWN wasn't designed for multi-user operation.  While the game will work for anyone in the group games, files created by the user by running the game will be owned by him, and most probably not usable by others, especially the directories created upon the first use of NWN which won't even allow writing to by other users (they'll be owned by the first user running it with his group, not the usual root:games combo).  I don't know if anyone would have a suggestion to fix this, I guess the /opt/nwn/nwn script could be modified to wipe out 'temporary' files and dirs before running, and non-temporary directories could be pre-created by the ebuild to be owned by root:games, but this could end up being troubling to implement correctly.  A number of 'other' options exist, like using a nwn-user script to keep per-user data stored in their home directories, or maybe even use zzqzzq_zzq's NWUser hak which is a preloadable librarie that hacks in nwmain to change the 'lookup' of userdata directories to look for them in the user's home directory instead of the usual "./saves ./localvault ...", but NWUser still has issues, mainly with the BioWare database system.


I guess that's it.  Overall the ebuild works and is better than the previous one, but it would still have some glitches to fix by my standards, which don't prevent it from working.

Oh yeah before I forget, there is an error in the pkg_postinst() for users
copying files over from a Windows installation (those without the nowin USE
flag).  The error is that files from the Windows install might not be 1.64, and
they would overwrite the 1.64 ones already installed by the ebuild.  The files
that should NOT get copied over are:

data/patch.bif
nwm/*
override/*
patch.key
dialog.tlk
dialogF.tlk

Rest is ok, but those come from the updates (yeah I know the BioWare official
instructions include copying those, but they do so prior to installing the
updates, and in Gentoo's case, the updates are installed first, so we need to
be extra cautious).

Created an attachment (id=43778) [details]
nwn-1.64.ebuild.diff

This is a fix on 4 and 5. The wrong permissions should be fixed by fixinstall
(it already does that). 

kai

Created an attachment (id=43781) [details]
nwn-1.64.ebuild.diff

Small typo :)

kai

Created an attachment (id=43795) [details]
Updated fixinstall script.

fixinstall script updated to 1.64, with Gentoo's changes kept, and added fixes
to permissions that I stated above to it as Kai suggested.

Uhm still something wrong with the ebuild. Made a fix for it but testing it
right now (will post update).  Slow computer here, so testing something that
emerges gigs of stuff kinda takes long.

Created an attachment (id=43797) [details]
patch to nwn-1.64.ebuild

Another patch to nwn-1.64.ebuild.  Includes changes by Kai with some additional
changes:

1. Some documentation files are only present if the "nowin" USE flag is
present, so added "use nowin" check for those.

2. Fixed the dodoc on the main directory readme.txt to use newdoc to rename the
document to readme.linuxclient.txt instead (two files were called readme.txt
and they differ).

3. Fixed the displayed instructions in pkg_postinst() to not include files that
would overwrite 1.64 patch data like my previous comment described.

Created an attachment (id=43804) [details]
Updated ebuild for NWN 1.64

Okay, so here goes. I've tried to improve the ebuild by fixing some of the
issues
you mentioned. I've installed and it seemed to check OK with issue 4, 5 and 6.

To be honest, I don't think I'd be able to fix issue 7 and 8 because I lack the

knowledge. You could, as you already said, make a fixed version of the
fixinstall
script, which would be to great help. 

Issue 8 on the other hand seems to be a hard one. I've got no ideas on howto
fix
that issue, but I support a permanent fix like putting all the save games and
so
on in the users home directory. It would be interesting if the Bioware staff 
could implent such a function into the game, but then again I guess they won't
since they would have already if they could.

At last issue "9" I can't seem to get going. It tells the user to copy the
files
from an already updated install in windows, which means that the files would be

the same version as the ebuild install. However, if you reckon I should edit
those lines anyway, I'll do what I can to fix the issue. :)

Uhm you seem to have disregarded the changes Kai and I made..  your new ebuild
has the same flaw as Kai's in regards to the lack of the nowin USE flags
causing some of those documentation files not to be present (and therefore
output error messages on the dodoc line) which I had fixed in my patch.

You fix the permissions in the ebuild that I fixed in the new fixinstall
script.  I guess this really is a debatable issue, although I see Kai's point
of doing it in fixinstall which outputs a step "Fixing permissions" already.  I
should be decided which one is prefered, with the files we have so far we have
two places doing the same thing.

Looking again at your comment my take is you didn't read any of the stuff that
was said starting at Kai's post of a patch.  You really should check it, we
were down to only "issue 8" left.

As for your comment on issue 9, perhaps it says to have a patched up version,
but only because you are overwriting files already present.  If you instructed
carefully which files to copy over, you wouldn't need a patched up version (in
fact, it could be a plain vanilla install of NWN).  The files to copy are never
altered by updates if done right (the ones in the 'fixed' version of the
message I put in my patch).  Another added incentive to doing it right is that
files installed by portage will remain as is, while overwriting them will in
the very least make them no longer maintained by the portage system (due to
different mtime).


Anyway, if we can settle on the details, the last thing left will be issue 8. 
I believe personally this is beyond the scope of this 'bug' which is to have an
ebuild for 1.64.  Any solution to this would require programming/scripting,
which might end up adding new bugs, or using a third-party solution already
circulating in the community, which isn't *part* of nwn-1.64 (so I guess
shouldn't be in the same ebuild anyway).

Eh, lemme correct a typo in my last comment: "I should be decided which one is
prefered, with the files we have so far we have two places doing the same
thing." should "It should be decided which one is prefered, with the files we
have so far we have two places doing the same thing." (was missing a 't') ... 
that typo somehow made it look like I was the one who had to decide, but it
should be agreed upon instead.

Ooops, for some reason I didn't notice your messages, which I'm really sorry
for.

You seemed to take take care of all the issues except for no. 8, which I agree
would be hard to implent on an easy level (without additional scripting or
similar).

However, how issue 6 is fixed doesn't really matter for me. If it's already in
the fix install as Kai reported (which I didn't see), then it could as well
remain there. I see no reason, whatsoever, for putting it in the ebuild instead
of the fixinstall (where it's now). 

As for issue 9, I'm quite sure I agree with you. We should choose whatever is
more efficient, which obviously are those changes you made.

Beside from that I don't really have anything more to add than a good job done!
The reason for why I began to work on this ebuild (and it was my first ever),
was because I missed it and wanted to play NWN 1.64, and not 1.62. From what I 
can tell this bug has been fixed. As I said and you stated earlier, the issue
that's left is beyond this bug report (from my point of view).

- Rafael Moe

(From update of attachment 43804 [details])
The old ebuild + .diff (latest patch) is the correct setup.

Just a quick "works for me" on x86.
Thank you for the good work.

I just posted Bug # 74871  for version 1.65.

*** This bug has been marked as a duplicate of 74871 ***

Closing to clean up after bugzilla upgrade.  reopen if closed in error. 
Thanks.