Bugzilla Bug 60524

Barbarian is a remake of the classic game on various 8 and 16 bit systems
(C64/Amiga/ST/etc). You can play the original game on an emulator.

Reproducible: Always
Steps to Reproduce:
1.
2.
3.

There doesn't appear to be source available for this game, and the website says
the supplied binary requires SDL to be installed in /usr/local/lib, which isn't
where Gentoo puts SDL.  This could make writing an ebuild tricky, otherwise I
would pick it up.  Umm, this was just a friendly "by the way" type message.

Created an attachment (id=41081) [details]
barbarian-1.01.ebuild

Created an attachment (id=41082) [details]
barbarian-1.01.ebuild

Forgot to install docs

Another issue: I'm not sure what license this package has...

Created an attachment (id=43082) [details]
barbarian-1.01.ebuild

Better way of dealing with the high-score file, making sure it ends in
GAMES_STATEDIR. Also, not inheriting eutils since the games eclass now inherits
it.

> and the website says the supplied binary requires SDL to be installed in
> /usr/local/lib, which isn't where Gentoo puts SDL

The game works just fine with SDL being where it is (/usr/lib).

Comments:

If an ebuild uses functionality from an eclass it needs to inherit the eclass itself and not depend on another eclass to do it.

fix the DESCRIPTION to be more descriptive and don't start with the name of the package.

fix the LICENSE

remove -* from KEYWORDS

put libsdl in DEPEND and remove RDEPEND

move GAME_DEST to src_install and make it local

add error checking to the file io in src_install (cp, doexe...)

Created an attachment (id=43093) [details]
barbarian-1.01.ebuild

> If an ebuild uses functionality from an eclass it needs to inherit the eclass
itself and not depend on another eclass to do it.

Noted.... that's not the case here though. No eutils functionality is needed.

> fix the DESCRIPTION to be more descriptive and don't start with the name of
the package.

Done

> fix the LICENSE

I can't _fix_ it since I don't know what the license is.

> remove -* from KEYWORDS

I haven't done this. Are you sure about this? You do realise this is a binary
(not source) package, right? All of the binary packages from portage (at least
all the packages I have seen) use -* in KEYWORDS. Has this changed recently?

> put libsdl in DEPEND and remove RDEPEND

Done.

> move GAME_DEST to src_install and make it local

Done. It was left over from the previous ebuild attempt where it was needed.

> add error checking to the file io in src_install (cp, doexe...)

Done. I always forget this ;)

We can't put it into portage without a valid LICENSE so this needs to be nailed
down first.

re: KEYWORDS - ah, I didn't realize it was binary.  the -* is fine in that case
but the package should be called barbarian-bin so it's clear what's going on.

Oh, and I just noticed that it needs to depend (but not rdepend) on unzip.

> We can't put it into portage without a valid LICENSE so this needs to be nailed down first.
I'll try writing an email to the developers.

> but the package should be called barbarian-bin so it's clear what's going on.
Is this a rule? I've seen a few packages that don't follow it. Are you only
trying to enforce it for the games-* ebuilds?

> Oh, and I just noticed that it needs to depend (but not rdepend) on unzip.
Because the program is distributed in a zip file? If that's the case then there
are _a lot_ of ebuilds that need fixing. There are very few ebuilds that depend
on unzip for this purpose.

-bin is used in quite a few places in the tree.

There are a number of ebuilds that need to have unzip added to the deps, yes.  Feel free to file bugs for them when you run across them.

Created an attachment (id=43305) [details]
barbarian-bin-1.01.ebuild

I've talked to the developer and he has chosen the Creative Commons
Attribution-NonCommercial-NoDerivs 2.0 and has included a LICENSE file in the
zip archive to show this. He has also added a versioning scheme to the zip
archive... and I have rewriten the ebuild.

You'll have to also add the license since it is not in portage:
http://creativecommons.org/licenses/by-nc-nd/2.0/

The legal text is here:
http://creativecommons.org/licenses/by-nc-nd/2.0/legalcode

Any update on this?

I take it the ebuild is OK since nobody has said anything in over a month. Also, the developer has been quite helpful (adding versioning to the archive, adding a lincense file to the archive, etc) and it just seems kind of unfair not adding it to portage already.

What's the problem?... Is there anything I can do?

games-arcade/barbarian-bin added to portage.  Thanks for the bug report and
ebuild.