Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 58587 - New ebuild: libdsp
Summary: New ebuild: libdsp
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Chris White (RETIRED)
URL: http://libdsp.sourceforge.net/overvie...
Whiteboard: configure check/ebuild check/patching
Keywords:
Depends on:
Blocks:
 
Reported: 2004-07-27 14:46 UTC by Ed Wildgoose
Modified: 2004-08-19 16:02 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
libdsp ebuild (libdsp-4.6.0.ebuild,852 bytes, text/plain)
2004-07-27 14:47 UTC, Ed Wildgoose
Details
libdsp-4.6.0 ebuild (libdsp-4.6.0.ebuild,985 bytes, text/plain)
2004-07-28 10:38 UTC, Ed Wildgoose
Details
libdsp 4.9.2 ebuild (libdsp-4.9.2.ebuild,1.28 KB, text/plain)
2004-07-28 10:39 UTC, Ed Wildgoose
Details
libdsp-4.9.2 updated (libdsp-4.9.2.ebuild,1.69 KB, text/plain)
2004-08-16 09:55 UTC, Ed Wildgoose
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ed Wildgoose 2004-07-27 14:46:45 UTC
libDSP is C++ class library of common digital signal processing functions. There is also a wrapper for the C language

I have just started experimenting with this - at first sight it looks like the library of choice for DSP with a decent convolver, fft, and a full set of functions for windowing and the like.

The make file is a bit hairy though - it only has an "install" option and kind of does a bit of compiling, then installs a bit, then compiles a bit and so on.  I have tweaked it by passing in some options to make to force it to pickup the relevant include files from the source location rather than the installed location.  Can someone please check that this is done in an acceptable way though (ie calling make directly)

This is probably not ready for release yet.  I probably still need to add an option to install the documentation, and produce an ebuild for the newer dev version of the library which has changed a few names of directories (nothing major though)

Grateful if someone could review this in principle though.  I can probably offer to maintain this seeing as it doesn't change too frequently by the looks of it.

Reproducible: Always
Steps to Reproduce:
Comment 1 Ed Wildgoose 2004-07-27 14:47:12 UTC
Created attachment 36285 [details]
libdsp ebuild
Comment 2 Ed Wildgoose 2004-07-28 10:38:38 UTC
Created attachment 36339 [details]
libdsp-4.6.0 ebuild
Comment 3 Ed Wildgoose 2004-07-28 10:39:03 UTC
Created attachment 36340 [details]
libdsp 4.9.2 ebuild
Comment 4 Ed Wildgoose 2004-07-28 10:40:59 UTC
I have updated the ebuild and added a DOC use flag.  Also tweaked the ebuild for use with the new development build

Can these please be added with the 4.6 version as stable (if appropriate) and the 4.9.2 as unstable (since it's a development version)

Thanks
Comment 5 Chris White (RETIRED) gentoo-dev 2004-07-28 21:30:28 UTC
4.9.2 will most likely be added as unstable, then stabilized later on.
I don't like going stable right away with ebuilds.

This lib has a crazy ole makefile though, I'm gonna have to patch them so
we aren't doing `make install` as default (what the heck is up with that?).

I'll take this as maintainer.
Comment 6 Chris White (RETIRED) gentoo-dev 2004-07-28 21:31:05 UTC
4.9.2 will most likely be added as unstable, then stabilized later on.
I don't like going stable right away with ebuilds.

This lib has a crazy ole makefile though, I'm gonna have to patch them so
we aren't doing `make install` as default (what the heck is up with that?).

I'll take this as maintainer.
Comment 7 Chris White (RETIRED) gentoo-dev 2004-07-28 23:20:41 UTC
Ok, the ebuild is in cvs, so here I go with my notes :).

1) This was hard
2) This was really hard
3) You're expecting something new now, but.. This was REALLY hard
4) flag-o-matic was not used, so the inherit was removed
5) It compiles on x86, and has not been tested with other archs, so it remains
~x86 until an arch can stop by, test it, and claim it good.
6) DEPEND is the required keyword, RDEPEND is optional.  Deleted RDEPEND and
added a blank DEPEND line instead.
7) No configure file, no myconf :)
8) Not quite sure where myarch fits in, but removed it
9) Don't need mkdir's for destinations.  Portage creates them for you.

Ok, now on to the stuff I did for makefile fun:

1) Patched the makefile to use the correct include directories
2) Did the make/make install from the source directories instead of toplevel,
since the toplevel makefile has no idea what it's doing.
3) Did some sed magic to fix the PREFIX directory and add in user C/CXXFLAGS

Great for first time though, expecially with this strange package :).
Thanks for posting!
Comment 8 Ed Wildgoose 2004-08-16 09:10:51 UTC
Hi Chris,

Thanks for taking the time to explain what was right/wrong - this is very helpful

I have a couple of queries (sorry for taking so long to reply).  Mainly I wonder why you skipped the "Inlines" out of the install section?  I haven't actually compiled anything yet with this toolkit, so I can't guarantee that it's needed, but the files installed do actually look fairly important...

Secondly I noticed a few examples in the libdsp/work directory so I ammended the ebuild to include these.  Is this the best way to do things (note I only included them if the user requested the USE="doc" option)?

Lastly, did you not feel it worth including the 4.6 version...?  Probably not since I'm likely to be one of the few users and I would prefer the dev version.  But technically 4.6 is the stable one...

Thanks again for taking the time to "tutor" me.  I have included a modified version of your ebuild which includes the bits mentioned above
Comment 9 Ed Wildgoose 2004-08-16 09:55:17 UTC
Created attachment 37542 [details]
libdsp-4.9.2 updated

Updated to install the "Inlines" directory.  Also installs some "examples"

Please check the "Inlines" install stuff.  The makefile doesn't create the
directories without help so I added a mkdir in the ebuild.  Should I do this by
patching the makefile instead?
Comment 10 Chris White (RETIRED) gentoo-dev 2004-08-19 16:02:29 UTC
Added to portage tree as media-libs/libdsp-4.9.2-r2 with inlines
fix and doc tag.

looked good!

(and as you may already have known, libdsp was moved from media-sound to
media-libs).