Bugzilla Bug 47846

Please add "~amd64" to the KEYWORDS for hylafax-4.1.8-r2

Portage 2.0.50-r5 (default-amd64-2004.0, gcc-3.3.3, glibc-2.3.3_pre20040207-r0, 2.6.3-gentoo-r2)
=================================================================
System uname: 2.6.3-gentoo-r2 x86_64 4
Gentoo Base System version 1.4.3.13p1
Autoconf: sys-devel/autoconf-2.59-r3
Automake: sys-devel/automake-1.8.3
ACCEPT_KEYWORDS="amd64 ~amd64"
AUTOCLEAN="yes"
CFLAGS="-O2 -fPIC"
CHOST="x86_64-pc-linux-gnu"
COMPILER="gcc3"
CONFIG_PROTECT="/etc /usr/X11R6/lib/X11/xkb /usr/kde/2/share/config /usr/kde/3.2/share/config /usr/kde/3/share/config /usr/lib/mozilla/defaults/pref /usr/share/config /var/qmail/control"
CONFIG_PROTECT_MASK="/etc/gconf /etc/terminfo /etc/env.d"
CXXFLAGS="-O2 -fPIC"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoaddcvs ccache sandbox"
GENTOO_MIRRORS="http://gentoo.oregonstate.edu http://distro.ibiblio.org/pub/Linux/distributions/gentoo"
MAKEOPTS="-j2"
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="X amd64 apache2 apm arts artswrappersuid avi berkdb bluetooth cdr crypt cups curl dvd dvdr encode esd evo fam flash foomaticdb foreign-package gd-external gdbm gif gimpprint glade gnome gphoto2 gpm gtk gtk2 gtkhtml imap imlib irda isdn jpeg kde lcms ldap libg++ libwww linguas_de mikmod motif mozilla mpeg mpeg4 mysql ncurses nls nogcj oggvorbis opengl opie oss pam pda pdflib perl php png postgres python qt quicktime readline samba scanner sdl slang snmp spell ssl tcltk tcpd transcode truetype usb v4l xine xinerama xml2 xmms xv xvid zlib"

/usr/bin/g++ -shared -fpic -Wl,-soname,libfaxutil.so -o libfaxutil.so.4.1.8
Array.o BoolArray.o Dictionary.o Obj.o PageSize.o RegEx.o RegExArray.o
RegExDict.o StackBuffer.o Str.o StrArray.o StrDict.o Dispatcher.o IOHandler.o
Sys.o Syslog.o Timeout.o Fatal.o AtSyntax.o DialRules.o FmtTime.o TimeOfDay.o
FaxDB.o TextFmt.o Class2Params.o FaxClient.o FaxConfig.o FaxRecvInfo.o
FaxSendInfo.o JobExt.o ModemExt.o SendFaxJob.o SendFaxClient.o TypeRules.o
Transport.o InetTransport.o UnixTransport.o SNPPClient.o SNPPJob.o
cvtfacility.o fxassert.o \
     -L/usr/local/lib -ltiff  -lz  -L../regex -lregex \
    -lcrypt -lutil -lm
/usr/lib/gcc-lib/x86_64-pc-linux-gnu/3.3.3/../../../../x86_64-pc-linux-gnu/bin/ld:
Array.o: relocation R_X86_64_32S can not be used when making a shared object;
recompile with -fPIC
Array.o: could not read symbols: Bad value
collect2: ld returned 1 exit status
make[3]: *** [libfaxutil.so] Error 1

this package would need additional fixing before getting unmasked

It works fine for me after emerge sync today

Done.  Added ~amd64 keyword.

Augustus, that doesn't work for me either...
AFAIK it only works for Holger, as he has CFLAGS="-O2 -fPIC" (look at his emerge
info output). This pacakge is definitely borked and needs some fPIC patch.

marked hylafax-4.1.8-r2 "-amd64" until fixed.

Created an attachment (id=29647) [details]
Patch to make hylafax-4.1.8-r2 work on amd64

Works for with this test. However, I would like it to be tested on alpha as
well.

s/test./patch./

Created an attachment (id=29650) [details]
output of hylafax build on alpha

This doesn't build on alpha either.  Build output attached.

I'm not certain that the suggested patch is the best approach.	I'll do a
little more investigation.

jhuebel: Aron suggested solving this bug without a patch to the makefiles, but
instead running "make VCOPTS=-fPIC VC++OPTS=-fPIC" in those subdirs that provide
shared objects. Unfortunately, there are a handfull of small executables created in those subdirs that would certainly be compiled with -fPIC as well. But that
would be much more easily maintanable than a ugly hack to the Makefiles.

Are you okay with this solution ?

There has been a lot of discussion about PIC for packages with mixed libraries
and executables.  The decision was made that fPIC should be selectively applied
to these types of packages using a makefile patch.  Executables should not be
compiled with fPIC.  It may be an "ugly hack", but it is currently the
preferred method.

-fPIC applied to executables causes a fairly serious performance hit...
additionally, this means the package is broken upstream, therefore the makefile
should be fixed and the patch sent upstream.

In CVS now. I marked all previous version -amd64 and -alpha, marked -r2 ~amd64
and ~alpha. Fixed.