Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 37485 - revdep-rebuild does not handle "interactive" emerge
Summary: revdep-rebuild does not handle "interactive" emerge
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Portage Tools Team
URL:
Whiteboard:
Keywords: InVCS
: 83077 109714 143792 (view as bug list)
Depends on:
Blocks:
 
Reported: 2004-01-07 08:42 UTC by Olivier Orabona
Modified: 2023-07-16 06:44 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
fix to re-route stdin to the emerge (revdep-rebuild.diff,680 bytes, patch)
2005-10-18 08:11 UTC, Sal Gonzalez
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Orabona 2004-01-07 08:42:04 UTC
When revdep-rebuild tries to emerge unreal tournament, the user is asked to
accept the licence agreement. But revdep-rebuild fails because of that :

 * Do you accept the terms of this license (as-is)? [yes/no]


 * You MUST accept the license to continue!  Exiting!

!!! ERROR: games-fps/unreal-tournament-451 failed.
!!! Function check_license, Line 1132, Exitcode 0
!!! Failed to accept license


Reproducible: Always
Steps to Reproduce:
1.
2.
3.
Actual Results:  
All prepared. Starting rebuild... 
emerge --oneshot --nodeps  =games-fps/unreal-tournament-451 
.......... 
Calculating dependencies ...done! 
>>> emerge (1 of 1) games-fps/unreal-tournament-451 to / 
>>> md5 src_uri ;-) ut-install-436.run 
>>> md5 src_uri ;-) UTPGPatch451.tar.bz2 
 * Do you accept the terms of this license (as-is)? [yes/no] 
 
 
 * You MUST accept the license to continue!  Exiting! 
 
!!! ERROR: games-fps/unreal-tournament-451 failed. 
!!! Function check_license, Line 1132, Exitcode 0 
!!! Failed to accept license 
 
 
Result is not OK, you have following choices: 
 

Expected Results:  
emerge ebuild ! 

The problem seems to be resolved if we comment those lines in revdep-rebuild : 
 
# Run in background to correctly handle Ctrl-C 
#( 
        emerge --oneshot --nodeps $@ $REBUILD_LIST 
        echo $? >$LLIST.6_status 
#) & 
#wait 
 
I don't see why it would actually break anything else.
Comment 1 Trey Gruel 2004-10-21 06:59:19 UTC
I'm not sure if this should be filed as a seperate bug or not, but I'm finding a similar problem if I use 'revdep-rebuild -av' and it finds something to rebuild.

Here's what I get:

Do you want me to merge these packages? [Yes/No] Interrupted.

Result is not OK, you have following choices:
- if emerge failed during build, fix the problems and re-run revdep-rebuild
    or
- use -X or --package-names as first argument (try to rebuild package, not exact
  ebuild - ignores SLOT!)
    or
- set ACCEPT_KEYWORDS="~<your platform>" and/or /etc/portage/package.unmask
  (and remove /root/.revdep-rebuild.5_order to be evaluated again)
    or
- modify the above emerge command and run it manually
    or
- compile or unmerge unsatisfied packages manually, remove temporary files and
  try again (you can edit package/ebuild list first)

Comment 2 Paul Varner (RETIRED) gentoo-dev 2005-05-31 21:36:17 UTC
*** Bug 83077 has been marked as a duplicate of this bug. ***
Comment 3 Alec Warner (RETIRED) archtester gentoo-dev Security 2005-08-10 08:57:17 UTC
(In reply to comment #1)
> I'm not sure if this should be filed as a seperate bug or not, but I'm finding 
a similar problem if I use 'revdep-rebuild -av' and it finds something to 
rebuild.
> 
> Here's what I get:
> 
> Do you want me to merge these packages? [Yes/No] Interrupted.
> 
> Result is not OK, you have following choices:
> - if emerge failed during build, fix the problems and re-run revdep-rebuild
>     or
> - use -X or --package-names as first argument (try to rebuild package, not 
exact
>   ebuild - ignores SLOT!)
>     or
> - set ACCEPT_KEYWORDS="~<your platform>" and/or /etc/portage/package.unmask
>   (and remove /root/.revdep-rebuild.5_order to be evaluated again)
>     or
> - modify the above emerge command and run it manually
>     or
> - compile or unmerge unsatisfied packages manually, remove temporary files and
>   try again (you can edit package/ebuild list first)
> 
> 
Don't use ask when you aren't running emerge interactively.

As for the license stuff, ACCEPT_LICENSE isn't implemented yet.  I would hope 
that it's a 2.1 feature with config, but I can't promise anything because I 
haven't seen any discussion.

Unless someone wants to hack up some stuff in revdep-rebuild to try and get 
around the ACCEPT_LICENSE stuff, I'll probably mark this as a dup of the 
interactive emerge bug assigned to dev-portage.  Both of you need an emerge that 
doesn't ask questions.  -> bug 58195
Comment 4 Alec Warner (RETIRED) archtester gentoo-dev Security 2005-10-18 08:05:47 UTC
*** Bug 109714 has been marked as a duplicate of this bug. ***
Comment 5 Sal Gonzalez 2005-10-18 08:11:03 UTC
Created attachment 70945 [details, diff]
fix to re-route stdin to the emerge
Comment 6 Sal Gonzalez 2005-10-18 08:24:36 UTC
Alec, I think you are misunderstanding the problem, when there is an interactive
emerge, the read or similiar in emerge fails automatically; so any step that
would require keyboard input fails.  the patch I attached should fix this.
Comment 7 Alec Warner (RETIRED) archtester gentoo-dev Security 2005-10-18 09:34:27 UTC
(In reply to comment #6)
> Alec, I think you are misunderstanding the problem, when there is an interactive
> emerge, the read or similiar in emerge fails automatically; so any step that
> would require keyboard input fails.  the patch I attached should fix this.

Your bug and this bug are different how then?  Both note that revdep fails when
input is needed in any case, so only 1 bug is needed.  The fix however, is
greatly appreciated.
Comment 8 Sal Gonzalez 2005-10-18 09:39:03 UTC
oh, no you were right to dupe it, it just seemed that from the comment on duping
this bug as bug 58195 that maybe you weren't excatly clear on what the problem
in this case was (not that it doesnt ask up front, but that it doesnt allow you
to answer the questions.)
Comment 9 Paul Varner (RETIRED) gentoo-dev 2006-07-28 13:02:31 UTC
Patch is in Subversion revision 306

Thanks, Sal.
Comment 10 Jakub Moc (RETIRED) gentoo-dev 2006-08-13 11:12:24 UTC
*** Bug 143792 has been marked as a duplicate of this bug. ***
Comment 11 DEMAINE Benoît-Pierre, aka DoubleHP 2006-12-12 12:35:55 UTC
as mentionned in bug 119308 and bug 17367 , I am wondering if portage had not been designed to be exclusively non-interactive ? In most bugs I have open or joined, interactive merges was a non desired side effect of some problem.
Comment 12 Paul Varner (RETIRED) gentoo-dev 2006-12-12 12:55:43 UTC
This was released with gentoolkit-0.2.3_pre1
Comment 13 DEMAINE Benoît-Pierre, aka DoubleHP 2007-02-24 15:33:27 UTC
einfo:
 * Please insert+mount the cdrom for unreal-tournament now !
 * Press return to scan for the cd again
 * or hit CTRL+C to abort the emerge.

is not what I can consider a fix ! there should AT LEAST be a timeout ! Possible case: you do
emerge -v UT ; halt
and go to bed

or emerge -DaNuv world ; halt
and go in holidays

when you come back, in fact, nothing happened, the box is still waiting for physical human interaction. Waiting for ^C is what I can call a workaround, not a fix.
Comment 14 Paul Varner (RETIRED) gentoo-dev 2007-02-24 16:29:33 UTC
(In reply to comment #13)
> einfo:
>  * Please insert+mount the cdrom for unreal-tournament now !
>  * Press return to scan for the cd again
>  * or hit CTRL+C to abort the emerge.
> 

What you are complaining about has nothing to do with revdep-rebuild.
Comment 15 Paul Varner (RETIRED) gentoo-dev 2007-03-09 04:16:22 UTC
Fixed in gentoolkit-0.2.3