Bugzilla Bug 34495

Ebuild for configure-thinkpad, a gnome app to use tpctl.

Reproducible: Always
Steps to Reproduce:
1.
2.
3.

Created an attachment (id=21346) [details]
Ebuild for configure-thinkpad-0.1

Created an attachment (id=21347) [details]
Digest

The gnome team is not interested in maintaining this, please reassign. (we
don't have a thinkpad to test either)

A few comments on the ebuild :

* should use gnome2 eclass
* KEYWORDS should only contain _tested_ platforms by the submitter and always
be ~arch in their initial state
* deps probably need fixing, shouldnt there be a (R)DEP on tpctl (?)
* the glibc comment is uninformative, so i have no idea why it is there.
Comments are meant to clarify something aren't they ?

once the gnome team is happy with the state of the ebuild, i'm willing to
maintain it, as I have a thinkpad 600x.

<back from zombie mode>

attached is a revised ebuild that takes advantage of the gnome2 eclass. 

Seems to work fine on a thinkpad T41p ...

</returning to zombie mode>

Created an attachment (id=26186) [details]
configure-thinkpad-0.1-r1.ebuild

and now the attachment (sorry for the previous entry) 

hmm, shouldn't it have a dependency on tpctl if its used to configure it? 

Created an attachment (id=26216) [details]
configure-thinkpad-0.1-r2.ebuild

well spider, i'm rusty; it is obvious that you are rigth :-) 

revised ebuild attached (i'm not 100% sure if i got all the gnome deps) 

if those are indeed the deps (glib 2.3, gtk+ 2.3)  Then this package will not
go into the tree anytime soon.  2.3 versions are development release (gnome 2.5
related) that haven't stabilized yet.

okay, checking configure.in of the tarball reveals this:

pkg_modules="libgnomeui-2.0"
<snip>
GETTEXT_PACKAGE=configure-thinkpad
AC_SUBST(GETTEXT_PACKAGE)
AC_DEFINE_UNQUOTED(GETTEXT_PACKAGE,"$GETTEXT_PACKAGE")


Which would make the deps gettext and libgnomeui, as well as pkgconfig.  I'm not sure about scrollkeeper here.


it should have a DOCS line though :
DOCS="AUTHORS ChangeLog COPYING  INSTALL README" (though readme is empty)

Created an attachment (id=26267) [details]
configure-thinkpad-0.1-r3.ebuild

and here it goes another one ...

(From update of attachment 26267 [details])



# Copyright 1999-2003 Gentoo Technologies, Inc.
# Distributed under the terms of the GNU General Public License v2

inherit gnome2

DESCRIPTION="Thinkpad gnome configuration utility for tpctl"
SRC_URI="mirror://sourceforge/tpctl/${P}.tar.gz"
HOMEPAGE="http://tpctl.sourceforge.net/configure-thinkpad.html"
KEYWORDS="~x86 -amd64 -ppc -mips -sparc"

RDEPEND=">=sys-apps/tpctl-4.8
	>=x11-libs/gtk+-2.2
	>=gnome-base/libgnomeui-2.4
	>=sys-devel/gettext-0.11"

DEPEND="${RDEPEND}
	dev-util/pkgconfig"

SLOT="0"
LICENSE="GPL-2"
DOCS="AUTHORS COPYING  INSTALL"

note that tpctl has keywords :

KEYWORDS="~x86 amd64 -ppc -mips -sparc"
 


 :-)

hey spider, 

this time you got it wrong :-) 

The fact that that tpctl (and sys-apps/thinkpad too) has KEYWORDS="~x86 amd64 -ppc -mips -sparc" is clearly a bug ;-) 

a quick look at IBM's Thinkpad pages shows that there are no thinkpads based on the AMD64 architecture...  

Best Regards :-) 

well, then I still got it right but that package is bugged ;-)  (go on, go fix
it)


otherwise this looks pretty good.

Datashark asked me to give a small hand here. This is now in cvs.
I will also take a look at tpctl ebuilds to add the necessary -arch (there are only x86 thinkpads.... :( )