Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 336871 - www-client/chromium-6.0.472.{55,59} wrong CFLAGS
Summary: www-client/chromium-6.0.472.{55,59} wrong CFLAGS
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Chromium Project
URL:
Whiteboard:
Keywords:
: 338276 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-09-11 22:16 UTC by Alex Barker
Modified: 2013-11-10 17:45 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Barker 2010-09-11 22:16:16 UTC
Chrome is using the wrong cflags.

Current settings:
CFLAGS="-O2 -march=pentium-m -pipe -fomit-frame-pointer"
CHOST="i686-pc-linux-gnu"
CXXFLAGS="${CFLAGS}"

Extras added (See Below):
-mmmx -march=pentium4 -msse2 -mfpmath=sse


Reproducible: Always

Actual Results:  
  i686-pc-linux-gnu-g++ -O2 -march=pentium-m -pipe -fomit-frame-pointer -pthread -fno-exceptions -Wall -Wno-unused-parameter -Wno-missing-field-initializers -D_FILE_OFFSET_BITS=64 -fvisibility=hidden -m32 -mmmx -march=pentium4 -msse2 -mfpmath=sse -fno-strict-aliasing -pthread -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng14 -DORBIT2=1 -pthread -I/usr/include/gconf/2 -I/usr/include/orbit-2.0 -I/usr/include/dbus-1.0 -I/usr/lib/dbus-1.0/include -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -pthread -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng14 -I../net/third_party/nss/ssl -Inet/third_party/nss/ssl -IWebKit/chromium/net/third_party/nss/ssl -I/usr/include/nss -I/usr/include/nspr -O2 -fno-ident -fdata-sections -ffunction-sections -fno-rtti -fno-threadsafe-statics -fvisibility-inlines-hidden '-DNO_TCMALLOC' '-DNO_HEAPCHECKER' '-DCHROMIUM_BUILD' '-DENABLE_REMOTING=1' '-DU_STATIC_IMPLEMENTATION' '-DUSE_SYSTEM_ZLIB' '-DUSE_SYSTEM_LIBEVENT' '-D__STDC_FORMAT_MACROS' '-DNDEBUG' '-DNVALGRIND' '-DDYNAMIC_ANNOTATIONS_ENABLED=0' -Ithird_party/icu/public/common -Ithird_party/icu/public/i18n -I. -Isdch/open-vcdiff/src -Iout/Release/obj/gen/net -Iv8/include -MMD -MF out/Release/.deps/out/Release/obj.target/net/net/spdy/spdy_session_pool.o.d.raw -c -o out/Release/obj.target/net/net/spdy/spdy_session_pool.o net/spdy/spdy_session_pool.cc
Comment 1 Paweł Hajdan, Jr. (RETIRED) gentoo-dev 2010-09-12 03:12:01 UTC
Could you attach emerge --info and full build log?
Comment 2 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2010-09-21 16:30:03 UTC
*** Bug 338276 has been marked as a duplicate of this bug. ***
Comment 3 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2010-09-21 16:31:12 UTC
(In reply to comment #1)
> Could you attach emerge --info and full build log?

You could use the information from the bug I marked as a dup but the issue is pretty clear. Chromium build system appends '-march=pentium4' after the real CFLAGS.
Comment 4 Jan Kohnert 2010-09-25 02:28:59 UTC
Who closed this one? This is still *not* fixed. Keep im mind that www-client/chromium-6.0.472.59 is marked stable on x86 and amd64, so it *should builld*. Please reopen, I am not allowed to do so...

Regards Jan
Comment 5 Paweł Hajdan, Jr. (RETIRED) gentoo-dev 2010-09-27 07:38:34 UTC
(In reply to comment #4)
> Who closed this one? This is still *not* fixed. Keep im mind that
> www-client/chromium-6.0.472.59 is marked stable on x86 and amd64, so it *should
> builld*. Please reopen, I am not allowed to do so...

This is fixed with 6.0.472.62, now stable on both amd64 and x86...
Comment 6 Steven Newbury 2013-11-10 10:26:28 UTC
The current ebuilds explicitly disable sse2, and refer to this bug, but it doesn't seem to be relevant any more, at least for v31/v32.  Removing the "-Ddisable_sse2=1" from the conf flags doesn't cause any spurious compiler flags to be set, and should result in a significantly faster browser.
Comment 7 Mike Gilbert gentoo-dev 2013-11-10 15:31:42 UTC
(In reply to Steven Newbury from comment #6)

-Ddisable_sse2=1 never actually disabled SSE2 -- it just prevented -msse2 and a few other flags from being forced on by the build system.

However, it looks like you are correct in that disable_sse2 doesn't seem to do anything in recent chromium versions. We could potentially drop it from the ebuild, but that would have no effect on the performance of the resulting binaries.
Comment 8 Paweł Hajdan, Jr. (RETIRED) gentoo-dev 2013-11-10 17:28:44 UTC
(In reply to Mike Gilbert from comment #7)
> (In reply to Steven Newbury from comment #6)
> 
> -Ddisable_sse2=1 never actually disabled SSE2 -- it just prevented -msse2
> and a few other flags from being forced on by the build system.
> 
> However, it looks like you are correct in that disable_sse2 doesn't seem to
> do anything in recent chromium versions. We could potentially drop it from
> the ebuild, but that would have no effect on the performance of the
> resulting binaries.

I still see the following snippet in build/common.gypi:

                  ['branding=="Chromium" and disable_sse2==0', {
                    'cflags': [
                      '-march=pentium4',
                      '-msse2',
                      '-mfpmath=sse',
                    ],
                  }],

And it's not so much about -msse2 or -mfpmath=sse but -march=pentium4.
Comment 9 Mike Gilbert gentoo-dev 2013-11-10 17:45:50 UTC
(In reply to Paweł Hajdan, Jr. from comment #8)
> I still see the following snippet in build/common.gypi:
> 

You're right; I missed that in my search on cs.chromium.org.