Bug 31084 – i2c ebuild does not build

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description J Sacksteder 2003-10-13 19:26:37 UTC]

Trying to get this ebuild into a usable state on Alpha. 

Appears to be a problem with make or bash. [ operator complaining about too many arguments. Perhaps an extra space somewhere? Full transcript of error available at URL cited.  Appears to compile, but not install.

[Comment 1 J Sacksteder 2003-10-13 19:28:29 UTC]

Created attachment 19206 [details]
Emerge transcript

[Comment 2 Tim Yamin (RETIRED) 2003-10-14 08:24:58 UTC]

Can you try i2c 2.7.0 // i2c 2.6.5 to see whether this is an upstream problem?

[Comment 3 Tim Yamin (RETIRED) 2003-10-14 08:25:29 UTC]

Created attachment 19221 [details]
emerge debug output [unGZipped]

[Comment 4 J Sacksteder 2003-10-14 08:46:54 UTC]

Created attachment 19222 [details]
i2c build success - errors still happening, though.

[Comment 5 J Sacksteder 2003-10-14 08:51:44 UTC]

2.8.0, 2.7.0, and 2.6.5 all produce similar errors. 2.6.5 manages to soldier
on and actually install, though. I have attached verbose log of successfull
build of 2.6.5. 

[Comment 6 Tim Yamin (RETIRED) 2003-10-14 09:33:19 UTC]

Try sticking this into i2c-velleman.c :-

 /* $Id: i2c-velleman.c,v ...

+#include <asm/params.h>
 #include <linux/kernel.h>
 #include <linux/ioport.h>
 #include <linux/module.h>

... and do a manual compile ...

[Comment 7 J Sacksteder 2003-10-14 11:01:59 UTC]

Works with one small correction - param, not params. Builds ok. 

+#include <asm/param.h>
 #include <linux/kernel.h>
 #include <linux/ioport.h>
 #include <linux/module.h>

I unpacked the ebuild and ran 'make' myself. I touched '.compiled'. Tell
me how to merge this in and I'll test it out.  

[Comment 8 Tim Yamin (RETIRED) 2003-10-14 11:32:38 UTC]

Created attachment 19228 [details, diff]
Patch to i2c-2.8.0.ebuild

[Comment 9 Tim Yamin (RETIRED) 2003-10-14 11:33:46 UTC]

Created attachment 19229 [details, diff]
files/i2c-2.8.0-alphaCompile.patch

[Comment 10 Tim Yamin (RETIRED) 2003-10-14 11:34:23 UTC]

OK: Patch to the i2c ebuild attached, and stick the "i2c-2.8.0-alphaCompile.patch"
into your sys-apps/i2c/files directory...

[Comment 11 J Sacksteder 2003-10-14 11:51:41 UTC]

Patch has accidental CR in it. There is no line three. Did you forget nano
-w ?

PATCH COMMAND:  patch  -p4 < /usr/portage/sys-apps/i2c/files/i2c-2.8.0-alphaCompile.patch

========================================
missing header for unified diff at line 3 of patch
can't find file to patch at input line 3

[Comment 12 Tim Yamin (RETIRED) 2003-10-14 11:55:22 UTC]

Looks fine here... ? Line three is @@ -20,6 +20,8 @@

[Comment 13 J Sacksteder 2003-10-14 12:09:24 UTC]

My mistake. Here is the output, though.

do we need to be in ../kernel when we patch?

[Comment 14 Tim Yamin (RETIRED) 2003-10-14 12:44:06 UTC]

Yes:- please change to "cd kernel; epatch ${FILESDIR}/i2c-2.8.0-alphaCompile.patch;
cd .."

[Comment 15 J Sacksteder 2003-10-14 13:18:21 UTC]

Ebuild now works for me. I have notified the maintainers of our fix.

This ebuild puts the compiled modules into drivers/i2c/ , Right on top of
the i2c modules build by the stock kernel.

Version 2.6.5 put them in misc/  - I am waiting on a reply from the i2c maintainers
regarding the canonical location.

We should add this patch to the 2.7.0 ebuild also.

Can you add the ~alpha flag to these, as well?

[Comment 16 Tim Yamin (RETIRED) 2003-10-14 14:03:32 UTC]

In CVS.

> We should add this patch to the 2.7.0 ebuild also.

Done.

> Can you add the ~alpha flag to these, as well?

Done.

[Comment 17 J Sacksteder 2003-10-14 16:20:34 UTC]

fix is mainlined in 2.8.1. No patch neccesary.