308867 – games-strategy/scorched3d fails to build with libpng14

Bug 308867 - games-strategy/scorched3d fails to build with libpng14

Summary: games-strategy/scorched3d fails to build with libpng14

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	[OLD] Games (show other bugs)
Hardware:	All Linux

Importance:	High normal (vote)
Assignee:	Gentoo Games

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:	libpng-1.4
	Show dependency tree

Reported:	2010-03-10 18:59 UTC by Ai Locke Shinseiko (Wizzleby)
Modified:	2010-03-10 20:19 UTC (History)
CC List:	0 users

See Also:
Package list:
Runtime testing required:	---

Attachments
scorched3d-42.1-libpng14.patch (scorched3d-42.1-libpng14.patch,1.49 KB, patch) 2010-03-10 19:10 UTC, Ai Locke Shinseiko (Wizzleby)	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Ai Locke Shinseiko (Wizzleby) 2010-03-10 18:59:57 UTC

../../common/image/ImagePng.cpp: In function ‘void user_png_error(png_struct*, const char*)’:
../../common/image/ImagePng.cpp:153: warning: ‘png_struct_def::jmpbuf’ is deprecated (declared at /usr/include/png.h:1090)
../../common/image/ImagePng.cpp:153: warning: ‘png_struct_def::jmpbuf’ is deprecated (declared at /usr/include/png.h:1090)
../../common/image/ImagePng.cpp: In member function ‘bool ImagePng::loadFromBuffer(NetBuffer&, bool)’:
../../common/image/ImagePng.cpp:192: error: ‘png_infopp_NULL’ was not declared in this scope
../../common/image/ImagePng.cpp:203: error: ‘png_infopp_NULL’ was not declared in this scope
../../common/image/ImagePng.cpp:261: error: ‘png_infopp_NULL’ was not declared in this scope
../../common/image/ImagePng.cpp:275: error: ‘png_infopp_NULL’ was not declared in this scope
make[3]: *** [ImagePng.o] Error 1

Comment 1 Ai Locke Shinseiko (Wizzleby) 2010-03-10 19:10:13 UTC

Created attachment 223043 [details, diff]
scorched3d-42.1-libpng14.patch

converts obsolete use of defined typecast NULL pointers with NULL.
This patch does NOT fix the use of deprecated png_struct_def::jmpbuf
works for libpng12 as well

Comment 2 Samuli Suominen (RETIRED) gentoo-dev

2010-03-10 20:19:11 UTC

+  10 Mar 2010; Samuli Suominen <ssuominen@gentoo.org>
+  scorched3d-42.1.ebuild, +files/scorched3d-42.1-libpng14.patch:
+  Fix building with libpng14 wrt #308867 by Locke Shinseiko.