Bug 302773 – app-arch/gzip-1.4 fails to build on some architectures because of new NO_ASM

• Status: RESOLVED FIXED
• Product: Gentoo/Alt

[Description Alan Hourihane 2010-01-29 17:06:46 UTC]

patch attached to fix the problem.

[Comment 1 Alan Hourihane 2010-01-29 17:07:04 UTC]

Created attachment 217848 [details, diff]
fix build problems when NO_ASM defined

[Comment 2 SpanKY 2010-01-30 00:06:39 UTC]

ncompress-4.2.4.3 is now in the tree

[Comment 3 SpanKY 2010-01-30 00:11:03 UTC]

sorry, wrong bug

[Comment 4 Fabian Groffen 2010-01-30 12:15:11 UTC]

While I tend to believe you that this is a correct fix, I just see the removal of ASMV define.  Does it trigger some code path that won't work?  Did upstream forget about this situation or something?

[Comment 5 Alan Hourihane 2010-01-30 18:22:53 UTC]

The three paths that are fixed are MSDOS, Amiga & Atari. I hardly think they are well tested.

But basically adding NO_ASM as has been added in the ebuild has caused the problem as I guess people assume that the assembly routines should be used.

You could argue that the "use pic" option to define NO_ASM should be fixed really and PIC friendly asm code used, rather than the hack of defining NO_ASM.

[Comment 6 Fabian Groffen 2010-02-13 18:14:31 UTC]

thanks, added

[Comment 7 SpanKY 2016-02-29 18:32:56 UTC]

do you have build logs ?  there's no information here so that the patch can be sent upstream which means i'm inclined to drop it.