Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 301504 - net-libs/xulrunner-1.9.2 fails to build with USE=-alsa
Summary: net-libs/xulrunner-1.9.2 fails to build with USE=-alsa
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal with 1 vote (vote)
Assignee: Mozilla Gentoo Team
URL:
Whiteboard:
Keywords: InVCS
: 301853 302492 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-01-19 10:55 UTC by Alexis Ballier
Modified: 2010-01-29 15:02 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch to enable sound with oss4 in firefox (oss4-firefox.patch,969 bytes, patch)
2010-01-26 17:12 UTC, Sebastian Parborg
Details | Diff
Xulrunner oss4 sound patch. (oss4-xulrunner.patch,1.31 KB, patch)
2010-01-26 17:21 UTC, Sebastian Parborg
Details | Diff
Make firefox not depend on alsa libs (oss4-firefox.patch,1.33 KB, patch)
2010-01-26 18:04 UTC, Sebastian Parborg
Details | Diff
updated (oss4-xulrunner-r1.patch,1.96 KB, patch)
2010-01-27 12:18 UTC, Sebastian Parborg
Details | Diff
xulrunner-1.9.2-noalsa-fixup.patch (xulrunner-1.9.2-noalsa-fixup.patch,1.01 KB, patch)
2010-01-29 04:33 UTC, Jory A. Pratt
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexis Ballier gentoo-dev 2010-01-19 10:55:44 UTC
[ebuild     U ] net-libs/xulrunner-1.9.2_rc2 [1.9.1.7] USE="custom-optimization dbus libnotify%* sqlite startup-notification -alsa* -debug -gnome -java -mozdevelop% -networkmanager% (-python%*)"


/var/tmp/portage/net-libs/xulrunner-1.9.2_rc2/work/mozilla-1.9.2/config/nsinstall -R -m 644 _xpidlgen/content_base.xpt ../../../dist/bin/components
gmake[5]: Leaving directory `/var/tmp/portage/net-libs/xulrunner-1.9.2_rc2/work/mozilla-1.9.2/content/base/public'
gmake[5]: Entering directory `/var/tmp/portage/net-libs/xulrunner-1.9.2_rc2/work/mozilla-1.9.2/content/base/src'
nsDocument.cpp
x86_64-pc-linux-gnu-g++ -o nsDocument.o -c -I../../../dist/system_wrappers -include ../../../config/gcc_hidden.h -DMOZILLA_INTERNAL_API -D_IMPL_NS_COM -DEXPORT_XPT_API -DEXPORT_XPTC_API -D_IMPL_NS_COM_OBSOLETE -D_IMPL_NS_GFX -D_IMPL_NS_WIDGET -DIMPL_XREAPI -DIMPL_NS_NET -DIMPL_THEBES  -DOSTYPE=\"Linux2.6.32\" -DOSARCH=Linux -D_IMPL_NS_LAYOUT  -I. -I. -I../../../dist/include -I../../../dist/include/nsprpub  -I/usr/include/nspr -I/usr/include/nss      -I./../../events/src -I./../../xml/content/src -I./../../xul/base/src -I./../../xul/content/src -I./../../html/content/src -I./../../base/src -I./../../xbl/src -I./../../../layout/generic -I./../../../layout/style -I./../../../dom/base -I./../../xml/document/src -I../../../xpcom/io     -fPIC   -fno-rtti -fno-handle-exceptions -Wall -Wpointer-arith -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -Wcast-align -Wno-invalid-offsetof -Wno-long-long -march=core2 -pipe -g -ggdb -fPIC -Wno-return-type -w -fno-strict-aliasing -fshort-wchar -pthread -pipe  -DNDEBUG -DTRIMMED -O2   -DMOZILLA_CLIENT -include ../../../mozilla-config.h -Wp,-MD,.deps/nsDocument.pp nsDocument.cpp
In file included from nsDocument.cpp:172:
../../../dist/include/nsHTMLMediaElement.h:40:28: error: nsMediaDecoder.h: No such file or directory
In file included from nsDocument.cpp:172:
../../../dist/include/nsHTMLMediaElement.h:288: error: ‘nsMediaDecoder’ was not declared in this scope
../../../dist/include/nsHTMLMediaElement.h:288: error: template argument 1 is invalid
../../../dist/include/nsHTMLMediaElement.h:294: error: ‘nsMediaDecoder’ has not been declared
../../../dist/include/nsHTMLMediaElement.h:306: error: ‘nsMediaDecoder’ has not been declared
../../../dist/include/nsHTMLMediaElement.h:391: error: ‘nsMediaDecoder’ was not declared in this scope
../../../dist/include/nsHTMLMediaElement.h:391: error: template argument 1 is invalid
gmake[5]: *** [nsDocument.o] Error 1
gmake[5]: Leaving directory `/var/tmp/portage/net-libs/xulrunner-1.9.2_rc2/work/mozilla-1.9.2/content/base/src'
gmake[4]: *** [src_libs] Error 2
gmake[4]: Leaving directory `/var/tmp/portage/net-libs/xulrunner-1.9.2_rc2/work/mozilla-1.9.2/content/base'



nsMediaDecoder.h is not "installed" if ogg & wave support are disabled.
Comment 1 Albert W. Hopkins 2010-01-23 12:59:36 UTC
This bug has, apparently, made it's way out of mozilla-overlay and into portage proper:

net-libs/xulrunner-1.9.2
Comment 2 Jory A. Pratt gentoo-dev 2010-01-26 11:05:18 UTC
*** Bug 301853 has been marked as a duplicate of this bug. ***
Comment 3 Sebastian Parborg 2010-01-26 15:21:17 UTC
As they pointed out in 301853 arch as a xulrunner-oss package. Seems like you can disable alsa and use oss instead if you look at their "PKGBUILD":
http://aur.archlinux.org/packages/xulrunner-oss/xulrunner-oss/PKGBUILD
Comment 4 Sebastian Parborg 2010-01-26 17:12:32 UTC
Created attachment 217481 [details, diff]
Patch to enable sound with oss4 in firefox

Firefox patch... Why do the vanilla disable wave and ogg two times? :P
Comment 5 Sebastian Parborg 2010-01-26 17:21:27 UTC
Created attachment 217482 [details, diff]
Xulrunner oss4 sound patch.

Uses the arch way to enable oss support. I don't know if you must do it like this...
With the firefox patch and this one HTLM5 sound/video work perfectly on the sites I've gone to.
Perhaps remove the alsa use flag and put oss in instead? You will run into compile problems if you try to compile with no sound (--disable-wave/ogg) for now.
Comment 6 Sebastian Parborg 2010-01-26 18:04:32 UTC
Created attachment 217485 [details, diff]
Make firefox not depend on alsa libs

Forgot to remove all alsa libs from the firefox build system...
As i said before: Why not add an OSS use-flag so we can put all this into a nice if statement? :)
Comment 7 Jory A. Pratt gentoo-dev 2010-01-26 18:05:11 UTC
Comment on attachment 217482 [details, diff]
Xulrunner oss4 sound patch.

I will not include oss4, if you want oss4 enabled you will have to request the change upstream. We are already working on a fix for the problem.
Comment 8 Jory A. Pratt gentoo-dev 2010-01-26 18:05:48 UTC
Comment on attachment 217485 [details, diff]
Make firefox not depend on alsa libs

we will not include oss4 refer to previous comment.
Comment 9 Jory A. Pratt gentoo-dev 2010-01-26 18:12:46 UTC
(In reply to comment #6)
> Created an attachment (id=217485) [details]
> Make firefox not depend on alsa libs
> 
> Forgot to remove all alsa libs from the firefox build system...
> As i said before: Why not add an OSS use-flag so we can put all this into a
> nice if statement? :)
> 

I can concider an ogg useflag, which would be more appropriate. If you want to draw up an initial patch I will be more then happy to review and commit.
Comment 10 Sebastian Parborg 2010-01-26 22:28:47 UTC
Why no OSS use-flag? There are other packages in portage that has "oss" as an use-flag...
Or am I missing something here?
Comment 11 Jory A. Pratt gentoo-dev 2010-01-27 01:34:28 UTC
(In reply to comment #10)
> Why no OSS use-flag? There are other packages in portage that has "oss" as an
> use-flag...
> Or am I missing something here?
> 

Please reread the post your have the working confused, I said I would concider an oss useflag but either way oss or alsa will have to be enabled and proper checks put in place to ensure proper one is enabled as user expects.
Comment 12 Sebastian Parborg 2010-01-27 12:18:20 UTC
Created attachment 217583 [details, diff]
updated

Is this better?
Comment 13 Franz Trischberger 2010-01-27 12:35:13 UTC
I think the problem is that mozilla-devs won't support oss4, until it has found its way into the kernel. Until then Alsa is the only supported way for getting Audio/Video for HTML5.
And Gentoo (Mozilla) Devs won't support a non official feature.

(Though i must say, that Gentoo included a patch for plasma-panel to enable Fake-Transparency, which was refused by the kde-devs - caused some emotional discussions...)
Comment 14 Jory A. Pratt gentoo-dev 2010-01-27 22:56:11 UTC
*** Bug 302492 has been marked as a duplicate of this bug. ***
Comment 15 Jory A. Pratt gentoo-dev 2010-01-29 04:33:13 UTC
Created attachment 217782 [details, diff]
xulrunner-1.9.2-noalsa-fixup.patch

This will need to be applied to both xulrunner/firefox I will make the bump tomorrow morning so I can include a sparc fix as well. Sorry for the delay in getting this resolved.
Comment 16 Jory A. Pratt gentoo-dev 2010-01-29 05:10:26 UTC
For those who are interested, I put the patch in both ebuilds in mozilla overlay until I get it commited to tree in the morning.
Comment 17 Jory A. Pratt gentoo-dev 2010-01-29 15:02:26 UTC
It shall propogate to the mirrors shortly :)