Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 289803 - xpdf-3.02-r3 fails to compile with poppler-0.12.1
Summary: xpdf-3.02-r3 fails to compile with poppler-0.12.1
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Printing (show other bugs)
Hardware: All Linux
: High major (vote)
Assignee: Printing Team
URL:
Whiteboard:
Keywords:
: 290206 (view as bug list)
Depends on:
Blocks:
 
Reported: 2009-10-19 20:06 UTC by Shark
Modified: 2009-10-27 14:15 UTC (History)
13 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
New patchset to get xpdf to patch and compile under version 0.12.1 of poppler and friends. (xpdf-3.02-patchset-02.tar.bz2,9.39 KB, application/octet-stream)
2009-10-20 00:23 UTC, Clemmitt M. Sigler
Details
xpdf-3.02-r3.ebuild for patchset-02 (xpdf-3.02-r3.ebuild,1.73 KB, text/plain)
2009-10-26 15:31 UTC, Helmut Jarausch
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Shark 2009-10-19 20:06:05 UTC
compiling xpdf with poppler 0.12.1 fails with the following error:

xpdf.cc: In function 'int main(int, char**)':
xpdf.cc:221: error: 'class GlobalParams' has no member named 'setForceNoFTAutoHinting'
xpdf.cc:223: error: 'class GlobalParams' has no member named 'setForceNoFTAutoHinting'
make: *** [xpdf.o] Error 1
 * ERROR: app-text/xpdf-3.02-r3 failed:
 *   (no error message)
 * 
 * Call stack:
 *     ebuild.sh, line  49:  Called src_compile
 *   environment, line 3139:  Called die
 * The specific snippet of code:
 *       emake || die
 * 
It seems that this commit http://cgit.freedesktop.org/poppler/poppler/commit/?id=485252844b5e0964ee724b74e2a7ba2b820b259e has removed getForceNoFTAutoHinting() so one the ebuild's patch (40_all_xpdf-poppler-autohinting-as-option.patch) doesn't work anymore.
I'm not sure if the solution is to remove the patch or to rewrite it to enable autohinting again.


Reproducible: Always
Comment 1 Clemmitt M. Sigler 2009-10-20 00:15:28 UTC
(In reply to comment #0)
> It seems that this commit
> http://cgit.freedesktop.org/poppler/poppler/commit/?id=485252844b5e0964ee724b74e2a7ba2b820b259e
> has removed getForceNoFTAutoHinting() so one the ebuild's patch
> (40_all_xpdf-poppler-autohinting-as-option.patch) doesn't work anymore.
> I'm not sure if the solution is to remove the patch or to rewrite it to enable
> autohinting again.

Confirmed.

I've got version 0.12.1 of poppler, poppler-utils and poppler-glib installed now and can't emerge either xpdf-3.02-r2 or xpdf-3.02-r3 from the current portage tree.  AFAICT, these ebuilds need to block on the newer version(s) of poppler and friends.

I did a simple fix by hacking at the ebuild and the patch tarball.  I got rid of 40_all_xpdf-poppler-autohinting-as-option.patch and hacked at 50_all_xpdf-poppler-getCMap-arguments.patch to get xpdf to patch and compile.  In the ebuild, all I did is change "mirror://gentoo/xpdf-3.02-patchset-01.tar.bz2" to "mirror://gentoo/xpdf-3.02-patchset-02.tar.bz2", where xpdf-3.02-patchset-02.tar.bz2 is my local, personal, hacked patch tarball version.  I'll upload this tarball next.

!!!NOTA BENE!!!:
=== I am not the xpdf ebuild maintainer and do not have time to do this!!!
=== I am not a Gentoo developer and do not pretend to be one!!!
=== I don't have time to offer ANY support for this unofficial hack of mine!!!

In other words, Your Mileage May Vary if you try my hacks to install xpdf with the newest poppler and friends versions.  !!!WARNING!!!: If you break it, all the broken pieces are yours, not mine!!!  I am not at fault!!!

HTH.

Clemmitt
Comment 2 Clemmitt M. Sigler 2009-10-20 00:23:41 UTC
Created attachment 207616 [details]
New patchset to get xpdf to patch and compile under version 0.12.1 of poppler and friends.

xpdf won't currently patch/build under poppler (and friends) version 0.12.1.  I've hacked away at xpdf-3.02-r3.ebuild and xpdf-3.02-patchset-01.tar.bz2 to at least get it to patch and build.  xpdf-3.02-patchset-02.tar.bz2 is my hacked up version.
Comment 3 Shark 2009-10-20 10:39:25 UTC
I can confirm that xpdf compiles here (~x86) with your patchset. Seems to work without any problems on a couple of random .pdf i've tried.
Comment 4 Yuriy Dmitriev 2009-10-21 09:17:58 UTC
(In reply to comment #0)
> compiling xpdf with poppler 0.12.1 fails with the following error:
> 
> xpdf.cc: In function 'int main(int, char**)':
> xpdf.cc:221: error: 'class GlobalParams' has no member named
> 'setForceNoFTAutoHinting'
> xpdf.cc:223: error: 'class GlobalParams' has no member named
> 'setForceNoFTAutoHinting'
> make: *** [xpdf.o] Error 1
>  * ERROR: app-text/xpdf-3.02-r3 failed:
>  *   (no error message)
>  * 
>  * Call stack:
>  *     ebuild.sh, line  49:  Called src_compile
>  *   environment, line 3139:  Called die
>  * The specific snippet of code:
>  *       emake || die
>  * 
> It seems that this commit
> http://cgit.freedesktop.org/poppler/poppler/commit/?id=485252844b5e0964ee724b74e2a7ba2b820b259e
> has removed getForceNoFTAutoHinting() so one the ebuild's patch
> (40_all_xpdf-poppler-autohinting-as-option.patch) doesn't work anymore.
> I'm not sure if the solution is to remove the patch or to rewrite it to enable
> autohinting again.
> 
> 
> Reproducible: Always
> 


Problem still exists.....
waiting for patches))
Tnx)
Comment 5 Small_Penguin 2009-10-22 10:36:22 UTC
xpdf-3.02-patchset-02.tar.bz2 works fine here (~amd64), thanks.
Comment 6 Helmut Jarausch 2009-10-22 15:21:51 UTC
(In reply to comment #5)
> xpdf-3.02-patchset-02.tar.bz2 works fine here (~amd64), thanks.
> 

Unfortunately not here (amd64, as well)
I still get
xpdf.cc:221: error: 'class GlobalParams' has no member named 'setForceNoFTAutoHinting'
xpdf.cc:223: error: 'class GlobalParams' has no member named 'setForceNoFTAutoHinting'
Comment 7 Helmut Jarausch 2009-10-22 15:31:52 UTC
(In reply to comment #6)
> (In reply to comment #5)
> > xpdf-3.02-patchset-02.tar.bz2 works fine here (~amd64), thanks.
> > 
> 
> Unfortunately not here (amd64, as well)

Sorry, it does work here, too.
I've just forgotten to remove the old patch set.
Comment 8 Pierrot Rey 2009-10-22 19:52:25 UTC
(In reply to comment #6)
> (In reply to comment #5)
> > xpdf-3.02-patchset-02.tar.bz2 works fine here (~amd64), thanks.
> > 
> 
> Unfortunately not here (amd64, as well)
> I still get
> xpdf.cc:221: error: 'class GlobalParams' has no member named
> 'setForceNoFTAutoHinting'
> xpdf.cc:223: error: 'class GlobalParams' has no member named
> 'setForceNoFTAutoHinting'
> 

same here
Comment 9 Juergen Rose 2009-10-26 14:53:03 UTC
(In reply to comment #2)

could you give some hints, how to apply the patchset. To create an overlay /usr/local/portage/app-text/xpdf and put the files from your patchset into the files subdirectory seems me is not enough.

Regards
Comment 10 Helmut Jarausch 2009-10-26 15:31:35 UTC
Created attachment 208319 [details]
xpdf-3.02-r3.ebuild for patchset-02

create /usr/local/portage/app-text/xpdf 
cd /usr/local/portage/app-text/xpdf 
cp /usr/portage/app-text/xpdf/files/xpdf-3.02-poppler-nodrm.patch files/
pushd files
unpack the patchset here (generates a 3.02 folder)
popd
place the ebuild in the attachment here and
ebuild xpdf-3.02-r3.ebuild  digest.

This worked for me.
Helmut.
Comment 11 Jaime Martin 2009-10-26 21:42:41 UTC
(In reply to comment #10)
> Created an attachment (id=208319) [details]
> xpdf-3.02-r3.ebuild for patchset-02
> 
> create /usr/local/portage/app-text/xpdf 
> cd /usr/local/portage/app-text/xpdf 
> cp /usr/portage/app-text/xpdf/files/xpdf-3.02-poppler-nodrm.patch files/
> pushd files
> unpack the patchset here (generates a 3.02 folder)
> popd
> place the ebuild in the attachment here and
> ebuild xpdf-3.02-r3.ebuild  digest.
> 
> This worked for me.

This work for me too. Thank you!

Please developers, include this patch as soon as possible.
Comment 12 Juergen Rose 2009-10-27 09:03:14 UTC
(In reply to comment #10)

I did 'cp -a /usr/portage/app-text/xpdf /usr/local/portage/app-text/' followed by:

root@lynx:/root(2)# cd /usr/local/portage/app-text/xpdf/
root@lynx:/usr/local/portage/app-text/xpdf(6)# echo ${DIRSTACK[*]}
/usr/local/portage/app-text/xpdf
root@lynx:/usr/local/portage/app-text/xpdf(7)# pushd files                            
/usr/local/portage/app-text/xpdf/files /usr/local/portage/app-text/xpdf
root@lynx:/usr/local/portage/app-text/xpdf(8)# echo ${DIRSTACK[*]}
/usr/local/portage/app-text/xpdf/files /usr/local/portage/app-text/xpdf
root@lynx:/usr/local/portage/app-text/xpdf(9)# tar -xvf ~rose/Downloads/xpdf-3.02-patchset-02.tar.bz2 
tar: Record size = 8 blocks
3.02/
3.02/10_all_xpdf-poppler-cut-and-paste-default-output-encoding.patch
3.02/xpdf-3.02-poppler-nodrm.patch
3.02/50_all_xpdf-poppler-getCMap-arguments.patch
3.02/xpdfrc
3.02/20_all_xpdf-poppler-add-and-subtract-key-binding.patch
3.02/25_all_xpdf-poppler-poppler-0.10.0.patch
3.02/xpdf.desktop
3.02/45_all_xpdf-poppler-private-textpage-destructor.patch
3.02/05_all_xpdf-poppler-search-non-ascii.patch
3.02/30_all_xpdf-poppler-cxx-flags.patch
3.02/15_all_xpdf-poppler-crash-in-japanese-locale.patch
3.02/35_all_xpdf-poppler-xpdfrc.5-reference.patch
3.02/xpdf.png
3.02/00_all_xpdf-poppler-i18n.patch
root@lynx:/usr/local/portage/app-text/xpdf(10)# popd
/usr/local/portage/app-text/xpdf
root@lynx:/usr/local/portage/app-text/xpdf(11)# ll
total 48
-rw-r--r-- 1 root    root    23882 Aug 24 17:36 ChangeLog
-rw-r--r-- 1 root    root     4693 Aug 24 17:36 Manifest
drwxr-xr-x 3 portage portage  4096 Oct 27 09:41 files/
-rw-r--r-- 1 portage portage   234 Aug  2  2008 metadata.xml
-rw-r--r-- 1 root    root     2930 May 14 22:09 xpdf-3.02-r2.ebuild
-rw-r--r-- 1 root    root     1815 Aug 24 17:36 xpdf-3.02-r3.ebuild
root@lynx:/usr/local/portage/app-text/xpdf(13)# ebuild xpdf-3.02-r3.ebuild digest 
>>> Creating Manifest for /usr/local/portage/app-text/xpdf
root@lynx:/usr/local/portage/app-text/xpdf(14)# 
root@lynx:/usr/local/portage/app-text/xpdf(14)# emerge -pvuDN world

These are the packages that would be merged, in order:

Calculating dependencies ... done!
[ebuild  N    ] app-text/xpdf-3.02-r3  USE="-debug -nodrm" 0 kB [1]

Total: 1 package (1 new), Size of downloads: 0 kB
Portage tree and overlays:
 [0] /usr/portage
 [1] /usr/local/portage
...
root@lynx:/usr/local/portage/app-text/xpdf(15)# emerge -vuDN world

Which fails almost with the same error as before:
...
>>> Verifying ebuild manifests

>>> Emerging (1 of 1) app-text/xpdf-3.02-r3 from local
 * xpdf-3.02-patchset-01.tar.bz2 RMD160 SHA1 SHA256 size ;-) ...                                                                   [ ok ]
 * xpdf-3.02-poppler-20071121.tar.bz2 RMD160 SHA1 SHA256 size ;-) ...                                                              [ ok ]
 * checking ebuild checksums ;-) ...                                                                                               [ ok ]
 * checking auxfile checksums ;-) ...                                                                                              [ ok ]
 * checking miscfile checksums ;-) ...                                                                                             [ ok ]
 * Suppressing warning overload with -Wno-write-strings
>>> Unpacking source...
>>> Unpacking xpdf-3.02-patchset-01.tar.bz2 to /var/tmp/portage/app-text/xpdf-3.02-r3/work
>>> Unpacking xpdf-3.02-poppler-20071121.tar.bz2 to /var/tmp/portage/app-text/xpdf-3.02-r3/work
>>> Source unpacked in /var/tmp/portage/app-text/xpdf-3.02-r3/work
>>> Preparing source in /var/tmp/portage/app-text/xpdf-3.02-r3/work/xpdf-3.02-poppler ...
 * Applying various patches (bugfixes/updates) ...
 *   00_all_xpdf-poppler-i18n.patch ...                                                                                             [ ok ]
 *   05_all_xpdf-poppler-search-non-ascii.patch ...                                                                                 [ ok ]
 *   10_all_xpdf-poppler-cut-and-paste-default-output-encoding.patch ...                                                            [ ok ]
 *   15_all_xpdf-poppler-crash-in-japanese-locale.patch ...                                                                         [ ok ]
 *   20_all_xpdf-poppler-add-and-subtract-key-binding.patch ...                                                                     [ ok ]
 *   25_all_xpdf-poppler-poppler-0.10.0.patch ...                                                                                   [ ok ]
 *   30_all_xpdf-poppler-cxx-flags.patch ...                                                                                        [ ok ]
 *   35_all_xpdf-poppler-xpdfrc.5-reference.patch ...                                                                               [ ok ]
 *   40_all_xpdf-poppler-autohinting-as-option.patch ...                                                                            [ ok ]
 *   45_all_xpdf-poppler-private-textpage-destructor.patch ...                                                                      [ ok ]
 *   50_all_xpdf-poppler-getCMap-arguments.patch ...                                                                                [ ok ]
 * Done with patching
>>> Source prepared.
>>> Configuring source in /var/tmp/portage/app-text/xpdf-3.02-r3/work/xpdf-3.02-poppler ...
>>> Source configured.
>>> Compiling source in /var/tmp/portage/app-text/xpdf-3.02-r3/work/xpdf-3.02-poppler ...
make -j1 
g++ -march=nocona -O2 -pipe -fomit-frame-pointer -DSYSTEM_XPDFRC="\"/etc/xpdfrc\"" -Wno-write-strings -I/usr/include/poppler -I/usr/include/poppler/goo -I/usr/include/poppler/splash -DHAVE_DIRENT_H  -c -o CoreOutputDev.o CoreOutputDev.cc
g++ -march=nocona -O2 -pipe -fomit-frame-pointer -DSYSTEM_XPDFRC="\"/etc/xpdfrc\"" -Wno-write-strings -I/usr/include/poppler -I/usr/include/poppler/goo -I/usr/include/poppler/splash -DHAVE_DIRENT_H  -c -o GlobalParamsGUI.o GlobalParamsGUI.cc
g++ -march=nocona -O2 -pipe -fomit-frame-pointer -DSYSTEM_XPDFRC="\"/etc/xpdfrc\"" -Wno-write-strings -I/usr/include/poppler -I/usr/include/poppler/goo -I/usr/include/poppler/splash -DHAVE_DIRENT_H  -c -o ImageOutputDev.o ImageOutputDev.cc
g++ -march=nocona -O2 -pipe -fomit-frame-pointer -DSYSTEM_XPDFRC="\"/etc/xpdfrc\"" -Wno-write-strings -I/usr/include/poppler -I/usr/include/poppler/goo -I/usr/include/poppler/splash -DHAVE_DIRENT_H  -c -o PDFCore.o PDFCore.cc
g++ -march=nocona -O2 -pipe -fomit-frame-pointer -DSYSTEM_XPDFRC="\"/etc/xpdfrc\"" -Wno-write-strings -I/usr/include/poppler -I/usr/include/poppler/goo -I/usr/include/poppler/splash -DHAVE_DIRENT_H  -c -o XPDFApp.o XPDFApp.cc
g++ -march=nocona -O2 -pipe -fomit-frame-pointer -DSYSTEM_XPDFRC="\"/etc/xpdfrc\"" -Wno-write-strings -I/usr/include/poppler -I/usr/include/poppler/goo -I/usr/include/poppler/splash -DHAVE_DIRENT_H  -c -o XPDFCore.o XPDFCore.cc
XPDFCore.cc: In member function 'void XPDFCore::doAction(LinkAction*)':
XPDFCore.cc:565: warning: ignoring return value of 'int system(const char*)', declared with attribute warn_unused_result
XPDFCore.cc: In member function 'void XPDFCore::runCommand(GooString*, GooString*)':
XPDFCore.cc:689: warning: ignoring return value of 'int system(const char*)', declared with attribute warn_unused_result
g++ -march=nocona -O2 -pipe -fomit-frame-pointer -DSYSTEM_XPDFRC="\"/etc/xpdfrc\"" -Wno-write-strings -I/usr/include/poppler -I/usr/include/poppler/goo -I/usr/include/poppler/splash -DHAVE_DIRENT_H  -c -o XPDFTree.o XPDFTree.cc
g++ -march=nocona -O2 -pipe -fomit-frame-pointer -DSYSTEM_XPDFRC="\"/etc/xpdfrc\"" -Wno-write-strings -I/usr/include/poppler -I/usr/include/poppler/goo -I/usr/include/poppler/splash -DHAVE_DIRENT_H  -c -o XPDFViewer.o XPDFViewer.cc
XPDFViewer.cc: In member function 'void XPDFViewer::cmdRun(GooString**, int, XEvent*)':
XPDFViewer.cc:1157: warning: ignoring return value of 'int system(const char*)', declared with attribute warn_unused_result
cc -march=nocona -O2 -pipe -fomit-frame-pointer -DSYSTEM_XPDFRC="\"/etc/xpdfrc\"" -I/usr/include/poppler -I/usr/include/poppler/goo -I/usr/include/poppler/splash -DHAVE_DIRENT_H  -c -o parseargs.o parseargs.c
g++ -march=nocona -O2 -pipe -fomit-frame-pointer -DSYSTEM_XPDFRC="\"/etc/xpdfrc\"" -Wno-write-strings -I/usr/include/poppler -I/usr/include/poppler/goo -I/usr/include/poppler/splash -DHAVE_DIRENT_H  -c -o xpdf.o xpdf.cc
xpdf.cc: In function 'int main(int, char**)':
xpdf.cc:221: error: 'class GlobalParams' has no member named 'setForceNoFTAutoHinting'
xpdf.cc:223: error: 'class GlobalParams' has no member named 'setForceNoFTAutoHinting'
make: *** [xpdf.o] Error 1

Comment 13 Peter Alfredsen (RETIRED) gentoo-dev 2009-10-27 13:32:19 UTC
*** Bug 290206 has been marked as a duplicate of this bug. ***
Comment 14 Peter Alfredsen (RETIRED) gentoo-dev 2009-10-27 13:35:47 UTC
+*xpdf-3.02-r4 (27 Oct 2009)
+
+  27 Oct 2009; Peter Alfredsen <loki_val@gentoo.org> -xpdf-3.02-r3.ebuild,
+  +xpdf-3.02-r4.ebuild:
+  Add patchset that drops antialiasing patch, fixing bug 289803. Thanks to
+  Clemmitt M. Sigler for the tarball.
+

Wait for the tarball to propagate to mirrors.
Comment 15 Shark 2009-10-27 14:15:51 UTC
(In reply to comment #14)
> +*xpdf-3.02-r4 (27 Oct 2009)
> +
> +  27 Oct 2009; Peter Alfredsen <loki_val@gentoo.org> -xpdf-3.02-r3.ebuild,
> +  +xpdf-3.02-r4.ebuild:
> +  Add patchset that drops antialiasing patch, fixing bug 289803. Thanks to
> +  Clemmitt M. Sigler for the tarball.
> +
> 
> Wait for the tarball to propagate to mirrors.
> 
Thanks!, is the antialiasing patch not useful anymore or this is the onyl way to use xpdf with the newest poppler-lib?