Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 282637 - media-sound/audacious-2.1 nls charset 4n (in mp3) broken
Summary: media-sound/audacious-2.1 nls charset 4n (in mp3) broken
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: x86 Linux
: High normal (vote)
Assignee: Tony Vroon (RETIRED)
URL:
Whiteboard:
Keywords:
: 279236 (view as bug list)
Depends on:
Blocks:
 
Reported: 2009-08-25 05:53 UTC by Sergey S. Starikoff
Modified: 2009-09-16 09:12 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
The patch, which should fix the issue. (chardet.c.patch,759 bytes, patch)
2009-08-25 05:54 UTC, Sergey S. Starikoff
Details | Diff
Ebuild using proposed chardet.c.patch renamed to 2.1-chardet.c.patch (audacious-2.1-r1.ebuild,2.00 KB, text/plain)
2009-09-10 18:05 UTC, Yevgeny Armor
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Sergey S. Starikoff 2009-08-25 05:53:46 UTC
After the update from audacious-1.5.1 to audacious-2.1 I've discovered that the display of ID3 tags in some of existing mp3-files was broken.
In my case the national language is Russian.

Reproducible: Always

Steps to Reproduce:
1. Get the mp3 file with Russian (CP1251-coded) ID3 tags;
2. Rebuild system with Rssian landuage support;
3. Build the audacious-2.1 with 'nls' and 'chardet' USE;
4. Play the downloaded file with audacious.

Actual Results:  
Incorrectly encoded string with ID3 tag content.

Expected Results:  
Correctly encoded string with ID3 tag content.

This problem is described here: http://jira.atheme.org/browse/AUD-36
(the patch http://jira.atheme.org/secure/attachment/10062/chardet.c.patch 
I'll attach the patch to this bug report)

The patch should be included into audacious-2.1 ebuild.
Comment 1 Sergey S. Starikoff 2009-08-25 05:54:51 UTC
Created attachment 202232 [details, diff]
The patch, which should fix the issue.
Comment 2 Tony Vroon (RETIRED) gentoo-dev 2009-09-06 16:18:35 UTC
*** Bug 279236 has been marked as a duplicate of this bug. ***
Comment 3 Yevgeny Armor 2009-09-10 18:05:19 UTC
Created attachment 203702 [details]
Ebuild using proposed chardet.c.patch renamed to 2.1-chardet.c.patch

Fixes the problem, confirmed.
Comment 4 Tony Vroon (RETIRED) gentoo-dev 2009-09-15 23:15:59 UTC
+*audacious-2.2_alpha1 (15 Sep 2009)
+
+  15 Sep 2009; <chainsaw@gentoo.org> +audacious-2.2_alpha1.ebuild:
+  Version bump to (masked) alpha release, includes fixes that close bug
+  #282637 by Sergey S. Starikoff.
Comment 5 George Kargiotakis 2009-09-16 09:12:20 UTC
(In reply to comment #4)
> +*audacious-2.2_alpha1 (15 Sep 2009)
> +
> +  15 Sep 2009; <chainsaw@gentoo.org> +audacious-2.2_alpha1.ebuild:
> +  Version bump to (masked) alpha release, includes fixes that close bug
> +  #282637 by Sergey S. Starikoff.
> 

why wait for 2.2_alpha version and not push the above simple patch for a 2.1-r1 release ? There are many non-english speaking people who would love this package finally fixed in the tree and not in overlays or custom ebuilds...