Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 276404 - media-libs/lcms-1.18-r1 : Package has poor programming practices which may compile fine but exhibit random runtime failures.
Summary: media-libs/lcms-1.18-r1 : Package has poor programming practices which may co...
Status: RESOLVED UPSTREAM
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Printing (show other bugs)
Hardware: All Linux
: High QA (vote)
Assignee: Printing Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-03 22:18 UTC by Romain Perier (RETIRED)
Modified: 2010-01-28 15:17 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch which solves the problem (probably needs to be renamed better) (lcms-1.18-qa-implicit-swab.patch,771 bytes, patch)
2009-07-03 22:19 UTC, Romain Perier (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Romain Perier (RETIRED) gentoo-dev 2009-07-03 22:18:14 UTC
When I tried to emerge lcms on my system, it failed with the following message:

>> Completed installing lcms-1.18-r1 into /var/tmp/portage/media-libs/lcms-1.18-r1/image/

strip: x86_64-pc-linux-gnu-strip --strip-unneeded -R .comment
   usr/bin/wtpt
   usr/bin/icc2ps
   usr/bin/icctrans
   usr/bin/tiffdiff
   usr/bin/icclink
   usr/bin/tifficc
   usr/bin/jpegicc
   usr/lib64/python2.6/site-packages/_lcms.so
   usr/lib64/liblcms.so.1.0.18
   usr/lib64/liblcms.a
   usr/lib64/python2.6/site-packages/_lcms.a
ecompressdir: bzip2 -9 /usr/share/man
removing executable bit: usr/lib64/liblcms.la

 * QA Notice: Package has poor programming practices which may compile
 *            fine but exhibit random runtime failures.
 * cmsio1.c:118: warning: implicit declaration of function 'swab'

 * Please do not file a Gentoo bug and instead report the above QA
 * issues directly to the upstream developers of this software.
 * Homepage: http://www.littlecms.com/
 * 
 * ERROR: media-libs/lcms-1.18-r1 failed.
 * Call stack:
 *       misc-functions.sh, line 729:  Called install_qa_check
 *       misc-functions.sh, line 429:  Called die
 * The specific snippet of code:
 *   				hasq stricter ${FEATURES} && die "install aborted due to" \
 *  The die message:
 *   install aborted due to poor programming practices shown above
 * 
 * If you need support, post the topmost build error, and the call stack if relevant.
 * A complete build log is located at '/var/tmp/portage/media-libs/lcms-1.18-r1/temp/build.log'.
 * The ebuild environment file is located at '/var/tmp/portage/media-libs/lcms-1.18-r1/temp/environment'.
 * 
!!! post install failed; exiting.

>>> Failed to emerge media-libs/lcms-1.18-r1, Log file:

>>>  '/var/tmp/portage/media-libs/lcms-1.18-r1/temp/build.log'

 * Messages for package media-libs/lcms-1.18-r1:

 * 
 * ERROR: media-libs/lcms-1.18-r1 failed.
 * Call stack:
 *       misc-functions.sh, line 729:  Called install_qa_check
 *       misc-functions.sh, line 429:  Called die
 * The specific snippet of code:
 *   				hasq stricter ${FEATURES} && die "install aborted due to" \
 *  The die message:
 *   install aborted due to poor programming practices shown above
 * 
 * If you need support, post the topmost build error, and the call stack if relevant.
 * A complete build log is located at '/var/tmp/portage/media-libs/lcms-1.18-r1/temp/build.log'.
 * The ebuild environment file is located at '/var/tmp/portage/media-libs/lcms-1.18-r1/temp/environment'.
 *

There were two QA warnings which caused the error :
1)° src/cmsio1.c : implicit declaration of swap
2)° src/cmsio1.c : implicit declaration of strcasecmp.

You'll find in attachment, a patch which solves the problem.

Regards,
Romain.
Comment 1 Romain Perier (RETIRED) gentoo-dev 2009-07-03 22:19:32 UTC
Created attachment 196549 [details, diff]
Patch which solves the problem (probably needs to be renamed better)
Comment 2 Myckel Habets 2009-07-04 03:47:17 UTC
In the description of your bug you posted the following:

 * Please do not file a Gentoo bug and instead report the above QA
 * issues directly to the upstream developers of this software.
 * Homepage: http://www.littlecms.com/

Did you already contacted the lcms developers regarding this issue?
Comment 3 Romain Perier (RETIRED) gentoo-dev 2009-07-04 07:29:29 UTC
(In reply to comment #2)
> In the description of your bug you posted the following:
> 
>  * Please do not file a Gentoo bug and instead report the above QA
>  * issues directly to the upstream developers of this software.
>  * Homepage: http://www.littlecms.com/
> 
> Did you already contacted the lcms developers regarding this issue?
> 

An upstream already exists about this issue
http://sourceforge.net/tracker/?func=detail&aid=2547890&group_id=26279&atid=386679

The problem is this bug was closed as WontFix, according to them this bug seems to be not valid, however the emerge fails, so we need to find a solution about it... Because this error will happen again...
Comment 4 Peter Volkov (RETIRED) gentoo-dev 2009-12-01 10:48:50 UTC
Just drop stricter from FEATURES and it will work. Maintaining such patches downstream just makes our life harder with no real benefit. So, please, show patch upstream, and make sure they apply it. I don't think they really opposed to fix build warning, but "random runtime failures" could really sound a little offensive for a good upstream.