Bugzilla Bug 248049

[I] net-misc/nxserver-freeedition
     Available versions:  3.2.0!s (~)3.2.0-r1!s (~)3.2.0.13!s (~)3.2.0.16!s
(~)3.3.0.8!s
     Installed versions:  3.3.0.8!s(11:42:56 11/21/08)
     Homepage:            http://www.nomachine.com/
     Description:         Free edition NX server from NoMachine

I was upgrading from 3.2.0.16 to 3.3.0.8 and the upgrade failed with this
error:

--------------------------------------------------------------------- 

NX> 701 ERROR: Output: /bin/cp: cannot stat
`/usr/NX/home/nx/.ssh/default.id_dsa.pub.backup': No such file or directory.
NX> 701 ERROR: Cannot restore DSA key..

--------------------------------------------------------------------- 

To work around the problem I simply touched an empty
'/usr/NX/home/nx/.ssh/default.id_dsa.pub.backup'.  Probably the script should
be a bit smarter and check if the backup exists before copying.


Reproducible: Always

Steps to Reproduce:
1. have an install of nxserver-freedition with only DSA keys not RSA.
2. try and upgrade to 3.3.0.8
3. boom

Actual Results:  
* Running NoMachine's update script
NX> 701 Updating: server at: Fri Nov 21 11:41:51 2008.
NX> 701 Autodetected system: gentoo.
NX> 701 Update log is: /usr/NX/var/log/update.
NX> 701 Checking NX server configuration using /usr/NX/etc/server.cfg file.
NX> 723 Cannot start NX statistics:
NX> 709 NX statistics are disabled for this server.
NX> 701 ERROR: Output: /bin/cp: cannot stat
`/usr/NX/home/nx/.ssh/default.id_dsa.pub.backup': No such file or directory.
NX> 701 ERROR: Cannot restore DSA key..
 *
 * ERROR: net-misc/nxserver-freeedition-3.3.0.8 failed.
 * Call stack:
 *               ebuild.sh, line   49:  Called pkg_postinst
 *             environment, line 2221:  Called die
 * The specific snippet of code:
 *           "${ROOT}"/usr/NX/scripts/setup/nxserver --update || die "Update
script failed";
 *  The die message:
 *   Update script failed
 *
 * If you need support, post the topmost build error, and the call stack if
relevant.
 * A complete build log is located at
'/var/tmp/portage/net-misc/nxserver-freeedition-3.3.0.8/temp/build.log'.
 * The ebuild environment file is located at
'/var/tmp/portage/net-misc/nxserver-freeedition-3.3.0.8/temp/environment'.



Expected Results:  
clean upgrade.

Ooops, I meant no DSA keys, not RSA. :)

Ouch upstream fix for default DSA key (in the setup script) does not like our
handling of key files.

Fixed and bumped in CVS, thanks for the report!

If you still have problems, you may need to uninstall and reinstall nx.

*** Bug 248124 has been marked as a duplicate of this bug. ***

Yeah I did end up having to uninstall and reinstall because I couldn't get the
server to startup correctly.  It's working now but only after deleting all the
files left over from the previous install.  Thanks for fixing this!