Bugzilla Bug 240714

Using v0.9.4 breaks the "Embed" option that embeds the controls into the Video
window. The controls are always unembedded, even when the option is switched
off and on in VLC's settings. This used to work fine in 0.9.3.

There is a forum topic related to this bug.

http://forum.videolan.org/viewtopic.php?f=13&t=51032

(In reply to comment #1)
> There is a forum topic related to this bug.
> 
> http://forum.videolan.org/viewtopic.php?f=13&t=51032
> 

I can confirm it, the embed option is ignored. As for the forum topic there
doesn't seem t be any resolution at the moment. Also, i dont know why, but it
does not seem to respect my qtconfig settings; the fonts in the menubar look
rather ungainly.

The Embed option was intentionally breaked by the VLC developers due to a weird
bug in QT versions lower than 4.3
See
http://git.videolan.org/gitweb.cgi?p=vlc.git;a=commit;h=fff7615fa9bf44f90ac5573eb2964bcb51e4ac3c

However a patch has also been commited that re-enable the Embed at compilation
time for those who use QT >= 4.3

Take a look here
http://git.videolan.org/?p=vlc.git;a=commit;h=9c26b8e2a04468aa4b4a158f072d760a991932db

We could maybe add it to the tree as well ?

(In reply to comment #3)
> The Embed option was intentionally breaked by the VLC developers due to a weird
> bug in QT versions lower than 4.3
.
> We could maybe add it to the tree as well ?
> 

I believe so, as =x11-libs/qt-4.3.3 is stable on all architectures.

And what about the fonts in the menubar and dialogs of vlc?

(In reply to comment #4)
> And what about the fonts in the menubar and dialogs of vlc?

I think this is not related to the current bug.

(In reply to comment #5)
> (In reply to comment #4)
> > And what about the fonts in the menubar and dialogs of vlc?
> 
> I think this is not related to the current bug.
> 

Indeed, I apologize.

Please have a look at:
http://mailman.videolan.org/pipermail/vlc-devel/2008-September/051245.html

The mentionned "fix" here has only be applied to the master branch of vlc, aka
future 1.0.0; so that means there will be no upstream support for it and that
it can still be crashy due to race conditions. I'm tempted to close this bug as
upstream since it's not a bug but a disabled feature due to its problems...

I must disagree with Upstream here. Embed should be available, especially since
on Gentoo >=qt-4.3 is stable, so this bug wouldn't occur either way. And if it
did, it's up to the user to decide whether to enable it or not.

Ok...

I am a VLC developer
The crash is a race and it can happen when Qt < 4.3 (4.3 and 4.4 is fine) and
it was deactivated a bit too quickly by some people on the team.

There is a patch that activates it if HAS_QT43 in master and that has been/will
be backported soon to VLC 0.9.5.

Either stick to 0.9.3 or backport the change that reactivates that.

jb

thanks for the explanations jb; -r1 should hit the mirrors soon with the change

(In reply to comment #10)
> thanks for the explanations jb; -r1 should hit the mirrors soon with the change
> 

Thanks to everybody, -r1 works well with the embedded option.

As a strange matter of fact: embedded video worked nicely here. But this patch
breaks it.

Do I have to delete the config or what is the issue?

Shall I open a bug that this patch breaks embedded video for some while it
attempts to fix it for others?

Well, nevermind.

I just manually masked this version and went back to 0.9.4 - all fine again.

It seems that the new 0.9.5 lacks the patch to enable Embed. It broke again.

(In reply to comment #14)
> It seems that the new 0.9.5 lacks the patch to enable Embed. It broke again.
> 

yes and this time i won't merge the patch because it still happens to crash
from time to time...

see http://mailman.videolan.org/pipermail/vlc-devel/2008-October/052200.html

if you want this enabled again please poke upstream to make a new release with
it fixed and enabled.