First Last Prev Next    No search results available      Search page      Enter new bug
Bug#: 238520
Alias:
Product:
Component:
Status: RESOLVED
Resolution: FIXED
Assigned To: Gentoo KDE team <kde@gentoo.org>
Hardware:
OS:
Version:
Priority:
Severity:
Reporter: Ambroz Bizjak <ambro@b4ever.net>
Add CC:
CC:
URL:
Summary:
Status Whiteboard:
Keywords:

Filename Description Type Creator Created Size Actions
kdelibs-4.1.1-ntfs3g-locale.patch KDE 4.1 fix (kdelibs patch) patch Ambroz Bizjak 2008-09-23 22:21 0000 1006 bytes Details | Diff
kdebase-3.5.9-ntfs3g-locale.patch KDE 3.5.9 fix (kdebase / kdebase-kioslaves) patch Ambroz Bizjak 2008-09-24 12:51 0000 936 bytes Details | Diff
kdebase-3.5.10-ntfs3g-locale.patch KDE 3.5.10 fix (kdebase/kdebase-kioslaves) patch Ambroz Bizjak 2008-09-24 12:51 0000 2.25 KB Details | Diff
kdebase-3.5.10-ntfs3g-locale.patch KDE 3.5.10 fix (kdebase / kdebase-kioslaves) patch Ambroz Bizjak 2008-09-24 14:03 0000 2.27 KB Details | Diff
Create a New Attachment (proposed patch, testcase, etc.) View All

Bug 238520 depends on: Show dependency tree
Bug 238520 blocks:
Votes: 0    Show votes for this bug    Vote for this bug

Additional Comments: (this is where you put emerge --info)


Not eligible to see or edit group visibility for this bug.






View Bug Activity   |   Format For Printing   |   XML   |   Clone This Bug


Description:   Opened: 2008-09-23 22:20 0000
If the latest unstable sys-fs/ntfs3g is installed with the 'hal' use flag, KDE
can mount NTFS filesystems with the ntfs-3g driver through HAL.
However, ntfs-3g has to be provided a locale so it can translate file names
with non-ascii characters.
ntfs-3g will check its environment variables (LC_ALL, ...) and also has a
"locale" mount option. It never has those environment variables, even if a
system locale is configured. So the best would be for KDE to provide the locale
though HAL (which allows it) as in the user's enviroment; but it doesn't right
now.

I have a patch for KDE 4.1 which solves the problem by providing the "locale"
option to HAL. I will post the KDE 3.5 patch shortly, and will also commit both
upstream.

I've set the severity to critical, because it presents a potential data loss
(e.g. you backup a folder from your NTFS drive, and have no idea some files
with non-ascii names were not copied).

Reproducible: Always

Steps to Reproduce:

------- Comment #1 From Ambroz Bizjak 2008-09-23 22:21:44 0000 -------
Created an attachment (id=166221) [details]
KDE 4.1 fix (kdelibs patch)

------- Comment #2 From Ambroz Bizjak 2008-09-23 22:31:22 0000 -------
I've forgot to mention why there could be a data loss: if ntfs-3g is not
provided a locale, it will fail to show any files with non-ascii names. It will
also refuse the creation of such files.

------- Comment #3 From Ambroz Bizjak 2008-09-24 12:51:35 0000 -------
Created an attachment (id=166269) [details]
KDE 3.5.9 fix (kdebase / kdebase-kioslaves)

------- Comment #4 From Ambroz Bizjak 2008-09-24 12:51:52 0000 -------
Created an attachment (id=166271) [details]
KDE 3.5.10 fix (kdebase/kdebase-kioslaves)

------- Comment #5 From Ambroz Bizjak 2008-09-24 14:03:18 0000 -------
Created an attachment (id=166272) [details]
KDE 3.5.10 fix (kdebase / kdebase-kioslaves)

Mounting plain ntfs (kernel driver, no ntfs-3g) was broken (with and without my
patch) in KDE 3.5.10.
HAL somehow always lists the "locale" option as available for the "ntfs"
fstype, which is not really supported by the default kernel driver, providing
it will trigger a mount error. Maybe it was meant for the the ntfsmount driver
from linux-ntfs, which is really unmaintained and broken. So, I added a check
to pass the locale only if the fstype is "ntfs-3g", as in the other two
patches.

------- Comment #6 From Jorge Manuel B. S. Vicetto 2008-09-26 04:30:08 0000 -------
Please add the link to the upstream bugs/commits and reopen again.

------- Comment #7 From Ambroz Bizjak 2008-09-26 09:03:48 0000 -------
Upstream commits:
3.5 branch: http://websvn.kde.org/?view=rev&revision=864963
4.1 branch: http://websvn.kde.org/?view=rev&revision=864120
trunk: http://websvn.kde.org/?view=rev&revision=864123

The 3.5.9 patch posted here is different from the committed 3.5 patch because
since 3.5.10 there is already some (broken) locale support, but the resulting
code is the same.

------- Comment #8 From Jorge Manuel B. S. Vicetto 2008-10-01 00:49:51 0000 -------
I've just added a revbumped 3.5.9 and 3.5.10 to the tree with the provided
patches.
I haven't fixed 4.1.1 as 4.1.2 should be released tomorrow and provides the
fix.

First Last Prev Next    No search results available      Search page      Enter new bug