First Last Prev Next    No search results available      Search page      Enter new bug
Bug#: 238248
Alias:
Product:
Component:
Status: RESOLVED
Resolution: FIXED
Assigned To: Steve Arnold <nerdboy@gentoo.org>
Hardware:
OS:
Version:
Priority:
Severity:
Reporter: Oscar Hellström <oscar@oscarh.net>
Add CC:
CC:
Remove selected CCs
URL:
Summary:
Status Whiteboard:
Keywords:

Filename Description Type Creator Created Size Actions
Create a New Attachment (proposed patch, testcase, etc.) View All

Bug 238248 depends on: Show dependency tree
Bug 238248 blocks:
Votes: 10    Show votes for this bug    Vote for this bug

Additional Comments: (this is where you put emerge --info)


Not eligible to see or edit group visibility for this bug.






View Bug Activity   |   Format For Printing   |   XML   |   Clone This Bug


Description:   Opened: 2008-09-21 03:56 0000
* Failed Patch: tiff-3.8.2-tiff2pdf.patch !
 *  ( /var/tmp/portage/media-libs/tiff-3.8.2-r4/work/tiff-3.8.2-tiff2pdf.patch
)
 * 
 * Include in your bugreport the contents of:
 * 
 *  
/var/tmp/portage/media-libs/tiff-3.8.2-r4/temp/tiff-3.8.2-tiff2pdf.patch-28912.out

Contents of 
/var/tmp/portage/media-libs/tiff-3.8.2-r4/temp/tiff-3.8.2-tiff2pdf.patch-28912.out:

Can't apply patch, output from emerge:

***** tiff-3.8.2-tiff2pdf.patch *****

NOTE: skipping -p0 due to absolute paths in patch:
2:+++ /home/sarnold/src/libtiff/tools/tiff2pdf.c        2006-06-08
04:27:11.000000000 -0700
=====================================

PATCH COMMAND:   patch -p1 -g0 -E --no-backup-if-mismatch <
/var/tmp/portage/media-libs/tiff-3.8.2-r4/work/tiff-3.8.2-tiff2pdf.patch

=====================================
can't find file to patch at input line 3
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|--- tools/tiff2pdf.c   2006-03-21 08:42:51.000000000 -0800
|+++ /home/sarnold/src/libtiff/tools/tiff2pdf.c 2006-06-08 04:27:11.000000000
-0700
--------------------------
No file to patch.  Skipping patch.
75 out of 75 hunks ignored
=====================================

PATCH COMMAND:   patch -p2 -g0 -E --no-backup-if-mismatch <
/var/tmp/portage/media-libs/tiff-3.8.2-r4/work/tiff-3.8.2-tiff2pdf.patch

=====================================
missing header for unified diff at line 3 of patch
can't find file to patch at input line 3
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|--- tools/tiff2pdf.c   2006-03-21 08:42:51.000000000 -0800
|+++ /home/sarnold/src/libtiff/tools/tiff2pdf.c 2006-06-08 04:27:11.000000000
-0700
--------------------------
No file to patch.  Skipping patch.
75 out of 75 hunks ignored
=====================================

PATCH COMMAND:   patch -p3 -g0 -E --no-backup-if-mismatch <
/var/tmp/portage/media-libs/tiff-3.8.2-r4/work/tiff-3.8.2-tiff2pdf.patch

=====================================
missing header for unified diff at line 3 of patch
can't find file to patch at input line 3
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|--- tools/tiff2pdf.c   2006-03-21 08:42:51.000000000 -0800
|+++ /home/sarnold/src/libtiff/tools/tiff2pdf.c 2006-06-08 04:27:11.000000000
-0700
--------------------------
No file to patch.  Skipping patch.
75 out of 75 hunks ignored
=====================================

PATCH COMMAND:   patch -p4 -g0 -E --no-backup-if-mismatch <
/var/tmp/portage/media-libs/tiff-3.8.2-r4/work/tiff-3.8.2-tiff2pdf.patch

=====================================
missing header for unified diff at line 3 of patch
can't find file to patch at input line 3
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|--- tools/tiff2pdf.c   2006-03-21 08:42:51.000000000 -0800
|+++ /home/sarnold/src/libtiff/tools/tiff2pdf.c 2006-06-08 04:27:11.000000000
-0700
--------------------------
No file to patch.  Skipping patch.
75 out of 75 hunks ignored


Reproducible: Always

Steps to Reproduce:
1. emerge --sync
2. emere tiff

------- Comment #1 From Till Korten 2008-09-21 11:51:23 0000 -------
same here...

------- Comment #2 From Christian Gut 2008-09-21 16:33:11 0000 -------
same here.

------- Comment #3 From emdej 2008-09-21 16:53:31 0000 -------
same here.

------- Comment #4 From Wicher Minnaard 2008-09-21 16:56:11 0000 -------
Same here. Bug seems to originate upstream, as the b0rked patch is in the
tarball, not in the filesdir.

------- Comment #5 From airyk@sabowski.com 2008-09-21 17:11:52 0000 -------
Here's a quick fix, as I would hope this gets fixed properly soon anyway

I created a local overlay ebuild for tiff-3.8.2-4, and put the offending
patchfile (tiff-3.8.2-tiff2pdf.patch) into the files directory in the overlay
ebuild.

Patch the ebuild file with this:
--- tiff-3.8.2-r4.ebuild        2008-09-21 08:51:16.000000000 -0400
+++ tiff-3.8.2-r4.ebuild        2008-09-21 08:53:19.000000000 -0400
@@ -6,8 +6,7 @@

 DESCRIPTION="Library for manipulation of TIFF (Tag Image File Format) images"
 HOMEPAGE="http://www.remotesensing.org/libtiff/"
-SRC_URI="ftp://ftp.remotesensing.org/pub/libtiff/${P}.tar.gz
-       mirror://gentoo/${P}-tiff2pdf.patch.bz2"
+SRC_URI="ftp://ftp.remotesensing.org/pub/libtiff/${P}.tar.gz"

 LICENSE="as-is"
 SLOT="0"
@@ -21,7 +20,7 @@
 src_unpack() {
        unpack ${A}
        cd "${S}"
-       epatch "${WORKDIR}"/${P}-tiff2pdf.patch
+       epatch "${FILESDIR}"/${P}-tiff2pdf.patch
        epatch "${FILESDIR}"/${P}-tiffsplit.patch
        if use jbig; then
                epatch "${FILESDIR}"/${PN}-jbig.patch


then patch tiff-3.8.2-tiff2pdf.patch with this:
--- tiff-3.8.2-tiff2pdf.patch   2008-09-21 09:02:52.000000000 -0400
+++ tiff-3.8.2-tiff2pdf.patch   2008-09-21 08:49:08.000000000 -0400
@@ -1,5 +1,5 @@
 --- tools/tiff2pdf.c   2006-03-21 08:42:51.000000000 -0800
-+++ /home/sarnold/src/libtiff/tools/tiff2pdf.c 2006-06-08 04:27:11.000000000
-0700
++++ tools/tiff2pdf.c   2006-06-08 04:27:11.000000000 -0700

------- Comment #6 From c0rnoTa 2008-09-21 18:41:14 0000 -------
I have modified /usr/portage/distfiles/tiff-3.8.2-tiff2pdf.patch.gz :

line 3 was: 
--- tools/tiff2pdf.c   2006-03-21 08:42:51.000000000 -0800
set to: 
--tiff-3.8.2/libtiff/tools/tiff2pdf.c   2006-03-21 08:42:51.000000000 -0800

and line 4 was: 
+++ /home/sarnold/src/libtiff/tools/tiff2pdf.c 2006-06-08 04:27:11.000000000
-0700
set to:
+++ tiff-3.8.2/libtiff/tools/tiff2pdf.c 2006-06-08 04:27:11.000000000 -0700

then generate new SHA256:
sha256sum /usr/porttage/distfiles/tiff-3.8.2-tiff2pdf.patch.gz

and finally put new sha256 sum into /usr/portage/media-libs/tiff/Manifest

it works for me

------- Comment #7 From Ryan Anderson 2008-09-22 02:19:32 0000 -------
You can get around this by using the "unstable" version:
# ACCEPT_KEYWORDS="~amd64" emerge tiff -av

or ~x86 if you are on a 32bit arch.

------- Comment #8 From Markus Meier 2008-09-22 05:00:56 0000 -------
this happens due to a change of epatch behavior.
@nerdboy: do you/me want to create a new patch (with a correct directory) or
change the directory of the diff with sed in the ebuild?

RCS file: /var/cvsroot/gentoo-x86/eclass/eutils.eclass,v
Working file: eutils.eclass
head: 1.307
branch:
locks: strict
access list:
symbolic names:
        RELEASE-1_4: 1.46.0.2
        GENTOO_1_4_SNAP_2003010800: 1.12
keyword substitution: kv
total revisions: 308;   selected revisions: 308
description:
----------------------------
revision 1.307
date: 2008-09-20 21:03:31 +0200;  author: vapier;  state: Exp;  lines: +6 -4; 
commitid: e5248d549014567;
even better: dont whine about abs paths, just transparently skip the -p0 step
and log why we are
----------------------------
revision 1.306
date: 2008-09-20 20:58:57 +0200;  author: vapier;  state: Exp;  lines: +4 -2; 
commitid: dbd48d547ee4567;
filter /dev/null from abs path check and include the offending line in the
warning
----------------------------
revision 1.305
date: 2008-09-20 20:55:07 +0200;  author: vapier;  state: Exp;  lines: +8 -1; 
commitid: d6048d547094567;
start whining about absolute paths in patch files
----------------------------

------- Comment #9 From Thomas Sachau 2008-09-22 14:14:16 0000 -------
*** Bug 238359 has been marked as a duplicate of this bug. ***

------- Comment #10 From Thomas Sachau 2008-09-22 14:19:06 0000 -------
*** Bug 238383 has been marked as a duplicate of this bug. ***

------- Comment #11 From Thomas Sachau 2008-09-22 14:20:55 0000 -------
*** Bug 238391 has been marked as a duplicate of this bug. ***

------- Comment #12 From SpanKY 2008-09-22 15:34:49 0000 -------
fixed in cvs

http://sources.gentoo.org/media-libs/tiff/tiff-3.8.2-r4.ebuild?r1=1.4&r2=1.5

------- Comment #13 From Kobboi 2008-09-22 18:02:32 0000 -------
(In reply to comment #7)
> You can get around this by using the "unstable" version:
> # ACCEPT_KEYWORDS="~amd64" emerge tiff -av
> 
> or ~x86 if you are on a 32bit arch.

The right way to do that is to use /etc/portage/package.* files or directories
for that. Also, emerge a package with the -1 option if you don't want it to end
up in your world file (you probably don't in this case).

Anyway, I confirm that the 3.8.2-r5 works like a charm.

------- Comment #14 From André Terpstra 2008-09-23 04:50:03 0000 -------
Solution confirmed.

------- Comment #15 From Peter Alfredsen 2008-09-23 09:44:41 0000 -------
*** Bug 238454 has been marked as a duplicate of this bug. ***

------- Comment #16 From stootch 2008-09-23 16:15:23 0000 -------
(In reply to comment #7)
> You can get around this by using the "unstable" version:
> # ACCEPT_KEYWORDS="~amd64" emerge tiff -av
> 
> or ~x86 if you are on a 32bit arch.
> 

Afterwards emerge it normally (without ACCEPT_KEYWORDS) and you'll end up with
stable version :)

First Last Prev Next    No search results available      Search page      Enter new bug