First Last Prev Next    No search results available      Search page      Enter new bug
Bug#: 237393
Alias:
Product:
Component:
Status: RESOLVED
Resolution: FIXED
Assigned To: Gentoo's Team for Core System packages <base-system@gentoo.org>
Hardware:
OS:
Version:
Priority:
Severity:
Reporter: Anders Aagaard <aagaande@gmail.com>
Add CC:
CC:
Remove selected CCs
URL:
Summary:
Status Whiteboard:
Keywords:

Filename Description Type Creator Created Size Actions
reiser4progs-1.0.6-preen-r2.patch Let -p "preen" fallthrough to -a "auto". patch Anders Aagaard 2008-09-11 11:07 0000 2.34 KB Details | Diff
Create a New Attachment (proposed patch, testcase, etc.) View All

Bug 237393 depends on: Show dependency tree
Bug 237393 blocks: 195988
Votes: 20    Show votes for this bug    Vote for this bug

Additional Comments: (this is where you put emerge --info)


Not eligible to see or edit group visibility for this bug.






View Bug Activity   |   Format For Printing   |   XML   |   Clone This Bug

Description:   Opened: 2008-09-11 11:07 0000 
The reiser4progs patch added in 1.0.6-r1 adding -p "preen" support to
reiser4progs is implemented wrongly, causing a fsck on every boot, including
when the filesystem is marked clean.

Boot time on my usb pen:
with old patch : 4 minutes 23 seconds
with my patch : 41 seconds.

This is obviously a pretty big flaw.

Please see
http://thread.gmane.org/gmane.comp.file-systems.reiserfs.general/21324 for more
information, Edward Shishkin (current reiser4 maintainer) confirms that this
patch is correct behavior.  The only thing it'll break is docs (refering to -p
as list plugins, not preen).

I've used reiser4 on and off on different media for a while now, and thought
reiser4 fsck was this slow during it's development period, so this patch is
obviously a pretty big bug from the gentoo team, especially for something this
easy to fix, therefor marking as major.

Reproducible: Always

------- Comment #1 From Anders Aagaard 2008-09-11 11:07:52 0000 ------- 
Created an attachment (id=165196) [details]
Let -p "preen" fallthrough to -a "auto".

------- Comment #2 From Jeremy Olexa (darkside) 2008-09-11 19:46:17 0000 ------- 
vapier: Did you have some comments on this one. Confusing looking at the
related bug and whatnot. thx

------- Comment #3 From edward 2008-09-20 17:35:13 0000 ------- 
(In reply to comment #0)
> The reiser4progs patch added in 1.0.6-r1 adding -p "preen" support to
> reiser4progs is implemented wrongly, causing a fsck on every boot, including
> when the filesystem is marked clean.
> 
> Boot time on my usb pen:
> with old patch : 4 minutes 23 seconds
> with my patch : 41 seconds.
> 
> This is obviously a pretty big flaw.
> 
> Please see
> http://thread.gmane.org/gmane.comp.file-systems.reiserfs.general/21324 for more
> information, Edward Shishkin (current reiser4 maintainer) confirms that this
> patch is correct behavior.

Actually, I didn't.

Please, consider the let-preen-fall-through-to-auto patch.
Checking a reiser4 partition on every boot is wrong behavior.
It is not supposed to be checked even after hard reset..

Thanks,
Edward.

------- Comment #4 From Mike Qin 2008-09-27 12:25:43 0000 ------- 
Yes, this patch works for me.
Thanks for the patch!

------- Comment #5 From SpanKY 2008-10-26 07:16:12 0000 ------- 
if it works for you guys, that's fine by me ... ive added 1.0.6-r2 with it,
thanks!

http://sources.gentoo.org/sys-fs/reiser4progs/files/reiser4progs-1.0.6-preen.patch?r1=1.1&r2=1.2

------- Comment #6 From SpanKY 2008-10-26 12:29:48 0000 ------- 
*** Bug 226463 has been marked as a duplicate of this bug. ***
First Last Prev Next    No search results available      Search page      Enter new bug