Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 233472 - audacity-1.3.5 doesn't compile, ExportFLAC.cpp include directive, missing file vorbis/vorbisenc.h
Summary: audacity-1.3.5 doesn't compile, ExportFLAC.cpp include directive, missing fil...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Professional Audio Applications Maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-07-31 11:26 UTC by tangram
Modified: 2008-08-08 08:02 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch which changes existing include to the conditional include. (audacity-1.3.5.ebuild.tar.bz2,7.31 KB, patch)
2008-08-04 12:17 UTC, tangram
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description tangram 2008-07-31 11:26:16 UTC
Audacity-1.3.5 fails to compile because missing include file.

Reproducible: Always

Steps to Reproduce:
1. USE flags "alsa flac id3tag ladspa mp3 twolame vamp"
2. emerge audacity
3.

Actual Results:  
i686-pc-linux-gnu-g++ -c -O2 -march=pentium2 -pipe -I../lib-src/portmixer/include -I../lib-src/portaudio-v19/include -O2 -march=pentium2 -pipe       -I../lib-src/libresample/include -I../lib-src/libnyquist/nyx      -I../lib-src/allegro -I../lib-src/FileDialog -fno-strict-aliasing -I./include -I. -DLIBDIR=\"/usr/lib\"  -I/usr/lib/wx/include/gtk2-unicode-release-2.8 -I/usr/include/wx-2.8 -D_FILE_OFFSET_BITS=64 -D_LARGE_FILES -D__WXGTK__ -pthread   export/ExportFLAC.cpp -o export/ExportFLAC.o
export/ExportFLAC.cpp:32:30: error: vorbis/vorbisenc.h: Nie ma takiego pliku ani katalogu ( means missing file)
make[1]: *** [export/ExportFLAC.o] BĹ‚Ä…d 1
make[1]: *** Oczekiwanie na niezakończone zadania....


Portage 2.2_rc4 (default/linux/x86/2008.0, gcc-4.3.1, glibc-2.8_p20080602-r0, 2.6.25-gentoo-r7 i686)
Comment 1 tangram 2008-08-04 12:17:06 UTC
Created attachment 162185 [details, diff]
Patch which changes existing include to the conditional include.

I prepared proposed patch which changes existing include to the conditional include.

ExportFLAC_conditional_vorbisenc_h_include.patch
{
--- src/export/ExportFLAC.cpp	2008-08-01 01:07:09.000000000 +0200
+++ src/export/ExportFLAC.cpp	2008-08-01 23:48:01.000000000 +0200
@@ -29,7 +29,10 @@
 #include <wx/log.h>
 #include <wx/msgdlg.h>
 
+#ifdef USE_LIBVORBIS
 #include <vorbis/vorbisenc.h>
+#endif // USE_LIBVORBIS
+
 #include "FLAC++/encoder.h"
 
 #include "../float_cast.h"
}

Could someone( from gurus) check it please, it's my first patch.
Comment 2 Alexis Ballier gentoo-dev 2008-08-07 17:19:23 UTC
patch added, thanks a lot!
please don't forget to send it to the audacity developers so that it can be fixed for good.
Comment 3 tangram 2008-08-08 08:02:34 UTC
Audacity developers notified.
Hi Alexis, I sent email with short description and link to gentoo bugzilla to audacity-devel@lists.sourceforge.net
Tangram