Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 221117 - [ebuild] x11-drivers/linuxwacom - Disable quirk rescaling, and support old baudrate
Summary: [ebuild] x11-drivers/linuxwacom - Disable quirk rescaling, and support old ba...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Robert Buchholz (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-05-09 17:41 UTC by Gautam Iyer
Modified: 2009-04-11 13:15 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Ebuild for linuxwacom-0.8.0 (linuxwacom-0.8.0-r1.ebuild,3.46 KB, text/plain)
2008-05-09 17:48 UTC, Gautam Iyer
Details
Patch to fall back to 19200 baud (0.8.0-Fixed-Tablet-PC-baudrate-19200-issue.patch,8.16 KB, patch)
2008-05-09 17:49 UTC, Gautam Iyer
Details | Diff
Patch from upstream (git) fixing eraser calibration when rotated (0.8.0-Fixed-rotation-routine.patch,19.10 KB, patch)
2008-05-14 18:25 UTC, Gautam Iyer
Details | Diff
Ebuild for linuxwacom-0.8.0 using the above two patches (linuxwacom-0.8.0-r1.ebuild,3.51 KB, text/plain)
2008-05-14 18:27 UTC, Gautam Iyer
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gautam Iyer 2008-05-09 17:41:26 UTC
Hi,

The attached ebuild fixes two problems:

    1. Disables quirk rescaling on >=xorg-server-1.4.0.90-r4. (If you don't apply the patch see attachment 146971 [details] in bug 214233 for what happens if you use quirk rescaling.)

    2. Adds a patch from upstream that makes the recent drivers play nice with Tablet PC's that only support 19200 baud. The 0.8.0 drivers test 38400 baud and then dies on failure. The attached patch gracefully retries 19200.

GI
Comment 1 Gautam Iyer 2008-05-09 17:48:03 UTC
Created attachment 152653 [details]
Ebuild for linuxwacom-0.8.0
Comment 2 Gautam Iyer 2008-05-09 17:49:33 UTC
Created attachment 152655 [details, diff]
Patch to fall back to 19200 baud
Comment 3 Gautam Iyer 2008-05-14 18:25:58 UTC
Created attachment 153145 [details, diff]
Patch from upstream (git) fixing eraser calibration when rotated

With the 0.8.0 drivers, the eraser is off by half a screen when the screen is rotated. Consequently the 0.8.0 drivers are useless if you rotate your screen.

Ping kindly posted a patch in git fixing this issue. I attach it here, along with an ebuild to use it.
Comment 4 Gautam Iyer 2008-05-14 18:27:02 UTC
Created attachment 153147 [details]
Ebuild for linuxwacom-0.8.0 using the above two patches
Comment 5 Gautam Iyer 2008-05-14 23:39:36 UTC
Looks like Ping made a 0.8.0-1 release with these patches included. You can probably close this bug, once you make a 0.8.0-1 ebuild.

Pretty please don't just version bump the original ebuild! Disable quirk rescaling on xorg-1.4.0.90-r4 or later, as is done in the ebuild in this bug.
Comment 6 Mike Auty (RETIRED) gentoo-dev 2008-05-24 18:16:26 UTC
Hi Gautam,

Thanks for your patches and ebuild, and sorry for the late delay.  I've added a bumped ebuild (0.8.0_p3) to my personal overlay (ikelos).

Please be careful when posting ebuilds, yours include >=xorg-server-1.4.0.90-r3 (not -r4), which nearly made me just bump the old ebuild.  Disabling quirks mode in 1.4.0.90-r3 really breaks things (no coarse control, the mouse jumps 10 pixels a move), and doing it in -r4 just breaks them a little (no fine grained control, just two or three pixels a move).  So for the time being I've added a USE flag called quirks which is on by default.

After a week or two of testing this should hit the main tree.  Thanks again...  5:)
Comment 7 Gautam Iyer 2008-05-25 01:32:52 UTC
(In reply to comment #6)
> Hi Gautam,
> 
> Thanks for your patches and ebuild, and sorry for the late delay.
> I've added a bumped ebuild (0.8.0_p3) to my personal overlay (ikelos).
> 
> Please be careful when posting ebuilds, yours include
> >=xorg-server-1.4.0.90-r3 (not -r4), which nearly made me just bump
> the old ebuild.  Disabling quirks mode in 1.4.0.90-r3 really breaks
> things (no coarse control, the mouse jumps 10 pixels a move),

Hey -- Sorry. In my personal tree, I have Magnus's rescaling patch in
xorg-server-1.4.0.90-r3.

> and doing it in -r4 just breaks them a little (no fine grained
> control, just two or three pixels a move).  So for the time being I've
> added a USE flag called quirks which is on by default.

This is strange. -r4 has the rescaling patch, and a few other things,
and it works great for me! If you look at the linuxwacom configure
script, they automatically disable quirk rescaling for recent versions
of xorg-server (can't remember the exact version number). So once Gentoo
upgrades to a high version of xorg-server, this won't be an issue
anymore.

GI
Comment 8 Mike Auty (RETIRED) gentoo-dev 2008-05-25 11:01:47 UTC
Ok,

I found that even with quirks mode and xorg-server-1.4.0.90-r4, swapping to a game such as enemy-territory, the mouse tended to wander up and to the left on slow movements (which is an issue I'd seen previously on a normal desktop back when xorg-server-1.4 first came out) so I'm a bit worried about the upgrade when it happens.  Anyway, we'll have to see how it works when the time comes I guess...  5:)

Out of interest, could you tell me which patch in /usr/portage/x11-base/xorg-server/files/1.4.0.90 is the rescaling one?  I couldn't see it immediately with a quick browse through.  Thanks!  5:)

Comment 9 Gautam Iyer 2008-05-26 01:58:42 UTC
(In reply to comment #8)

> Out of interest, could you tell me which patch in
> /usr/portage/x11-base/xorg-server/files/1.4.0.90 is the rescaling one?  I
> couldn't see it immediately with a quick browse through.

They're in the files/1.4.0.90 directory. The names are the same as the git names. (The five relevant for the rescaling are listed in bug 214233).

The basic problem was that in 1.4, they decided to limit the resolution of input devices to that of the screen. This caused *terrible* performance with tablets. Magnus patched xorg-server to get high resolution input devices, and pestered the xorg devs to get this included into master. If you're curious, you can see the resolution upstream: http://bugs.freedesktop.org/show_bug.cgi?id=10324

When 1.4 was released, linuxwacom added "quirk rescaling" to conform to xorgs specifications. After Magnus's patch was accepted, quirk rescaling is no longer needed, and linuxwacom's configure script automatically disables it for recent xorg-servers. (I might have posted already, but see attachment 146971 [details] in bug 214233 if you want to see what it looks like with quirk rescaling)

GI
Comment 10 Mike Auty (RETIRED) gentoo-dev 2009-04-11 13:15:37 UTC
I'm pretty sure this is fixed in the latest ebuilds (0.8.2 and 0.8.2_p2), so I'm going to mark this as FIXED.  Please feel free to reopen this (or ask to have this reopened if you can't) if anyone is still having problems...