Bugzilla Bug 217989

The tap-cleanup patch from bug #209055 is missing a space between the ifconfig
command and the device name. This causes a failure to execute the ifconfig
command and causes the OpenVPN instance to shut down. It affects OpenVPN when
not using the iproute2 USE flag and is fatal when used in client or p2p mode
when ping-restart is in effect as the server cannot restart.

The patch provided for bug #209055 is missing a space after the string
concatenation involving IFCONFIG_PATH. I will include a corrected version of
the patch from bug #209055 that corrects this problem (see next comment for
patch file.)

This is what happens when using p2p (or client) mode with ping-restart:

Tue Apr 15 01:12:51 2008 [test_server] Inactivity timeout (--ping-restart),
restarting
Tue Apr 15 01:12:51 2008 TCP/UDP: Closing socket
Tue Apr 15 01:12:51 2008 /etc/openvpn/down.sh tun0 1500 1542 10.0.0.1 10.0.0.0
init
Tue Apr 15 01:12:52 2008 Closing TUN/TAP interface
Tue Apr 15 01:12:52 2008 /sbin/ifconfigtun0 addr 0.0.0.0
sh: /sbin/ifconfigtun0: No such file or directory
Tue Apr 15 01:12:52 2008 Linux ip addr del failed: could not execute shell
command
Tue Apr 15 01:12:52 2008 Exiting

Obviously the command should be "/sbin/ifconfig tun0 addr 0.0.0.0" and not
/sbin/ifconfigtun0. See the patch with the next comment for an updated version
of the Gentoo tap patch that corrects this problem by adding the needed space.

Created an attachment (id=149965) [details]
fixed tap-cleanup patch

This patch fixes the shell command problem with the original bug #209055
tap-cleanup.patch file.

*** This bug has been marked as a duplicate of bug 217956 ***