First Last Prev Next    No search results available      Search page      Enter new bug
Bug#: 202685
Alias:
Product:
Component:
Status: RESOLVED
Resolution: FIXED
Assigned To: Markus Dittrich <markusle@gentoo.org>
Hardware:
OS:
Version:
Priority:
Severity:
Reporter: Oliver Borm <oli.borm@web.de>
Add CC:
CC:
Remove selected CCs
URL:
Summary:
Status Whiteboard:
Keywords:

Filename Description Type Creator Created Size Actions
ParaViewReaders-3.2.1.patch OpenFOAM Reader patch patch Oliver Borm 2007-12-18 12:13 0000 443 bytes Details | Diff
OpenFOAMReader-3.2.1.patch Patch for the OpenFOAM Reader patch Oliver Borm 2007-12-18 12:13 0000 252.10 KB Details | Diff
Create a New Attachment (proposed patch, testcase, etc.) View All

Bug 202685 depends on: Show dependency tree
Bug 202685 blocks:
Votes: 0    Show votes for this bug    Vote for this bug

Additional Comments: (this is where you put emerge --info)


Not eligible to see or edit group visibility for this bug.






View Bug Activity   |   Format For Printing   |   XML   |   Clone This Bug


Description:   Opened: 2007-12-18 12:12 0000
Since the update to version 3.2.1 of Paraview I'm not able to use the native
OpenFOAM Readers in Paraview. So please add the patches to the ebuild.
Thank's!

Reproducible: Always

------- Comment #1 From Oliver Borm 2007-12-18 12:13:03 0000 -------
Created an attachment (id=138810) [details]
OpenFOAM Reader patch

To activate the build in capabilities of Paraview for OpenFOAM Files, this
patch is needed at compile time. Maybe this can be activated with an USE Flag,
so that my ebuild from bug 104257 has an postprocessing tool. The built-in
capabilities of Paraview were selected as default in version 2.6.2.

------- Comment #2 From Oliver Borm 2007-12-18 12:13:56 0000 -------
Created an attachment (id=138812) [details]
Patch for the OpenFOAM Reader

This patch improves the built-in capabilities from Paraview for the OpenFOAM
Datastructure very much. I would highly recommend to add this patch to the
ebuild, if the openfoam support is compiled with.

------- Comment #3 From Markus Dittrich 2007-12-19 15:08:30 0000 -------
Hi Oliver,

Thanks much for your patches and I'll try to have a look at them 
as soon as I find some time.

Best,
Markus

------- Comment #4 From Daniel Tourde 2007-12-19 15:12:47 0000 -------
Markus,

In the meantime are you aware that Oliver put an ebuild for OpenFoam on the
sunrise overlay? I used the ebuild and it built the beast (and the beast seems
to be alive and kicking...)... Maybe time to try to include OpenFoam to the
main gentoo tree...

Daniel

------- Comment #5 From Markus Dittrich 2007-12-19 15:25:06 0000 -------
Hi Daniel,

I am aware of it, but haven't had time to even look at it yet :(
As soon as I find some time ..... I'll have a closer look.

cheers,
Markus

------- Comment #6 From Markus Dittrich 2008-01-04 11:25:07 0000 -------
Hi Oliver,

I just had some time to look at your patches. 
Since they are quite extensive, would you be
able to comment on where they come from.
It almost seems to me that this is something
that should be reviewed and merged by upstream
rather than by us.

Best,
Markus

------- Comment #7 From Oliver Borm 2008-01-04 11:52:47 0000 -------
Hello Markus,

this patches came from the OpenFOAM Mailing list:
http://openfoam.cfd-online.com/cgi-bin/forum/show.cgi?tpc=1&post=17466#POST17466

and since the post from yesterday, it seems that these patches were sent
upstream but are not yet in the CVS. I fully agree with you, that these patches
should be merged into the official tree. Nevertheless, I would highly recommend
to use these patches in version 3.2.1 of the paraview ebuild and I hope we
don't need these patches in further versions of paraview.

Oliver

------- Comment #8 From Markus Dittrich 2008-01-05 16:24:38 0000 -------
Hi Oliver,

Thanks much for the link! This indeed looks like a solid
patch hence it should be fine as part of our paraview ebuild
until upstream merges it into their trunk.

I've added it to the pareview-3.2.1 ebuild and it should
have hit the mirrors by now. You'll need to re-sync and 
re-emerge paraview to pull it in.

Lacking any OpenFOAM dataset I have not yet tested it
but the option is there. Please give it a spin and let me know
if it works as expected.

Thanks,
Markus

------- Comment #9 From Daniel Tourde 2008-01-05 19:51:13 0000 -------
Markus,

Are you sure you put the patch in the gentoo tree?
When I emerged, I got the new ebuild but not the patch...

Daniel

------- Comment #10 From Markus Dittrich 2008-01-06 11:21:25 0000 -------
Daniel,

The patch is on the mirrors not in the files/ directory
due to its size (patches in files/ should be < 30k 
uncompressed). Just look for the line

epatch "${DISTDIR}"/${P}-OpenFOAM.patch.bz2

in the ebuild.

best,
Markus

------- Comment #11 From Oliver Borm 2008-01-14 23:32:59 0000 -------
Hello Markus,

I have had a quick look on the new paraview and it seems to work as expected.
So I think we can close this bug.

Oliver

BTW: Why don't you call the new ebuild not paraview-3.2.1-r1 or something like
that?

------- Comment #12 From Markus Dittrich 2008-01-15 13:56:14 0000 -------
The present version works just fine for everybody
not caring about OpenFOAM. Hence, there is no reason
to force a multi-hour compile onto people for a feature
they most likely don't care about. An -r1 in this case
would be a real bug fix/enhancement that matters for
a significant fraction of people. If paraview would
compile in 5 minutes this would have been a
different story.

Best,
Markus

First Last Prev Next    No search results available      Search page      Enter new bug