Bug List: (This bug is not in your last search results)   Show last search results      Search page      Enter new bug
Bug#: 190981
Alias:
Product:
Component:
Status: CLOSED
Resolution: INVALID
Assigned To: SpanKY <vapier@gentoo.org>
Hardware:
OS:
Version:
Priority:
Severity:
Reporter: Jakub Moc (RETIRED) <jakub@gentoo.org>
Add CC:
CC:
Remove selected CCs
URL:
Summary:
Status Whiteboard:
Keywords:

Filename Description Type Creator Created Size Actions
Create a New Attachment (proposed patch, testcase, etc.) View All

Bug 190981 depends on: Show dependency tree
Bug 190981 blocks:
Votes: 0    Show votes for this bug    Vote for this bug

Additional Comments: (this is where you put emerge --info)


Not eligible to see or edit group visibility for this bug.




View Bug Activity   |   Format For Printing   |   XML   |   Clone This Bug


Description:   Opened: 2007-09-01 17:48 0000
<snip>
/usr/portage/eclass/php-ext-pecl-r1.eclass:27: PHP_EXT_PECL_PKG: unable to
extract default variable content: 
/usr/portage/eclass/php-ext-pecl-r1.eclass:36: PHP_EXT_PECL_FILENAME: unable to
extract default variable content: 
/usr/portage/eclass/php-ext-pecl-r1.eclass:40: DOCS: unable to extract default
variable content: 
</snip>

What's this trying to say? Sorry but I don't grok it. The eclasses are in CVS
now, could you tell me what's it moaning about?

----

</snip>
/usr/portage/eclass/java-ant-2.eclass:26: Unexpected tag in "header" state: #
@variable-preinherit WANT_ANT_TASKS
/usr/portage/eclass/java-ant-2.eclass:27: Unexpected tag in "header" state: #
@variable-default ""
/usr/portage/eclass/java-ant-2.eclass:33: Unexpected tag in "header" state: #
@variable-preinherit WANT_SPLIT_ANT
/usr/portage/eclass/java-ant-2.eclass:34: Unexpected tag in "header" state: #
@variable-default ""
/usr/portage/eclass/java-ant-2.eclass:43: Unexpected tag in "header" state: #
@variable-preinherit JAVA_ANT_DISABLE_ANT_CORE_DEP
/usr/portage/eclass/java-ant-2.eclass:44: Unexpected tag in "header" state: #
@variable-default unset for java-pkg-2, true for java-pkg-opt-2
/usr/portage/eclass/java-ant-2.eclass:83: Unexpected tag in "header" state: #
@global JAVA_PKG_BSFIX
/usr/portage/eclass/java-ant-2.eclass:93: Unexpected tag in "header" state: #
@global JAVA_PKG_BSFIX_ALL
/usr/portage/eclass/java-ant-2.eclass:102: Unexpected tag in "header" state: #
@global JAVA_PKG_BSFIX_NAME
/usr/portage/eclass/java-ant-2.eclass:111: Unexpected tag in "header" state: #
@global JAVA_PKG_BSFIX_TARGETS_TAGS
/usr/portage/eclass/java-ant-2.eclass:120: Unexpected tag in "header" state: #
@global JAVA_PKG_BSFIX_SOURCE_TAGS
/usr/portage/eclass/java-ant-2.eclass:129: Unexpected tag in "header" state: #
@global JAVA_ANT_IGNORE_SYSTEM_CLASSES
/usr/portage/eclass/java-ant-2.eclass:137: Unexpected tag in "header" state: #
@private java-ant_bsfix

...
</snip>

$ grep @ECLASS /usr/portage/eclass/java-ant-2.eclass
$

Why's it even trying to parse this, flooding people with bogus warnings?

------- Comment #1 From SpanKY 2007-09-01 17:51:10 0000 -------
there are no bogus warnings ... the awk tries to extract the default value to
display it in the manpage but the way you've written the eclass prevents that
from happeneing

------- Comment #2 From Jakub Moc (RETIRED) 2007-09-01 17:53:31 0000 -------
OMG, are you joking or what? *What's* preventing the eclass from being parsed?
What kind of default value? Could you finally answer that simple question? 

And why is it parsing eclasses it should NOT parse at all since there's no
@ECLASS at all in the first place?

------- Comment #3 From SpanKY 2007-09-01 17:56:37 0000 -------
comment blocks are supposed to appear before the default variable setting so
that the default value can be extracted and displayed

if it doesnt, you get a warning, and the manpage does not display the default
value

------- Comment #4 From Jakub Moc (RETIRED) 2007-09-01 18:06:29 0000 -------
(In reply to comment #3)
> comment blocks are supposed to appear before the default variable setting so
> that the default value can be extracted and displayed
> 
> if it doesnt, you get a warning, and the manpage does not display the default
> value

Please, don't try to do impossible things in the script. If there's a default
value, it's up to the eclass to document if desired, instead of performing
broken black magic somehow via the awk script.

Now, what's the thing with trying to parse java-ant-2.eclass,
java-utils-2.eclass, java-vm-2.eclass, webapp.eclass? This script's acting like
a bull seeing a red cloth whenever it hits @ character.

------- Comment #5 From SpanKY 2007-09-01 18:11:30 0000 -------
if you dont want your var documented, then ignore the warning

------- Comment #6 From Jakub Moc (RETIRED) 2007-09-01 18:18:16 0000 -------
(In reply to comment #5)
> if you dont want your var documented, then ignore the warning

Apparently asking two questions at a time doesn't work... let's try again then:

<snip>
What's the thing with trying to parse java-ant-2.eclass,
java-utils-2.eclass, java-vm-2.eclass, webapp.eclass? This script's acting like
a bull seeing a red cloth whenever it hits @ character.
</snip>

The script fails to ignore eclasses that have no @ECLASS tag there, spewing the
users with hundreds of irrelevant warnings. Can we get this fixed please?

------- Comment #7 From SpanKY 2007-09-01 18:30:48 0000 -------
fix the eclass

------- Comment #8 From Jakub Moc (RETIRED) 2007-09-01 18:49:01 0000 -------
(In reply to comment #7)
> fix the eclass

Yeah, clearly asking for the script to behave consistently and ignore eclasses
unless it contains "@ECLASS: " (and exactly that, with exactly that case and
nothing else containing any substrings of that) is mission impossible. Even if
the java eclasses get "fixed", the script will still be broken because
webapp.eclass doesn't contain any @ECLASS variant at all, yet it causes the
same issue, because it contains other things with @ which trigger the awk
script misbehaviour. 

I might suggest that people should think about design before writing up
something, as @ apparently plain sucks as a tag (a quick grep through the
existing eclasses would have shown this at the very beginning) - but at this
point I plain don't care enough any more, wasted enough time on this broken
script that's spamming users with junk.

Bug List: (This bug is not in your last search results)   Show last search results      Search page      Enter new bug