Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 183043 - gnome-extra/gnome-color-chooser, app for customising gnome color schemes
Summary: gnome-extra/gnome-color-chooser, app for customising gnome color schemes
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All All
: Low enhancement (vote)
Assignee: Diego Elio Pettenò (RETIRED)
URL:
Whiteboard:
Keywords: EBUILD
Depends on:
Blocks:
 
Reported: 2007-06-24 12:33 UTC by Bartek Kostrzewa
Modified: 2009-03-10 22:58 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
gnome-extra/gnome-color-chooser-0.2.1.ebuild (gnome-color-chooser-0.2.1.ebuild,583 bytes, text/plain)
2007-06-24 12:36 UTC, Bartek Kostrzewa
Details
ebuild (gnome-color-chooser-0.2.3.ebuild,629 bytes, text/plain)
2008-02-14 19:24 UTC, Todd Partridge
Details
ebuild (gnome-color-chooser-0.2.4.ebuild,816 bytes, text/plain)
2008-10-26 02:58 UTC, stupendoussteve
Details
ebuild (gnome-color-chooser-0.2.4.ebuild,817 bytes, text/plain)
2008-10-26 03:08 UTC, stupendoussteve
Details
updated ebuild (gnome-color-chooser-0.2.4.ebuild,1.07 KB, text/plain)
2008-12-28 02:41 UTC, stupendoussteve
Details
ebuild manifest (Manifest,423 bytes, text/plain)
2008-12-28 02:46 UTC, stupendoussteve
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Bartek Kostrzewa 2007-06-24 12:33:34 UTC
gnome-color-chooser provides functionality that should have been part of the gnome standard configuration capplets but never materialised

Reproducible: Always
Comment 1 Bartek Kostrzewa 2007-06-24 12:36:13 UTC
Created attachment 122967 [details]
gnome-extra/gnome-color-chooser-0.2.1.ebuild

ebuild for gnome-color-chooser version 0.2.1
Comment 2 Todd Partridge 2008-02-14 19:24:48 UTC
Created attachment 143523 [details]
ebuild 

Website new and had to change the download site.
Comment 3 Gilles Dartiguelongue (RETIRED) gentoo-dev 2008-06-29 20:17:50 UTC
review of ebuild in comment #2,

use emake DESTDIR="${D}" install instead of einstall unless you have a specific reason.

Don't use ./configure but use econf. If you just need econf/emake, you might want to just remove src_compile to get the default one which does that already.

Also gettext should be in DEPEND while all other deps should be in RDEPEND and it seems homepage is http://gnomecc.sourceforge.net/ now.
Comment 4 stupendoussteve 2008-10-26 02:58:26 UTC
Created attachment 169897 [details]
ebuild

Cleaned up ebuild, works fine for me install, updating and removing. Also version bump.
Comment 5 stupendoussteve 2008-10-26 03:06:19 UTC
Comment on attachment 169897 [details]
ebuild

><HTML><HEAD/><BODY><PRE># Copyright 1999-2008 Gentoo Foundation
># Distributed under the terms of the GNU General Public License v2
>
>
>DESCRIPTION="GTK+/GNOME color customization tool."
>HOMEPAGE="http://gnomecc.sourceforge.net/"
>SRC_URI="mirror://sourceforge/gnomecc/${P}.tar.bz2"
>
>LICENSE="GPL-3"
>SLOT="0"
>KEYWORDS="~amd64 ~ppc ~x86"
>
>DEPEND="sys-devel/gettext"
>
>RDEPEND="dev-cpp/gtkmm
>	dev-cpp/libglademm
>	dev-cpp/libgnomemm
>	dev-cpp/libgnomeuimm
>	dev-libs/libxml2"
>
>src_unpack() {
>    if [ "${A}" != "" ]; then
>        unpack ${A}
>    fi
>}
>
>src_compile() {
>    if [ -x ./configure ]; then
>        econf --prefix=/usr
>    fi
>    if [ -f Makefile ] || [ -f GNUmakefile ] || [ -f makefile ]; then
>        emake || die "emake failed"
>    fi
>}
>
>src_install() {
>    emake DESTDIR="${D}" install || die "Install failed"
>    dodoc README || die
>}
>
></PRE></BODY></HTML>
Comment 6 stupendoussteve 2008-10-26 03:08:34 UTC
Created attachment 169898 [details]
ebuild

Please disregard the junk I happened to put in above, I was attempting to edit the description to better match the official explanation, as this application is not only for gnome.

Also, other changes I made before were updating the license to GPLv3, as the site says they use, and updating the homepage.
Comment 7 Gilles Dartiguelongue (RETIRED) gentoo-dev 2008-11-30 11:15:42 UTC
align ebuild requests to same values
Comment 8 stupendoussteve 2008-12-28 02:41:11 UTC
Created attachment 176557 [details]
updated ebuild

Modified the dependencies, to match what is listed in the build file (not all of them are dev libs, some are just gnome libs - since they're pulled in by gnome it wasn't noticed). Also moved them back to DEPEND, as the configure script will fail if they are not installed, thus they are not just runtime. DEPEND is echoed into RDEPEND for those installing a binary.

Also added an einfo about adding an include in .gtkrc-2.0 pointing to gnome-color-changer's gtkrc file, as apparently this isn't (always?) done automatically, so themes will not apply. I have asked about it on the gnomecc forum, I believe some of the stable dependencies may be newer than that part of the program supports.
Comment 9 stupendoussteve 2008-12-28 02:46:54 UTC
Created attachment 176560 [details]
ebuild manifest
Comment 10 Jan Drábek 2009-01-20 15:31:25 UTC
Works good on my computer, can someone put it to portage tree?
Comment 11 Diego Elio Pettenò (RETIRED) gentoo-dev 2009-03-10 22:12:52 UTC
The Manifest is unneeded in a ebuild request bug, and the ebuild should not reimplement src_unpack and src_compile given it uses the defaults. Also most likely pkg-config dependency is missing. But since I'm actually interested in this package I might just pick it up ^^;
Comment 12 Diego Elio Pettenò (RETIRED) gentoo-dev 2009-03-10 22:58:40 UTC
In tree! :) Thanks Steven.

If you want them keyworded ~x86, please open a keywording bug since I only do ~amd64 (ironically, my tinderbox does not pick up my own ebuilds for that ;)).