Bugzilla Bug 182652

app-shells/zsh-4.3.4 requires libpcre libraries to be built with PIC on AMD64,
this patch enables this. Its probably worth checking if this is an
AMD64-specific thing or is required on other arches as well

Created an attachment (id=122582) [details]
patch to build libraries with dPIC

*** Bug 182534 has been marked as a duplicate of this bug. ***

(In reply to comment #1)
> Created an attachment (id=122582) [edit] [details]
> patch to build libraries with dPIC
> 

Please submit your patch upstream and attach the url here.

I have contacted upstream, and he recommends applying the patch in the ebuild,
as adding -fPIC in the Makefile is not portable and not needed on most
platforms. Also, PCRE-7.2 has just been released, so any patches won't get into
official releases for some time. The patch in the ebuild applies successfully
to libpcre-7.1 and 7.2

Carlo, any news on this? Upstream's statement is plain wrong, -fPIC may not be
needed on all archs, but libpcre-7 is in it's current state broken and unusable
on amd64

Forgot to close here, patch is commited.

err, wait ... i think there's some confusion floating around here leading to
broken ebuilds

first off, you cant just go patching Makefile.am files without running
autotools (which is exactly what's happening now)

second, upstream is correct in saying -fPIC is not portable because it isnt ...
that's the entire point of using libtool in the first place -- it handles the
details of how to build PIC shared objects

third, libtool should be doing the right thing *internally* when it encounters
libfoo_la_... defines in Makefile's -- it generates libfoo.a w/out PIC and then
it generates libfoo.so w/PIC

finally, where's the actual errors ?  zsh build fails for me *because zsh is
broken*, not because of libpcre ... it forces libpcre to be linked statically
into a shared object

(In reply to comment #7)
> second, upstream is correct in saying -fPIC is not portable because it isnt ...
I was talking about the need of -fPIC, but well, seems like that was wrong
anyways

> finally, where's the actual errors ?  zsh build fails for me *because zsh is
> broken*, not because of libpcre ... it forces libpcre to be linked statically
> into a shared object
the error is in zsh's own bug (bug 182534), since - like you said - this is a
bug in zsh's ebuild I'll close this bug here, zsh already has its own