Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 182622 - x11-drivers/nvidia-drivers request for nvidia-settings USE flag
Summary: x11-drivers/nvidia-drivers request for nvidia-settings USE flag
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: X11 External Driver Maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-06-19 22:59 UTC by adriancz
Modified: 2007-07-12 21:33 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
nvidia-drivers-100.14.11.ebuild (nvidia-drivers-100.14.11.ebuild,14.10 KB, text/plain)
2007-06-24 07:08 UTC, Paul Bredbury
Details
nvidia-drivers-100.14.11.ebuild (nvidia-drivers-100.14.11.ebuild,14.12 KB, text/plain)
2007-06-24 10:49 UTC, Paul Bredbury
Details

Note You need to log in before you can comment on or make changes to this bug.
Description adriancz 2007-06-19 22:59:23 UTC
nvidia-drivers-100.14.09 installs nvidia-settings that is not needed by many people.


Reproducible: Always

Steps to Reproduce:
Comment 1 felix 2007-06-20 00:01:38 UTC
i tried this drivers and they works too bad :( with 9755 drivers i get 26000 FPS, but with 100.14.09 i only get 17000...
Comment 2 Paul Bredbury 2007-06-23 10:13:18 UTC
See bug #176135 comment #7 as a good reason for *including* nvidia-settings. Another good reason is that it's a very useful utility.

Making nvidia-settings optional via a USE flag will just cause bug reports from people complaining that it's "missing".

I don't see why it's worth adding such a USE flag.
Comment 3 Nikola Goranov 2007-06-23 10:50:00 UTC
(In reply to comment #2)
> Making nvidia-settings optional via a USE flag will just cause bug reports from
> people complaining that it's "missing".
> 
> I don't see why it's worth adding such a USE flag.

This wouldn't happen if you just enable it by default. Only those who don't want it will disable it through package.use and everybody is happy, right?
Comment 4 Paul Bredbury 2007-06-23 11:55:20 UTC
(In reply to comment #3)
> enable it by default.

Which means adding it to the profiles, to be elegant.

But, what's missing from this bug report is a *good* reason why such a USE flag is worth the effort.
Comment 5 adriancz 2007-06-23 13:27:51 UTC
> But, what's missing from this bug report is a *good* reason why such a USE flag
> is worth the effort.
> 

1) There are people who don't need it. Gentoo is about choice, so more options are welcome.
2) It depends on GTK2, believe me that there are people who don't like it.
3) There is better (IMHO) tool to adjust settings of nvidia driver available, it's nvclock.


Comment 6 Chris Gianelloni (RETIRED) gentoo-dev 2007-06-23 13:46:31 UTC
I'm really on the fence with this one.  I can feel for having the ability to
not install something that is really optional, but it is so damn useful (and
not terribly large) that one could also argue for simply always including it,
as was done here.  I don't really care either way, as I can see positive
aspects of both.  Perhaps, rather than using USE="nvidia-settings" (I always
hate long USE flag names) to control this behavior, we use USE="gtk" instead. 
Since nvidia-settings requires GTK+ and the drivers themselves do not, this
seems to be a decent compromise, as gtk is already in default USE pretty much
everywhere, but it could still be turned off by users who wished.

Thoughts?  Ideas?  Tomatoes?  Cardoe?

Also, remember that Gentoo isn't about choice just for the sake of choice, we're about choice where it makes sense to empower the user to make their own decision.  Try to think empowerment, rather than choice.  We want to give the user everything that they need to run things how they want, even if how they want is different from how "we" want it.
Comment 7 adriancz 2007-06-23 14:08:11 UTC
(In reply to comment #6)
>Perhaps, rather than using USE="nvidia-settings" (I always
> hate long USE flag names) to control this behavior, we use USE="gtk" instead. 
> Since nvidia-settings requires GTK+ and the drivers themselves do not, this
> seems to be a decent compromise, as gtk is already in default USE pretty much
> everywhere, but it could still be turned off by users who wished.

I like this idea. I'd be even better to have USE="gtk" instead of lengthy USE="nvidia-settings".
Comment 8 Paul Bredbury 2007-06-24 07:08:45 UTC
Created attachment 122946 [details]
nvidia-drivers-100.14.11.ebuild

Ebuild to make nvidia-settings optional.
Comment 9 adriancz 2007-06-24 10:32:24 UTC
(In reply to comment #8)
> Created an attachment (id=122946) [edit]
> nvidia-drivers-100.14.11.ebuild
> 
> Ebuild to make nvidia-settings optional.
> 

nvidia-settings isn't downloaded when you have "-gtk", but

	unpack "nvidia-settings-${SETTINGS_V}.tar.gz"
	cd "${SETTINGS_DIR}" || die
	sed -i.orig \
		-e 's,DoNormalLib NormalLibXrandr,DoNormalLib YES,g' \
		src/libXNVCtrl/Imakefile || die "sed Imakefile

executes always. If you make this code conditional it will work, I checked :)

Thank you.
Comment 10 Paul Bredbury 2007-06-24 10:49:28 UTC
Created attachment 122958 [details]
nvidia-drivers-100.14.11.ebuild

Fixed.
Comment 11 adriancz 2007-06-25 18:46:47 UTC
(In reply to comment #10)
> Created an attachment (id=122958) [edit]
> nvidia-drivers-100.14.11.ebuild
> 
> Fixed.
> 

Works for me, thx. Will it be included in portage tree?
Comment 12 Doug Goldstein (RETIRED) gentoo-dev 2007-07-12 16:32:46 UTC
much easier to handle changes when you provide a diff rather then posting the whole ebuild. A lot has changed in the in tree ebuild since you made this one so it's taken me a while to wade through all the changes to figure out what needs to change.
Comment 13 Doug Goldstein (RETIRED) gentoo-dev 2007-07-12 16:39:51 UTC
Fixed in 100.14.11.
Comment 14 Paul Bredbury 2007-07-12 21:25:24 UTC
No, look at my ebuild. Notice how things are *quoted*, so that it doesn't screw up if a directory contains a space.
Comment 15 Doug Goldstein (RETIRED) gentoo-dev 2007-07-12 21:33:43 UTC
As I previously stated, I won't read through entire ebuilds. Provide diffs.

Either way, the proper places are quoted in the current ebuilds. There is an over zealous use of quoting in the copy you provided... /usr/lib/ does not need to be quoted. If you have a space in /usr/lib, you have more issues then an nvidia driver pkg.