Bugzilla Bug 180530

I received the following mail from my monthly cron:

Subject: Cron <root@machine> test -x /usr/sbin/run-crons && /usr/sbin/run-crons

which: no curl in (/sbin:/bin:/usr/sbin:/usr/bin)
--05:30:01--  http://pciids.sourceforge.net/v2.2/pci.ids.bz2
           => `/usr/share/misc/pci.ids.new'
Resolving pciids.sourceforge.net... 66.35.250.209
Connecting to pciids.sourceforge.net|66.35.250.209|:80... connected.
HTTP request sent, awaiting response... 200 OK
Length: 121,280 (118K) [text/plain]

    0K .......... .......... .......... .......... .......... 42% 8.14M      
   50K .......... .......... .......... .......... .......... 84% 9.77M      
  100K .......... ........                                   100% 18.0M      

05:30:01 (9.11 MB/s) - `/usr/share/misc/pci.ids.new' saved [121280/121280]

Done.

I assumed the reason I received the error from the successful download is
because of the curl error (I don't have curl installed)

So I checked the monthly cron /etc/cron.monthly/update-pciids and I saw that it
runs /usr/sbin/update-pciids -q, so I went to /usr/sbin/update-pciids and saw
the following in line 17: 
if which curl >/dev/null ; then

Which I assume will result in an error if curl doesn't exist, and output will
go to stderr and not /dev/null because there isn't a 2>&1.

The same is true for all the which's in this script: bzip2, gzip, curl, wget,
lynx and needs an 2>&1 added IMHO.

I "fixed" the bug by emerging curl ;)

For your consideration...

-- Shimi

*** This bug has been marked as a duplicate of bug 164800 ***