Bugzilla Bug 180187

This is a platform game where you must reach switches that, once activated,
rotate the level. This is another game from PyWeek.

I wrote this ebuild based on games-strategy/lightyears.

It depends on >=dev-python/pygame-1.6.2. It will probably work on 1.6 version
too, but I haven't bothered to test it because 1.6.2 is already stable.

I've tested it on x86 (Pentium III). It should work on amd64 too (it's python,
after all), but haven't tested.

Created an attachment (id=120584) [details]
whichwayisup-0.7.0.ebuild - proposed ebuild

I've tested this with pygame-1.5 (did not work), pygame-1.6.2 (worked) and
pygame-1.7.1 (worked).

It byte-compiles all python files before installing them. It also installs 3
sizes for the program icon (all of them are PNG files extracted from one ICO
file, and then optimized by pngcrush -brute).

Created an attachment (id=120587) [details]
whichwayisup-0.7.0-gentoo.patch

Patch to make the game look for its files at correct directories. Based on
similar patch from games-strategy/lightyears.

Created an attachment (id=120589) [details]
Program icons

Contains three files:
 whichwayisup-32.png
 whichwayisup-48.png
 whichwayisup-64.png

Created an attachment (id=120591) [details]
whichwayisup-0.7.0.ebuild

Just a small change, nothing big.

Created an attachment (id=120596) [details]
whichwayisup-0.7.0.ebuild

marienz told me at #gentoo-dev-help to not call python_mod_optimize from
src_compile. So this is the updated ebuild with proper pkg_postinst() and
pkg_postrm().

Thanks for the ebuild. It works fine on x86.

You may want to commit it to Sunrise Overlau at
http://overlays.gentoo.org/proj/sunrise/wiki (if you're not in the mood I'll do
it for you ;-)

(In reply to comment #6)
> You may want to commit it to Sunrise Overlau
>(if you're not in the mood I'll do it for you ;-)

Do it for me, please. :)
And let's wait until this hits main portage tree.

In bug #180191, I asked that games-strategy/lightyears ebuild should
byte-compile python sources. The maintainers have already fixed that. See the
diff here:

http://sources.gentoo.org/viewcvs.py/gentoo-x86/games-strategy/lightyears/lightyears-1.2a.ebuild?r1=1.3&r2=1.4

They added one thing that I had forgotten in my ebuild: a call to
games_pkg_postinst function. So, remember to add it to pkg_postinst() function.

Created an attachment (id=120691) [details]
whichwayisup-0.7.0.ebuild

Ok, in addition to "games_pkg_postinst" I did some cleanup: removed
python_version calls (python_mod_{optimize,cleanup} call it for you), use
NEED_PYTHON, removed the patch since there's no point on having a patch and a
sed'ing for the same thing (or I don't see it), and some cosmetic stuff.


Comitted to Sunrise, it will be available soon here:
http://overlays.gentoo.org/svn/proj/sunrise/reviewed/games-arcade/whichwayisup/
(and, of course, via layman)

(In reply to comment #9)
> Ok, in addition to "games_pkg_postinst" I did some cleanup:
> removed python_version calls (python_mod_{optimize,cleanup} call it for you)
Ok. Didn't know that. Thanks.

> use NEED_PYTHON, 
> removed the patch since there's no point on having a patch and a
> sed'ing for the same thing (or I don't see it)
Huh... would the same argument apply to games-strategy/lightyears ebuild?
Because I do exactly the same as that ebuild. Maybe you should take a look at
that ebuild and modify it too.

(In reply to comment #10)
> Huh... would the same argument apply to games-strategy/lightyears ebuild?
> Because I do exactly the same as that ebuild. Maybe you should take a look at
> that ebuild and modify it too.
> 

I would do it If I were developer but I don't ;-). Those are my suggestions but
I could be wrong, or maybe it's not so important and both solutions are fine. 

Looks like this game has been added to Debian repositories. See this:
http://hectigo.net/puskutraktori/whichwayisup/news.php#071
I noticed the ebuild must be updated to contain two licenses: GPL-2.0 and
CC-3.0

Added to the tree. Thanks for the ebuild!