Bug 177142 – xen-sources 2.6.16.49 build failure when iptables REJECT target is set

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description R. Welz 2007-05-05 09:57:08 UTC]

If REJECT Target for iptables is set, build fails with
net/ipv4/netfilter/ipt_REJECT.c: In function `send_reset':
net/ipv4/netfilter/ipt_REJECT.c:162: Fehler: structure hat kein Element namens »tso_size«
net/ipv4/netfilter/ipt_REJECT.c:163: Fehler: structure hat kein Element namens »tso_segs«
make[3]: *** [net/ipv4/netfilter/ipt_REJECT.o] Fehler 1
make[2]: *** [net/ipv4/netfilter] Fehler 2
make[1]: *** [net/ipv4] Fehler 2
make: *** [net] Fehler 2

Reproducible: Always

Steps to Reproduce:
1. make-menuconfig choose iptables and REJECT target
2. make
3.

Actual Results:  
net/ipv4/netfilter/ipt_REJECT.c: In function `send_reset':
net/ipv4/netfilter/ipt_REJECT.c:162: Fehler: structure hat kein Element namens »tso_size«
net/ipv4/netfilter/ipt_REJECT.c:163: Fehler: structure hat kein Element namens »tso_segs«
make[3]: *** [net/ipv4/netfilter/ipt_REJECT.o] Fehler 1
make[2]: *** [net/ipv4/netfilter] Fehler 2
make[1]: *** [net/ipv4] Fehler 2
make: *** [net] Fehler 2


Solution:

In line 162 and 163 of file net/ipv4/netfilter/ipt_REJECT.c
change:
skb_shinfo(nskb)->tso_size = 0;
skb_shinfo(nskb)->tso_segs = 0;

to:
skb_shinfo(nskb)->gso_size = 0;
skb_shinfo(nskb)->gso_segs = 0;

That works ;)

[Comment 1 Bogdan Lipski 2007-05-06 20:10:03 UTC]

i was just about to log it, had the same struggle yesterday evening. I found the note somewhere that tso_size/tso_segs has been replaced  by gso_size/gso_segs, so my solution was essentially the same, although did not test if using REJECT actually works after that ;-)
btw. compilation of xen kernel fails as well when sctp is enabled 

[Comment 2 Micheal Marineau (RETIRED) 2007-05-16 21:50:20 UTC]

*** Bug 178286 has been marked as a duplicate of this bug. ***

[Comment 3 Micheal Marineau (RETIRED) 2007-07-10 20:03:02 UTC]

The patch to fix the ipt_REJECT.c failure has been added to xen-sources-2.6.16.52, sorry for the delay.