Bugzilla Bug 159508

The gencert.sh script installed and executed by the openldap ebuild uses /tmp
insecurely.

The following line:

mkdir -p /tmp/tmpssl-$$

should be replaced with something like

mkdir /tmp/tmpssl-$$ || exit 1

(or print some error and exit, whichever you prefer).

This could be abused by local attackers to cause all sorts of mischief, such as
stealing certificates, overwriting arbitrary files, interfering with
certificate data, etc, etc.

This bug is fairly critical.

Why are we using this script anyway? We have ssl-cert.eclass for this; it's as
easy as docert openldap and install to the proper place, see mail-mta/postfix,
net-misc/stunnel, net-mail/cyrus-imapd, net-im/ejabberd or others for usage.

fixed versions

2.1.30-r10
2.2.28-r7
2.3.30-r2

stay unstable but fixed:
2.3.31-r1

arch teams, please test and mark stable openldap-2.3.30-r2

(In reply to comment #3)
> arch teams, please test and mark stable openldap-2.3.30-r2

marked ppc stable, shall we also stable 2.1.30-r10 and 2.2.28-r7?

I'd say so, they contain the same fix

SPARC stable on openldap-2.3.30-r2, 2.1.30-r10, and 2.2.28-r7

*** Bug 158972 has been marked as a duplicate of this bug. ***

Marked stable for HPPA:
  net-nds/openldap-2.1.30-r10
  net-nds/openldap-2.2.28-r7
  net-nds/openldap-2.3.30-r2

Everything stable for ppc.

ppc64 stable

Stable on Alpha + IA64.

net-nds/openldap-2.1.30-r10
1. emerges on x86, please note:
* Doing tests
ln: creating symbolic link `./data': File exists

and
chown: cannot access `etc/openldap/slapd.conf': No such file or directory
chmod: cannot access `etc/openldap/slapd.conf': No such file or directory
chown: cannot access `etc/openldap/slapd.conf.default': No such file or
directory
chmod: cannot access `etc/openldap/slapd.conf.default': No such file or
directory
>>> Completed installing openldap-2.1.30-r10 into /var/tmp/portage/openldap-2.1.30-r10/image/

2. passes test suite
3. passes collision test

net-nds/openldap-2.2.28-r7
1. emerges on x86
2. passes test suite
3. passes collision test

net-nds/openldap-2.3.30-r2
1. emerges on x86
2. passes test suite
3. passes collision test

Gentoo Base System version 1.12.6
Portage 2.1.1-r2 (default-linux/x86/2006.1/desktop, gcc-4.1.1, glibc-2.4-r4,
2.6.19.1 i686)
=================================================================
System uname: 2.6.19.1 i686 Genuine Intel(R) CPU           T2300  @ 1.66GHz
Last Sync: Mon, 08 Jan 2007 19:00:01 +0000
ccache version 2.4 [disabled]
app-admin/eselect-compiler: [Not Present]
dev-java/java-config: 1.3.7, 2.0.30
dev-lang/python:     2.3.5-r3, 2.4.3-r4
dev-python/pycrypto: 2.0.1-r5
dev-util/ccache:     2.4-r6
dev-util/confcache:  [Not Present]
sys-apps/sandbox:    1.2.17
sys-devel/autoconf:  2.13, 2.61
sys-devel/automake:  1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6-r2, 1.10
sys-devel/binutils:  2.16.1-r3
sys-devel/gcc-config: 1.3.14
sys-devel/libtool:   1.5.22
virtual/os-headers:  2.6.17-r2
ACCEPT_KEYWORDS="x86"
AUTOCLEAN="yes"
CBUILD="i686-pc-linux-gnu"
CFLAGS="-O2 -march=prescott -pipe -fomit-frame-pointer"
CHOST="i686-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/3.5/env /usr/kde/3.5/share/config
/usr/kde/3.5/shutdown /usr/share/X11/xkb /usr/share/config"
CONFIG_PROTECT_MASK="/etc/env.d /etc/env.d/java/ /etc/gconf
/etc/java-config/vms/ /etc/revdep-rebuild /etc/terminfo /etc/texmf/web2c"
CXXFLAGS="-O2 -march=prescott -pipe -fomit-frame-pointer"
DISTDIR="/usr/portage/distfiles"
EMERGE_DEFAULT_OPTS="--nospinner"
FEATURES="autoconfig collision-protect distlocks metadata-transfer
parallel-fetch sandbox sfperms strict test userfetch userpriv usersandbox"
GENTOO_MIRRORS="http://mirror.switch.ch/mirror/gentoo/ http://gentoo.inode.at/"
LINGUAS="en de en_GB de_CH"
MAKEOPTS="-j3"
PKGDIR="/usr/portage/packages"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress
--force --whole-file --delete --delete-after --stats --timeout=180
--exclude='/distfiles' --exclude='/local' --exclude='/pack
ages'"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="x86 X a52 aac acpi alsa alsa_cards_ali5451 alsa_cards_als4000
alsa_cards_atiixp alsa_cards_atiixp-modem alsa_cards_bt87x alsa_cards_ca0106
alsa_cards_cmipci alsa_cards_emu10k1x alsa_cards_ens1370 alsa
_cards_ens1371 alsa_cards_es1938 alsa_cards_es1968 alsa_cards_fm801
alsa_cards_hda-intel alsa_cards_intel8x0 alsa_cards_intel8x0m
alsa_cards_maestro3 alsa_cards_trident alsa_cards_usb-audio alsa_cards_via8
2xx alsa_cards_via82xx-modem alsa_cards_ymfpci alsa_pcm_plugins_adpcm
alsa_pcm_plugins_alaw alsa_pcm_plugins_asym alsa_pcm_plugins_copy
alsa_pcm_plugins_dmix alsa_pcm_plugins_dshare alsa_pcm_plugins_dsnoop
 alsa_pcm_plugins_empty alsa_pcm_plugins_extplug alsa_pcm_plugins_file
alsa_pcm_plugins_hooks alsa_pcm_plugins_iec958 alsa_pcm_plugins_ioplug
alsa_pcm_plugins_ladspa alsa_pcm_plugins_lfloat alsa_pcm_plugin
s_linear alsa_pcm_plugins_meter alsa_pcm_plugins_mulaw alsa_pcm_plugins_multi
alsa_pcm_plugins_null alsa_pcm_plugins_plug alsa_pcm_plugins_rate
alsa_pcm_plugins_route alsa_pcm_plugins_share alsa_pcm_plugin
s_shm alsa_pcm_plugins_softvol apache2 asf berkdb bitmap-fonts cairo cdr cdrom
cli cracklib crypt cups dbus divx dlloader dri dts dvd dvdr dvdread eds
elibc_glibc emboss encode fam ffmpeg firefox flac fort
ran gdbm gif gnome gpm gstreamer gtk hal iconv input_devices_keyboard
input_devices_mouse ipv6 isdnlog java jpeg kde kdeenablefinal kernel_linux ldap
libg++ linguas_de linguas_de_CH linguas_en linguas_en_G
B mad mikmod mmx mono mp3 mpeg ncurses nls nptl nptlonly ogg opengl oss pam
pcre perl png ppds pppd python qt3 qt4 quicktime readline reflection rtsp ruby
samba sdl session smp spell spl sse sse2 sse3 ssl
svg tcpd test tetex theora threads truetype truetype-fonts type1-fonts udev
unicode userland_GNU vcd video_cards_fbdev video_cards_i810 video_cards_vesa
vorbis win32codecs wxwindows x264 xine xml xorg xpri
nt xv xvid zlib"
Unset:  CTARGET, INSTALL_MASK, LANG, LC_ALL, LDFLAGS, PORTAGE_RSYNC_EXTRA_OPTS,
PORTDIR_OVERLAY

x86 saved again by the Incredible Opfer!

welp stabled on amd64

Stable on arm

somebody set this to "B3?", which requires GLSA voting. I dont know any
details, but this could be a B1 (local priv escal)? I guess this is gentoo
specific? 

Voting: yes

(In reply to comment #16)
> somebody set this to "B3?", which requires GLSA voting. I dont know any
> details, but this could be a B1 (local priv escal)? 

i think so

> I guess this is gentoo
> specific? 

i don't think so, e.g.:
http://cvs.mandriva.com/cgi-bin/viewvc.cgi/SPECS/openldap/gencert.sh?revision=1.5.6.1&view=markup

> 
> Voting: yes
> 

i think so :)

GLSA 200701-19