First Last Prev Next    No search results available      Search page      Enter new bug
Bug#: 158729
Alias:
Product:
Component:
Status: RESOLVED
Resolution: DUPLICATE of bug 157220
Assigned To: Gentoo Linux bug wranglers <bug-wranglers@gentoo.org>
Hardware:
OS:
Version:
Priority:
Severity:
Reporter: Tres 'RiverRat' Melton <RiverRat@GreenDragonTavern.com>
Add CC:
CC:
URL:
Summary:
Status Whiteboard:
Keywords:

Filename Description Type Creator Created Size Actions
hal-0.5.7-r3.ebuild Modified ebuild patch Tres 'RiverRat' Melton 2006-12-21 06:26 0000 5.96 KB Details | Diff
hal-0.5.7-r3-lshal-dbus.patch lshal patch patch Tres 'RiverRat' Melton 2006-12-21 06:26 0000 385 bytes Details | Diff
hal-0.5.7-r3-hal-device-dbus.patch hal-devices patch patch Tres 'RiverRat' Melton 2006-12-21 06:27 0000 397 bytes Details | Diff
Create a New Attachment (proposed patch, testcase, etc.) View All

Bug 158729 depends on: Show dependency tree
Bug 158729 blocks:
Votes: 0    Show votes for this bug    Vote for this bug

Additional Comments: (this is where you put emerge --info)


Not eligible to see or edit group visibility for this bug.






View Bug Activity   |   Format For Printing   |   XML   |   Clone This Bug


Description:   Opened: 2006-12-21 06:24 0000
dbus_connection_disconnect() has been renamed dbus_connection_close().
according to the NEWS and Changelogs.  Interesting parts:

/var/tmp/portage/sys-apps/dbus-1.0.2/work/dbus-1.0.2/NEWS
        Line 108: 
        D-Bus 0.90 (17 July 2006)
        ...
        - Removed deprecated dbus_connection_disconnect (use
dbus_connection_close)

/var/tmp/portage/sys-apps/dbus-1.0.2/work/dbus-1.0.2/Changelog
        Line 4901:
        2005-06-06  David Zeuthen  <davidz@redhat.com>
        ...
        * dbus/dbus-connection.h: Add prototype for dbus_connection_disconnect
--->    This appears to have been reverted without a newer changelog entry
(NEWS entry 6 months ago)

/var/tmp/portage/sys-apps/hal-0.5.7-r3/work/hal-0.5.7/tools/hal-device.c
        Line 158:
        dbus_connection_disconnect(conn);

/var/tmp/portage/sys-apps/hal-0.5.7-r3/work/hal-0.5.7/tools/lshal.c
        Line 704:
        dbus_connection_disconnect (conn);

Change above 2 references to: dbus_connection_close(conn);

Patches attached. (and below) :-)

=========================================================================
--- hal-0.5.7/tools/lshal.c~    2006-12-21 07:04:52.000000000 -0700
+++ hal-0.5.7/tools/lshal.c     2006-12-21 07:04:52.000000000 -0700
@@ -701,7 +701,8 @@
        libhal_ctx_shutdown (hal_ctx, &error);
        libhal_ctx_free (hal_ctx);

-       dbus_connection_disconnect (conn);
+/*     dbus_connection_disconnect (conn);      */
+       dbus_connection_close (conn);
        dbus_connection_unref (conn);

        if (show_device)

=========================================================================
--- hal-0.5.7/tools/hal-device.c~       2006-12-21 07:04:36.000000000 -0700
+++ hal-0.5.7/tools/hal-device.c        2006-12-21 07:04:36.000000000 -0700
@@ -155,7 +155,8 @@

        libhal_ctx_shutdown(hal_ctx, &error);
        libhal_ctx_free(hal_ctx);
-       dbus_connection_disconnect(conn);
+/*     dbus_connection_disconnect(conn);       */
+       dbus_connection_close(conn);
        dbus_connection_unref(conn);
        dbus_error_free(&error);

=========================================================================

------- Comment #1 From Tres 'RiverRat' Melton 2006-12-21 06:26:00 0000 -------
Created an attachment (id=104510) [details]
Modified ebuild

------- Comment #2 From Tres 'RiverRat' Melton 2006-12-21 06:26:53 0000 -------
Created an attachment (id=104511) [details]
lshal patch

------- Comment #3 From Tres 'RiverRat' Melton 2006-12-21 06:27:33 0000 -------
Created an attachment (id=104512) [details]
hal-devices patch

------- Comment #4 From Jakub Moc (RETIRED) 2006-12-21 06:36:53 0000 -------

*** This bug has been marked as a duplicate of 157220 ***

------- Comment #5 From Tres 'RiverRat' Melton 2006-12-21 06:38:00 0000 -------
This has apparently been fixed in sys-apps/hal-0.5.7.1-r2 with
hal-0.5.7.1-dbus-close.patch but the patch should be applied to
sys-apps/hal-0.5.7.-r3 as well.  Sorry for the confusion.

First Last Prev Next    No search results available      Search page      Enter new bug