Bugzilla Bug 15722

rmap15b has issues with nvidia-kernel 

Reproducible: Always
Steps to Reproduce:
1.
2.
3.



solution is here: 
http://members.optusnet.com.au/ckolivas/kernel/nvidia-rmap15b.patch

want to clarify. i know that a rmap patch exists in the nvidia-kernel ebuild,
but it fails to 
help with highmem/rmap when used on lolo-sources 2.4.20r1_rc3 or higher. It
works fine on 
lolo-sources 2.4.20-r1_rc2 and earlier. the patch earlier does not help. 

ok. the fix was right under our noses... we apply the patch from here: 
http://www.minion.de/files/NVIDIA_kernel-1.0-4191-2.5-tl.diff 
only to 2.5 kernels...  :-) 
 
it is also for the rmap issue on 2.4 - i'll get an update ebuild attached in a bit. 
 
patch works great so far... 
 
regards, 
 
_j_ 

Created an attachment (id=8298) [details]
sample updated ebuild

maybe this should be assigned to azarah? it is a fix for the nvidia-kernel
ebuild... 
 
anyway, he is a sample updated ebuild that will patch 2.4 as well as 2.5 based
kernels. i also 
removed the seemingly outdated rmap patch we were using. 
 
regards, 
 
_j_ 

az, please take a look at this, I'm not sure what we should do about this since
only some kernels currently use rmap... thanks.

The patch in protage is the updated on.  Now, we could apply it for 2.4
kernels,
only problem is .... will it work fine with non rmap kernel ?

ok, how about this: 
 
we have to have the running kernel's sources in /usr/src/linux so... 
so, we already do the check for 2.4 vs 2.5, when it comes up as 2.4 
why don't we have the ebuild check for /usr/src/linux/mm/rmap.c 
if it exists... apply the patch(NVIDIA_kernel-1.0-4191-2.5-tl.diff), if not skip it. 
 
make sense? 
 
i'll write a sample ebuild and post in a bit. 
 
regards, 
 
_j_ 

Created an attachment (id=8606) [details]
ebuild w/simple check for rmap on 2.4 kernels

basically reworked this minor change to the ebuild:

local RMAPSRC="/usr/src/linux/mm/rmap.c"

    cd ${S}
    if [ "${KV_major}" -eq 2 -a "${KV_minor}" -eq 4 ] && [ -r "${RMAPSRC}" ]
    then
	einfo "Detected rmap enabled kernel."
	EPATCH_SINGLE_MSG="Applying rmap patch for kernel 2.4..." \
	epatch ${FILESDIR}/${NV_PACKAGE}-2.5-tl.diff
    fi


_j_

added updated ebuild to cvs. 

closing as the nvidia-kernel/rmap15b issue seems to be resolved.