Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 150091 - app-forensics/samhain ebuild issues
Summary: app-forensics/samhain ebuild issues
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard: Pending removal: 2010-05-22
Keywords:
Depends on:
Blocks: 220713
  Show dependency tree
 
Reported: 2006-10-04 12:23 UTC by Patrick Lauer
Modified: 2010-06-15 14:00 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Lauer gentoo-dev 2006-10-04 12:23:27 UTC 
From the ebuild:

# If you set the variables here, don't forget to redigest the ebuild by
# issuing 'ebuild samhain-2.1.1a.ebuild digest', also remember that with
# your next emerge sync, the changes to the ebuild will be lost!
#
# Read the Samhain manual for additional information.
#
# STEALTH should be set to either 'full' or 'micro' (mandatory)
#STEALTH=""
#
# XOR_VALUE should be a whole number from 128 to 255 (mandatory)
#XOR_VALUE=""
#
# INSTALL_NAME can be set to change the name of the Samhain binaries
# to the name you specify (optional)
#INSTALL_NAME=""

asking users to edit and redigest ebuilds is silly and error-prone (apart from the missing/wronf digest issue).
Instead they should use an overlay for modified ebuilds.

Also, the variables can be exported from /etc/make.conf, so setting them there should kill the need to manually edit an ebuild
Comment 1 Patrick Lauer gentoo-dev 2008-11-26 22:26:57 UTC 
from samhain-2.2.0.ebuild:

# If you set the variables here, don't forget to redigest the ebuild by
# issuing 'ebuild samhain-2.1.1a.ebuild digest', also remember that with
# your next emerge sync, the changes to the ebuild will be lost!
#

Sigh :) Can we please not do such silly things?
Comment 2 Torsten Veller (RETIRED) gentoo-dev 2009-11-28 18:44:01 UTC 
Patrick, you bumped the package three times since your bug report.
So I guess you fixed this?
Comment 3 Tomáš Chvátal (RETIRED) gentoo-dev 2009-11-28 18:48:10 UTC 
(In reply to comment #2)
> Patrick, you bumped the package three times since your bug report.
> So I guess you fixed this?
> 

No it still aint fixed. It requires more work as stated by him.

So i would recomend pmask with 60 to treeclean unless fixed.
We dont have to keep in main tree every garbage around.
Comment 4 Tomáš Chvátal (RETIRED) gentoo-dev 2010-03-22 15:34:18 UTC 
No action taken so p.masked for removal.
Comment 5 dacook 2010-04-15 23:27:06 UTC 
Hey, it does seem fixed in the 2.6.2 ebuild, it accepts the variables as set in the environment or /etc/make.conf.  The text saying to redigest the ebuild is still there, but if a comment in an ebuild is all it takes to get it masked...
Comment 6 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2010-06-12 20:04:25 UTC 
removed from tree
Comment 7 Michael Weber (RETIRED) gentoo-dev 2010-06-15 14:00:38 UTC 
(In reply to comment #5)
> Hey, it does seem fixed in the 2.6.2 ebuild, it accepts the variables as set in
> the environment or /etc/make.conf.  The text saying to redigest the ebuild is
> still there, but if a comment in an ebuild is all it takes to get it masked...
++