Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 146964 - sys-apps/coreutils cp --progress is gone without any notice
Summary: sys-apps/coreutils cp --progress is gone without any notice
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
: 154651 157520 (view as bug list)
Depends on:
Blocks:
 
Reported: 2006-09-09 09:13 UTC by Petteri Räty (RETIRED)
Modified: 2011-06-14 01:32 UTC (History)
10 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
001_coreutils-gen-progress-bar.patch (001_coreutils-gen-progress-bar.patch,7.94 KB, patch)
2009-02-20 04:46 UTC, Rick Harris
Details | Diff
coreutils progressbar patch for coreutils 8.4 (coreutils-8.4.progress.bar.diff,12.39 KB, patch)
2010-04-04 20:35 UTC, Pete Beardmore
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Petteri Räty (RETIRED) gentoo-dev 2006-09-09 09:13:46 UTC
The log:
betelgeuse@pena /var/log/portage/elog $ cat sys-apps\:coreutils-6.1\:20060908-180133.log
INFO: unpack
Applying patches from Mandrake ...
  017_all_coreutils-mdk-mem.patch ...
Done with patching
Applying ACL patches ...
  004_all_coreutils-acl-xattr.patch ...
Done with patching
Applying various patches (bugfixes/updates) ...
  000_all_coreutils-i18n.patch ...
  003_all_coreutils-gentoo-uname.patch ...
  009_all_coreutils-tests.patch ...
  030_all_coreutils-more-dir-colors.patch ...
  150_all_coreutils-l10n-updates.patch ...
Done with patching
Running eautoreconf in '/var/tmp/portage/coreutils-6.1/work/coreutils-6.1' ...
Running aclocal -I m4 ...
Running autoconf ...
Running autoheader ...
Running automake --add-missing --copy ...

betelgeuse@pena /var/log/portage/elog $

betelgeuse@pena /var/log/portage/elog $ cp --help | grep progress
cp: invalid option -- g
Try `cp --help' for more information.
betelgeuse@pena /var/log/portage/elog $ unalias cp
betelgeuse@pena /var/log/portage/elog $ cp --help | grep progress
betelgeuse@pena /var/log/portage/elog $

on a stable system

betelgeuse@aria ~ $ cp --help | grep progress
  -g, --progress               show a progress bar if operation is going to
betelgeuse@aria ~ $

Please don't remove features without any notice.

Portage 2.1.1 (default-linux/x86/2005.1, gcc-4.1.1/vanilla, glibc-2.4-r3, 2.6.17-gentoo-r6 i686)
=================================================================
System uname: 2.6.17-gentoo-r6 i686 Intel(R) Pentium(R) 4 CPU 2.40GHz
Gentoo Base System version 1.12.4
Last Sync: Unknown
distcc 2.18.3 i686-pc-linux-gnu (protocols 1 and 2) (default port 3632) [disabled]
ccache version 2.4 [disabled]
app-admin/eselect-compiler: 2.0.0_rc2-r1
dev-lang/python:     2.4.3-r3
dev-python/pycrypto: 2.0.1-r5
dev-util/ccache:     2.4-r2
dev-util/confcache:  [Not Present]
sys-apps/sandbox:    1.2.18.1
sys-devel/autoconf:  2.13, 2.60
sys-devel/automake:  1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6-r2
sys-devel/binutils:  2.17
sys-devel/gcc-config: 1.3.13-r3
sys-devel/libtool:   1.5.22
virtual/os-headers:  2.6.17
ACCEPT_KEYWORDS="x86 ~x86"
AUTOCLEAN="yes"
CBUILD="i686-pc-linux-gnu"
CFLAGS="-O2 -march=pentium4 -pipe -mfpmath=sse -ffast-math -fomit-frame-pointer"
CHOST="i686-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/3.5/env /usr/kde/3.5/share/config /usr/kde/3.5/shutdown /usr/share/X11/xkb /usr/share/config"
CONFIG_PROTECT_MASK="/etc/env.d /etc/env.d/java/ /etc/eselect/compiler /etc/gconf /etc/java-config/vms/ /etc/revdep-rebuild /etc/splash /etc/terminfo"
CXXFLAGS="-O2 -march=pentium4 -pipe -mfpmath=sse -ffast-math -fomit-frame-pointer"
DISTDIR="/var/distfiles"
FEATURES="autoaddcvs autoconfig collision-protect cvs distlocks fixpackages java-strict parallel-fetch sandbox sfperms sign strict stricter userpriv usersandbox verify-rdepend"
GENTOO_MIRRORS=" http://trumpetti.atm.tut.fi/gentoo  http://lame.lut.fi/linux/gentoo "
LANG="en_US.utf8"
LC_ALL="en_US.utf8"
LDFLAGS="-Wl,--as-needed"
LINGUAS="fi"
MAKEOPTS="-j2 -s"
PKGDIR="/home/pkg/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --delete-after --stats --timeout=180 --exclude='/distfiles' --exclude='/local' --exclude='/packages'"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/mnt/checkouts/overlays/betelgeuse /mnt/checkouts/overlays/migrated-java"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="x86 aac acl acpi alsa apm arts audiofile avi bash-completion berkdb bitmap-fonts bluetooth bzip2 cairo cdb cddb cdparanoia cli crypt cups dbus dlloader dri dts dvd dvdr dvdread elibc_glibc emboss esd ffmpeg firefox foomaticdb gif gstreamer gtk2 hal input_devices_keyboard input_devices_mouse isdnlog java jpeg kde kdeenablefinal kdehiddenvisibility kernel_linux libg++ libwww linguas_fi logitech-mouse mad mikmod mjpeg mmx mp3 mpeg ncurses network nptl nptlonly nsplugin nvidia offensive ogg oggvorbis opengl pam pcre pdflib png pppd qt3 quicktime readline real reflection rtc samba session spell spl sse sse2 ssl subversion svg symlink tcpd theora threads truetype truetype-fonts type1-fonts udev unicode usb userland_GNU userlocales video_cards_none video_cards_nvidia vorbis xcomposite xml xml2 xorg xv xvid xvmc zlib"
Unset:  CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, PORTAGE_RSYNC_EXTRA_OPTS
Comment 1 SpanKY gentoo-dev 2006-09-09 14:52:32 UTC
that's because it's a custom Gentoo patch that upstream rejected
Comment 2 Petteri Räty (RETIRED) gentoo-dev 2006-09-10 00:50:05 UTC
(In reply to comment #1)
> that's because it's a custom Gentoo patch that upstream rejected
> 

Doesn't mean you couldn't add an ewarn about it.
Comment 3 Antek Grzymała (antoszka) 2006-11-03 17:13:57 UTC
Isn't there about a million gentoo-patches in most important core-system packages, that the upstream would never think of including for many reasons?

What a damn stupid explanation.

We want this back, reopen the bug, please.

[a]
Comment 4 Petteri Räty (RETIRED) gentoo-dev 2006-11-04 00:13:48 UTC
(In reply to comment #3)
> Isn't there about a million gentoo-patches in most important core-system
> packages, that the upstream would never think of including for many reasons?
> 

Actually it is the Gentoo policy to try and keep as close to upstream as possible. I would try to get this feature included upstream instead so that everyone would benefit.
Comment 5 SpanKY gentoo-dev 2006-11-04 02:09:51 UTC
no, there arent actually

generally we push things upstream or we punt them
Comment 6 Jakub Moc (RETIRED) gentoo-dev 2006-11-10 02:19:46 UTC
*** Bug 154651 has been marked as a duplicate of this bug. ***
Comment 7 Sam 2006-11-10 02:26:13 UTC
So which patch is it? And who do we contact about it?

I wouldn't mind submitting the patch over to the upstream guys myself if i knew.
Comment 8 SpanKY gentoo-dev 2006-11-12 21:09:50 UTC
read the patch for upstream information
Comment 9 Mrugesh Karnik 2006-11-21 06:54:59 UTC
Wouldn't it be possible to make a USE flag to enable this patch? Why not just leave the choice to the users? I like this patch. I'd want to use it, even if it isn't used upstream.
Comment 10 SpanKY gentoo-dev 2006-11-26 11:08:29 UTC
`rsync --progress file1 file2` works better than `cp -g file2 file2`
Comment 11 Jakub Moc (RETIRED) gentoo-dev 2006-12-08 07:23:14 UTC
*** Bug 157520 has been marked as a duplicate of this bug. ***
Comment 12 Martin Väth 2006-12-10 05:27:49 UTC
(In reply to comment #10)
> `rsync --progress file1 file2` works better than `cp -g file2 file2`

This is plainly wrong if you e.g. copy to a dvdram where the only reasonable policy is to limit the number of read/write operations and where a progress bar is really useful. You can do a little better with rsync --inplace, but this is still worse than cp. Things become even worse if you want to copy several large files (in which case rsync reads the destination directory data "in vain"): rsync was simply never meant as a substitute to cp for such a purpose. Moreover, there are other things which cp can which rsync cannot do at all (e.g. -i and probably also some other options).

Actually, I considered it always as one of the main advantages of gentoo that it was easy for the user to have patches like this - simply because they are convenient - instead of forcing the user to follow some group's philosophical considerations as in other distros. I am very sad to see that gentoo gives up such an advantage for absolutely no reason.
Comment 13 Simon Cooper 2007-02-19 23:50:33 UTC
May I ask what reason upstream gave for rejecting the patch?
Comment 14 SpanKY gentoo-dev 2007-02-20 02:49:44 UTC
if you read the patch i documented it all in the header
Comment 15 Alexander Mieland 2007-03-06 10:56:33 UTC
A Solution for this "problem" which is a very good example for the typical mentality of the gentoo-devs can be found here:

$ emerge -av layman
$ layman -S
$ layman -a dma147
$ emerge -av coreutils

I've re-inserted this patch since version 6.7-r1... so you maybe have to go testing:

$ echo "sys-apps/coreutils" >> /etc/portage/package.keywords

.
Comment 16 Joseph Mulloy 2007-05-23 20:34:54 UTC
(In reply to comment #14)
> if you read the patch i documented it all in the header

Where is this patch you keep referring to. I want to read it. You keep telling people to read it but don't say where the hell it is.
Comment 17 SpanKY gentoo-dev 2007-05-26 02:22:39 UTC
here's a crazy idea ... it's in the Gentoo coreutils patchset
Comment 18 Rick Harris 2009-02-20 04:46:01 UTC
Created attachment 182615 [details, diff]
001_coreutils-gen-progress-bar.patch

Old Gentoo progress bar patch no longer works with newer versions of coreutils.

Here's an updated one.
Note if you're used to the old one using option '-g', this one uses the option '-B' to achieve same.

And yes, I'm aware that it will never be included in the coreutils ebuild, this is just for the benefit of the many users who still use it or want to use it in their own overlays.
Comment 19 SpanKY gentoo-dev 2009-02-21 23:41:21 UTC
i'd add that to the patchset except it isnt a complete port
Comment 20 Pete Beardmore 2010-04-04 20:35:12 UTC
Created attachment 226591 [details, diff]
coreutils progressbar patch for coreutils 8.4


the (complete) attached diff builds against coreutils-8.4
Comment 21 manwe 2011-04-12 10:16:20 UTC
Any chances for new patch? Last version this one is working is 8.5(-r1).
Comment 22 Sam 2011-04-12 10:19:26 UTC
[removing myself from CC]
Comment 23 SpanKY gentoo-dev 2011-04-12 17:03:52 UTC
ive added it to the 8.{1,2,3,4,5} patchsets, but it's still not going to be enabled by default, nor is it updated to 8.6+