Bugzilla Bug 144701

Hi,

There's a simple logic error in taskjuggler-2.2.0.ebuild, in the src_install
rule.
The script says:

        use kde && \
                cd Contrib/kate && \
                make install DESTDIR=${D} || die "install kate-addons failed"

I think what you meant was: use && (cd && (make || die))
But what it seems to do is: ((use && cd) && make) || die
Or it might be: if(use) { cd && make } else { die }

In any case, the USE flag isn't set, and the die message "install kate-addons
failed" is emitted, with no other error message.  Took a while to figure out
where the problem was.

I'll supply a patch in a subsequent comment, as well as build logs (failure and
success).

Mark

Portage 2.1.1_pre5-r3 (hardened/x86/2.6, gcc-3.4.6/hardened, glibc-2.3.6-r4,
2.6.17.1-ck1 i686)
=================================================================
System uname: 2.6.17.1-ck1 i686 Intel(R) Pentium(R) M processor 1.70GHz
Gentoo Base System version 1.12.4
Last Sync: Mon, 21 Aug 2006 14:00:01 +0000
distcc 2.18.3 i686-pc-linux-gnu (protocols 1 and 2) (default port 3632)
[disabled]
ccache version 2.3 [enabled]
app-admin/eselect-compiler: 2.0.0_rc2-r1
dev-lang/python:     2.3.5, 2.4.3-r1
dev-python/pycrypto: 2.0.1-r5
dev-util/ccache:     2.3
dev-util/confcache:  [Not Present]
sys-apps/sandbox:    1.2.18.1
sys-devel/autoconf:  2.13, 2.60
sys-devel/automake:  1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6-r2
sys-devel/binutils:  2.17
sys-devel/gcc-config: 2.0.0_rc1
sys-devel/libtool:   1.5.22
virtual/os-headers:  2.6.17
ACCEPT_KEYWORDS="x86 ~x86"
AUTOCLEAN="yes"
CBUILD="i686-pc-linux-gnu"
CFLAGS="-march=pentium3 -O2 -pipe"
CHOST="i686-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/3.4/env /usr/kde/3.4/share/config
/usr/kde/3.4/shutdown /usr/kde/3.5/env /usr/kde/3.5/share/config
/usr/kde/3.5/shutdown /usr/share/X11/xkb /usr/share/config"
CONFIG_PROTECT_MASK="/etc/env.d /etc/env.d/java/ /etc/eselect/compiler
/etc/gconf /etc/java-config/vms/ /etc/revdep-rebuild /etc/terminfo
/etc/texmf/web2c"
CXXFLAGS="-march=pentium3 -O2 -pipe"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoconfig ccache distlocks fixpackages metadata-transfer sandbox
sfperms strict"
GENTOO_MIRRORS="http://gentoo.ccccom.com/ http://gentoo.oregonstate.edu/
http://distro.ibiblio.org/pub/linux/distributions/gentoo"
LANG="en_US.UTF-8"
LINGUAS="en"
PKGDIR="/usr/portage//packages/x86/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress
--force --whole-file --delete --delete-after --stats --timeout=180
--exclude='/distfiles' --exclude='/local' --exclude='/packages'"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage/"
PORTDIR_OVERLAY="/usr/local/portage /usr/local/portage-overlay/perl-catalyst
/usr/local/portage-overlay/zugaina"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="X aac acpi adns aio akode alsa amr ansi apache2 arts atlas avi
bash-completion berkdb bitmap-fonts bluetooth bzip2 cpanplus crypt cups curl
dbus dga divx4linux dlloader doc dri dvd dvdread effects elibc_glibc encode esd
ethereal exscalibar fbcon fbdev ffmpeg fftw firefox flac flash foomaticdb gimp
glut gnome gphoto2 gpm gstreamer gtk gtk2 gvim hardened hbci hou httpd ifp
infopipe input_devices_keyboard input_devices_mouse ipod ipv6 ithreads jack
java jpeg jpeg2k kerberos kernel_linux libgda linguas_en live lzo mad matroska
mikmod mjpeg mmx mng mod modperl mozdevelop mozilla moznoirc mozsvg mp3 mp4
mpeg mplayer mpm-worker musicbrainz ncurses netjack network nfsv4 nptl nptlonly
nsplugin ofx ogg oggvorbis opengl pam pcmcia pdf perl pic plugin png pnp ppds
python quicktime readline real rsync rtsp ruby samba scanner scim sdl shout
skins sou speex spell sse sse2 ssl stream subtitles svg tcltk tcpd test theora
threads tiff truetype uim unicode usb userland_GNU userlocales v4l vcd vdr
video_cards_ati video_cards_radeon vorbis vorbis-psy win32codecs x264 x86 xine
xinerama xml xml2 xmms xorg xpm xv xvid zlib"
Unset:  CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LC_ALL, LDFLAGS, MAKEOPTS,
PORTAGE_RSYNC_EXTRA_OPTS

Created an attachment (id=94815) [details]
Fix the ebuild's USE-flag logic

I think you want it to die if the build fails, not if the USE-flag isn't set. 
So, here's a patch to fix it.

Created an attachment (id=94816) [details]
build failure log

This is what the build failure looks like.

Created an attachment (id=94817) [details]
build success log

With the patch applied, build succeeds to completion.

Patch in Comment #1 Works for Me (tm), thanks.

In cvs.
Thanks for your help.