Bugzilla Bug 141689

With fox-1.6.8 from bug 111209 comment 3
 and fox-wrapper-2 from bug 111209 comment 4
I just successfully built goggles-0.9.0 by simply renaming the ebuild.
Further adjustments to the ebuild make it depend on fox-1.6* and set WANT_FOX
according to the new fox layout used by fox.eclass.

According to bug 128917 we need fox-1.6 to compile using gcc-4.1.1, and we need
goggles-0.9.0 or a lot of patches to make goggles compile using fox-1.6. So
this here is a bit more than an request for enhancement; we need it for gcc
update.

Created an attachment (id=92707) [details]
media-video/goggles/goggles-0.9.0.ebuild

Ebuild for goggles-0.9.0, setting DEPEND to fox-1.6* and WANT_FOX to 1.6
Note that the fix from bug 141683 is not needed here.

Hmm ...

As of version 0.8.0 "ogle" does build "src/ogle_gui_goggles"
but "src/goggles" which should be installed to "/usr/bin/ogle_gui_goggles".
So "ogle_gui_goggles" is NOT installed in ALL ~arch builds at the moment!

Furthermore there is a persistent problem with "scripts/goggles", i. e.
version 0.7.10 sets DVDP_UI="//var/tmp/portage/goggles-0.7.10/image/..",
version 0.8.0 sets DVDP_UI="//usr/bin/ogle_gui_goggles" (OK), and
version 0.9.0 sets DVDP_UI="@location@/ogle_gui_gogles".

Axel

Created an attachment (id=101454) [details]
A slightly modified (0.9.0) ebuild that fixes the problems mentioned above

Addition:
  The problem with the binary name (ogle_gui_goggles != goggles) does not
  occur before version 0.9.0 which moved the "build code" from
  "src/build.mk" into "gb".

Axel

Created an attachment (id=101456) [details]
This package is jinxed! Fixed a typo ...

Created an attachment (id=101457) [details]
goggles-0.9.0.ebuild installing ogle_gui_goggles using newbin

(In reply to comment #2)
> As of version 0.8.0 "ogle" does build "src/ogle_gui_goggles"
> but "src/goggles"

You meant "goggles" not "ogle" and "does not build" not "does build", right?

(In reply to comment #3)
> A slightly modified (0.9.0) ebuild that fixes the problems mentioned above

Intuitively I'd tend to use newbin in src_install instead of mv in src_compile,
but I don't know if there are any good reasons to prefer one or the other.

What we definitely should have are some more "|| die" handlers. With them I
would have noted this problem before reporting this as "working" here. I also
added a die in case the goggles script contains some unexpanded placeholder
(like @location@ was); to avoid problems like this in the future.

(In reply to comment #4)
>> As of version 0.8.0 "ogle" does build "src/ogle_gui_goggles"
>> but "src/goggles"

>You meant "goggles" not "ogle" and "does not build" not "does build", right?

Yes. And the problem does occur in version 0.9.0 for the first time and
not in 0.8.0 ...

Your lastest 0.9.0 ebuild (using "newbin" and not "mv") does work for me, too.
So which of the 0.9.0" ebuilds is added to portage does not really matter
though
your's should be preferred, because of the added "|| die"s.

Argh ... Just noticed that "fox-1.6.16"'s DEPEND must list "fox-wrapper-2"
(which is ~arch as is fox-1.6-*) and not just "fox-wrapper"

Axel

Because of the script path problems described in comment #2 the current stable
version of goggles is almost inusable. Furthermore the current ~masked version
is not a likely candidate for stabilization because of said problems.

As all dependencies of this bug have been fixed for some time now, I would
therefore ask the video herd to include the posted ebuild into the tree, give
it some testing there, and stabilize soon if there are no major bug reports,
because what's currently in portage is almost certainly unusable. 

In case a fast stabilization is not feasible, some ebuild changes should be
backported. This is especially the changed DVDP_UI setting mentioned in
comment 2, the name of the binary to be installed as described in that same
comment, and the WANT_FOX setting fo which I just filed bug 157034.

Created an attachment (id=103382) [details]
goggles-0.9.1.ebuild

We might as well add the latest 0.9.1 instead of 0.9.0.
Simply copied my previous ebuild, works well enough.

Martin, your ebuild seems all fine. Thanks for the work, i just need to get rid
of that "prestripped files found", but once i've fixed that, i'll check it in
asap.

Created an attachment (id=103412) [details]
goggles-0.9.1.ebuild without -s in LDFLAGS

(In reply to comment #9)
> Martin, your ebuild seems all fine. Thanks for the work, i just need to get
> rid of that "prestripped files found",

The attached ebuild solves this issue, using a modified sed call.
LDFLAGS was set to -s by default.

I also noticed that for CFLAGS and CXXFLAGS the environment now takes
precedence, so some of the changes are no longer needed. And to be on the safe
side I now modify all config files.

> but once i've fixed that, i'll check it in asap.

Good to head that! Thanks! :-)

0.9.1 seems to be allready in tree since last year, closing this..