Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 141271 - ebuild for serienbrief
Summary: ebuild for serienbrief
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Default Assignee for New Packages
URL: http://www.nasauber.de/downloads/?pro...
Whiteboard:
Keywords: EBUILD
Depends on:
Blocks:
 
Reported: 2006-07-21 04:35 UTC by Tobias Leupold
Modified: 2006-08-29 06:54 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
My ebuild for serienbrief-0.2 (serienbrief-0.2.ebuild,584 bytes, text/plain)
2006-07-21 04:35 UTC, Tobias Leupold
Details
Fixed ebuild (serienbrief-0.2.ebuild,812 bytes, text/plain)
2006-07-21 08:24 UTC, Tobias Leupold
Details
ebuild with LINGUAS support (serienbrief-0.2-r1.ebuild,890 bytes, text/plain)
2006-07-31 08:39 UTC, Tobias Leupold
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Leupold 2006-07-21 04:35:19 UTC
serienbrief is a Perl program for creating form letters written in LaTeX in an easy way.
Comment 1 Tobias Leupold 2006-07-21 04:35:57 UTC
Created attachment 92396 [details]
My ebuild for serienbrief-0.2
Comment 2 Tobias Leupold 2006-07-21 05:09:28 UTC
As this program is written by me, I would also maintain the ebuild :-)
Comment 3 Alexandre Buisse (RETIRED) gentoo-dev 2006-07-21 07:02:33 UTC
Some remarks on your ebuild:

- we *need* the ebuild header. Just copy it from /usr/portage/header.txt or start from the ebuild skeleton (/usr/portage/skel.ebuild)
- A couple of newlines would increase readability (e.g. after SRC_URI and after KEYWORDS)
- you should never depend directly on app-text/tetex unless it's tetex specific. Use virtual/tetex which allows some variants like ptex.
- no need to depend on gzip and tar, almost all packages use either tar.gz or tar.bz2 and every gentoo system is expected to provide them.
- don't use exeinto/doexe but directly dobin
- we never install COPYING because the license is already covered by the LICENSE variable and there is no need to have 3000 copies of the GPL on a system


Otherwise, your ebuild looks fine. I wanted to test the package but it requires a TeX input file, could you provide one for testing purpose (actually, installing an exemple in /usr/share/doc could be a good idea).

About maintainership, you need to be a gentoo dev to be the "official" maintainer (listed in metadata.xml), but text-markup can act as proxy maintainer if you provide us ebuild diffs (well, that's what we are supposed to do anyway :)).

Please provide an updated ebuild and I'll add it to the tree.
Comment 4 Tobias Leupold 2006-07-21 08:24:38 UTC
Created attachment 92421 [details]
Fixed ebuild

I fixed the ebuild considering what you said.

I also included a rather puristic example TeX file and a data set file and put it in /usr/share/doc.

Thanks for your quick response :-)
Comment 5 Alexandre Buisse (RETIRED) gentoo-dev 2006-07-25 02:34:25 UTC
It has been added to the tree a few minutes ago.
Comment 6 Tobias Leupold 2006-07-25 13:08:09 UTC
Cool :-) Thanks!

But it seems that there's a problem with the digest files: Trying to do emerge serienbrief (after deleting it from my portage overlay and removing the sources from distfiles directory), I get

!!! Digest verification failed:
!!! /usr/portage/distfiles/serienbrief-0.2.tar.gz
!!! Reason: Filesize does not match recorded size
!!! Got: 13865
!!! Expected: 13864

emerge fetched it from my homepage, not from a mirror -- but I didn't change the file ...
Comment 7 Alexandre Buisse (RETIRED) gentoo-dev 2006-07-25 13:38:58 UTC
Hum. I must have had a wrong version of the distfiles (I took it on the 21st of july and it had the example files). Sorry, I should have checked before commiting.

Anyway, I just commited a new version that should hopefully have the right manifest. Give it a few hours to sync and please tell me if it still fails.
Comment 8 Tobias Leupold 2006-07-26 00:16:07 UTC
Hmmm ... that's strage, because I haven't changed the file since July 21, 13:00 ...

But anyway -- now it works and the sources are also on the mirrors (at least on the mirror I use) :-)
Comment 9 Tobias Leupold 2006-07-31 08:38:30 UTC
I fixed the ebuild to support the LINGUAS variable (so that the German localization file won't be installed on a non-German system). I did it the way the acroread ebuild does. Is this okay?
Comment 10 Tobias Leupold 2006-07-31 08:39:39 UTC
Created attachment 93125 [details]
ebuild with LINGUAS support
Comment 11 Alexandre Buisse (RETIRED) gentoo-dev 2006-08-29 05:52:54 UTC
Sorry for the delay, the modified ebuild has just been commited.
Comment 12 Tobias Leupold 2006-08-29 06:54:20 UTC
No problem! Thanks :-)