Bug 141111 – Silence some warnings for sys-apps/pciutils-2.2.3-r1

• Status: RESOLVED UPSTREAM
• Product: Gentoo Linux

[Description hiyuh 2006-07-19 19:51:43 UTC]

All annoyed compilation warnings should be shot,
and it's easy to make it.
These have hidden/implicitly bugs, IMHO.

[Comment 1 hiyuh 2006-07-19 19:54:00 UTC]

Created attachment 92252 [details, diff]
Fix warnings for sys-apps/pciutils-2.2.3-r1

This patch could help to silence all warnings with "-O3 -Wall"
as CFLAGS by using gcc-4 on my ~ppc env.

[Comment 2 Jakub Moc (RETIRED) 2006-07-19 23:55:09 UTC]

Have you sent this upstream? (See feedback section at http://atrey.karlin.mff.cuni.cz/~mj/pciutils.shtml)

[Comment 3 hiyuh 2006-07-20 03:50:00 UTC]

(In reply to comment #2)
> Have you sent this upstream? (See feedback section at
> http://atrey.karlin.mff.cuni.cz/~mj/pciutils.shtml)
Well, not yet.
Because of some reviews/tests by Gentoo's pciutils' maintainers, if who are.
Then, to send it upstream is better, I thought.
Anyway, I'd like to squash it as upstream release, of cource.
But should *I* submit it to upstream, directly?
Its Feedback section sounds like forcing to subscribe linux-pci ML, though.
It makes me feel subtle...

[Comment 4 SpanKY 2006-07-31 21:21:05 UTC]

best to try and see if the maintainer will take these changes and/or rewrite the code slightly

the way the code is written (pci requires bytes and going by the coding style, the author doesnt trust a "char" to be just a byte), i dont the warnings will be fixed