Bugzilla Bug 140321

Hi,
euses doesn't work on gentoo/alt (source command not exist in /bin/sh),
i attach a patch that resolves that problem (yes, it works also in linux).

Created an attachment (id=91690) [details]
My patch to fix euses source problem

euse is completely broken on OSX because readlink seems to expect other input. 
What gentoo/alt system are you using?

(In reply to comment #2)
> euse is completely broken on OSX because readlink seems to expect other input. 
> What gentoo/alt system are you using?

euses, not euse. I cannot test this myself, sadly, though I am euses'
maintainer and upstream. I might be able to support Gentoo/Alt with your help,
though. Could you look at the patch? I guess this is a patch against
app-portage/euses-2.4.3, which should at the least compile properly.

(In reply to comment #3)
> (In reply to comment #2)
> > euse is completely broken on OSX because readlink seems to expect other input. 
> > What gentoo/alt system are you using?
> 
> euses, not euse. I cannot test this myself, sadly, though I am euses'
> maintainer and upstream. I might be able to support Gentoo/Alt with your help,
> though. Could you look at the patch? I guess this is a patch against
> app-portage/euses-2.4.3, which should at the least compile properly.

also 2.5.0_pre1 works

(In reply to comment #4)
> also 2.5.0_pre1 works

Based on the patch in you other bug, you are on a x86-fbsd system?!?

@jer: euses has depend on autoconf-wrapper, which I cannot keyword on OSX, so I
won't even get to compiling the thing.

(In reply to comment #5)
> (In reply to comment #4)
> > also 2.5.0_pre1 works
> 
> Based on the patch in you other bug, you are on a x86-fbsd system?!?
> 
> @jer: euses has depend on autoconf-wrapper, which I cannot keyword on OSX, so I
> won't even get to compiling the thing.
> 

Yes, i am on x86-fbsd

Try 2.5.0. It should be able to figure out by itself where bash is.

I tried patching it, but maybe upstream can first use their define EMF in
euses.c, such that a one place change actually reflects a change in all other
locations.

e.g.:

popen("source /etc/make.globals;"
          "source /etc/make.conf;" "echo -n ${PORTDIR}", "r");

to

popen("source " ETC "/make.globals;"
          "source " EMF ";" "echo -n ${PORTDIR}", "r");

or

popen("source " ETC "/make.globals;"
          "source " ETC "/make.conf;" "echo -n ${PORTDIR}", "r");

Maybe you better run eautoreconf as upstream, and if you do in the ebuild, in
src_unpack would be better.

Let's try a different approach: today I (upstream for euses) committed
app-portage/euses-2.5.0 to the tree. It finds bash on its own so you might want
to try this version (the final >>>app-portage/euses-2.5.0<<< to be precice, not
the preview) and see if the problem is solved. Hint: emerge -u euses.


Kind regards,
     JeR

hint:
please || die "I'm not interested in bash"

(In reply to comment #10)
> hint:
> please || die "I'm not interested in bash"

How very blunt of you. I don't think you are cooperating very well. Did you
really intend to be this uninformative?

If you would kindly tell me what exactly it is that BSD/OSX needs, I would
happily implement it. Some of the questions you never answered are:

1) Are you telling me the script would work with any sh (that is not bash)?
2) Which shells would you like me to test with?
2) Does BSD/OSX support eautoreconf these days?


Kind regards,
     JeR

2.5.0-r1 is in the tree with all your suggested fixes. Please test (and
possibly mark ~arch if you want to).

Ok, maybe my comment wasn't too polite, I'm sorry for that.  Anyhow, you're not
polite at all, so I don't care at all to get euses to _function_ correcty, as
it _compiles_ fine, but _runs_ only if you have /etc/make.conf and
/etc/make.globals.  Your package simply doesn't respect the --sysconfdir=
configure flag.

(In reply to comment #13)
> Ok, maybe my comment wasn't too polite, I'm sorry for that.  Anyhow, you're not
> polite at all, so I don't care at all to get euses to _function_ correcty, as
> it _compiles_ fine, but _runs_ only if you have /etc/make.conf and
> /etc/make.globals.  Your package simply doesn't respect the --sysconfdir=
> configure flag.

Anything else I need to address to get it it to work?

2.5.1 is in the tree. It uses $sysconfdir to find the paths to
make.{conf,globals}. Plztstk?

% euses -V
euses 2.5.3
Copyright Jeroen Roovers 2005-2006 - Please report bugs to jer@gentoo.org
This is Free Software (see /Library/Gentoo/usr/portage/licenses/GPL-2)

looks good.  Added ~ppc-macos in prefix.

(In reply to comment #16)
> % euses -V
> euses 2.5.3
> Copyright Jeroen Roovers 2005-2006 - Please report bugs to jer@gentoo.org
> This is Free Software (see /Library/Gentoo/usr/portage/licenses/GPL-2)
> 
> looks good.  Added ~ppc-macos in prefix.

Thank you. Does this mean all is set to close this bug as RESOLVED/FIXED?

The prefix part from Gentoo/Alt is RESOLVED/FIXED.  Don't know how the BSD part
is doing.

Since i keyworded it i think it's possibile to close this bug.