Bug List: (This bug is not in your last search results)   Show last search results      Search page      Enter new bug
Bug#: 138688
Alias:
Product:
Component:
Status: RESOLVED
Resolution: FIXED
Assigned To: Gentoo X packagers <x11@gentoo.org>
Hardware:
OS:
Version:
Priority:
Severity:
Reporter: Rudo Thomas <rudo@matfyz.cz>
Add CC:
CC:
Remove selected CCs
URL:
Summary:
Status Whiteboard:
Keywords:

Filename Description Type Creator Created Size Actions
dev-perl:XML-Parser-2.34:20070124-212406.log dev-perl:XML-Parser-2.34:20070124-212406.log text/plain Curtis 2007-01-24 21:26 0000 3.65 KB Details
Create a New Attachment (proposed patch, testcase, etc.) View All

Bug 138688 depends on: Show dependency tree
Bug 138688 blocks:
Votes: 0    Show votes for this bug    Vote for this bug

Additional Comments: (this is where you put emerge --info)


Not eligible to see or edit group visibility for this bug.






View Bug Activity   |   Format For Printing   |   XML   |   Clone This Bug

Description:   Opened: 2006-07-01 04:12 0000 
Hi,

I have looked at the x11-base/xorg-server/files/x11r7.0-setuid.diff file in the
portage tree and found the patch broken.

As of revision 1.1 of the file in portage CVS, the write.c hunk says:

-                       setuid(getuid());
+                       if (setuid(getuid() == -1)
+                           FatalError("xf86writeConfigFile(): "

Note the missing closing parenthesis after getuid(). I wonder how it could even
compile (haven't tried it myself though).

Please fix the patch.

Bye for now.

Rudo.

------- Comment #1 From Joshua Baergen (RETIRED) 2006-07-01 09:31:06 0000 ------- 
It probably doesn't compile the parser, then.  I'll fix this up anyway.  Good
catch :)

Donnie, this is broken in the 1.1 patch as well, which probably means it's
broken in git upstream.

------- Comment #2 From Donnie Berkholz 2006-07-01 12:43:10 0000 ------- 
I've also committed your fix upstream.

------- Comment #3 From Curtis 2007-01-24 21:26:19 0000 ------- 
Created an attachment (id=108057) [details]
dev-perl:XML-Parser-2.34:20070124-212406.log
Bug List: (This bug is not in your last search results)   Show last search results      Search page      Enter new bug