Bug 131318 – sys-fs/udev-090 includes stropts.h when it doesnt actually need it

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description solar (RETIRED) 2006-04-26 04:31:28 UTC]

udev-090 includes stropts.h which is provided only by glibc. On embedded
hosts that use the GNU uClibc stropts.h does not exist. Commenting out
the #include <stropts.h> on line 29 of udev_devices.c allows it to
compile properly with it only bitching about
implicit declaration of function `ioctl'.
(probably the reason stropts.h was included in the first place)
Replacing the stropts with sys/ioctl allows it to compile and link
correctly.


--- udev_device.c 2006-04-26 11:14:52 +0000
+++ udev_device.c 2006-04-26 11:15:06 +0000
@@ -26,7 +26,7 @@
 #include <fcntl.h>
 #include <errno.h>
 #include <ctype.h>
-#include <stropts.h>
+#include <sys/ioctl.h>
 #include <net/if.h>
 #include <linux/sockios.h>
 
udev-089-r2 did not suffer from this problem.

[Comment 1 Greg Kroah-Hartman (RETIRED) 2006-04-26 16:12:56 UTC]

Kay, any objections to this change?

[Comment 2 Kay Sievers 2006-04-26 17:06:46 UTC]

No, I will change that for the next release.

[Comment 3 solar (RETIRED) 2006-06-04 10:02:08 UTC]

*** Bug 135433 has been marked as a duplicate of this bug. ***

[Comment 4 SpanKY 2006-06-07 06:39:17 UTC]

stropts is portable code:
http://www.opengroup.org/onlinepubs/009695399/basedefs/stropts.h.html

uClibc just doesnt have it implemented yet

[Comment 5 Greg Kroah-Hartman (RETIRED) 2006-08-30 21:17:19 UTC]

Fixed in latest version of udev.