Bugzilla Bug 123152

emerge info:
Portage 2.0.54 (default-linux/x86/2005.0, gcc-3.3.6, glibc-2.3.5-r2, 2.6.11.8
i686)
=================================================================
System uname: 2.6.11.8 i686 Intel(R) Celeron(R) CPU 2.40GHz
Gentoo Base System version 1.6.14
dev-lang/python:     2.3.5, 2.4.2
sys-apps/sandbox:    1.2.12
sys-devel/autoconf:  2.13, 2.59-r6
sys-devel/automake:  1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6-r1
sys-devel/binutils:  2.16.1
sys-devel/libtool:   1.5.22
virtual/os-headers:  2.6.11-r2
ACCEPT_KEYWORDS="x86"
AUTOCLEAN="yes"
CBUILD="i686-pc-linux-gnu"
CFLAGS="-march=pentium4 -O3 -pipe -fomit-frame-pointer"
CHOST="i686-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/2/share/config /usr/kde/3/share/config
/usr/share/config /var/bind /var/qmail/control"
CONFIG_PROTECT_MASK="/etc/gconf /etc/terminfo /etc/env.d"
CXXFLAGS="-march=pentium4 -O3 -pipe -fomit-frame-pointer"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoconfig ccache distcc distlocks sandbox sfperms strict userpriv"
GENTOO_MIRRORS="http://linux.rz.ruhr-uni-bochum.de/download/gentoo-mirror
ftp://sunsite.informatik.rwth-aachen.de/pub/Linux/gentoo
http://gentoo.oregonstate.edu
http://www.ibiblio.org/pub/Linux/distributions/gentoo"
MAKEOPTS="-j4"
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/var/tmp/portage"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage"
SYNC="rsync://data.naxos-software.de/gentoo-portage"
USE="x86 berkdb crypt ipv6 jpeg mmx ncurses nls pam png readline sasl sse sse2
ssl tcpd tiff truetype unicode xml xml2 zlib userland_GNU kernel_linux
elibc_glibc"
Unset:  ASFLAGS, CTARGET, LANG, LC_ALL, LDFLAGS, LINGUAS


use-flags:
app-backup/bacula-1.38.5  -X +bacula-clientonly +bacula-console -bacula-nodir
-bacula-nosd +bacula-split-init -doc -gnome +logrotate -logwatch -mysql
-postgres -python +readline -sqlite +ssl -static +tcpd -wxwindows

emerge:
$ emerge bacula    
Calculating dependencies ...done!
>>> emerge (1 of 1) app-backup/bacula-1.38.5 to /
>>> md5 files   ;-) bacula-1.38.5.ebuild
>>> md5 files   ;-) bacula-1.36.3-r3.ebuild
>>> md5 files   ;-) bacula-1.36.3-r2.ebuild
>>> md5 files   ;-) files/bacula-conf
>>> md5 files   ;-) files/digest-bacula-1.36.3-r3
>>> md5 files   ;-) files/bacula-1.36.3-cdrecord-configure.patch
>>> md5 files   ;-) files/bacula-1.36.3-default-configs.patch
>>> md5 files   ;-) files/bacula-doc-1.36.3-latex-icons.patch
>>> md5 files   ;-) files/digest-bacula-1.38.5
>>> md5 files   ;-) files/bacula-init3
>>> md5 files   ;-) files/bacula-1.36.3-mtxtmpfile.patch
>>> md5 files   ;-) files/digest-bacula-1.36.3-r2
>>> md5 files   ;-) files/randpass-1.37.40
>>> md5 files   ;-) files/1.36.3/bacula-all-conf
>>> md5 files   ;-) files/1.36.3/bacula-all-init
>>> md5 files   ;-) files/1.36.3/bacula-dir-conf
>>> md5 files   ;-) files/1.36.3/bacula-dir-init
>>> md5 files   ;-) files/1.36.3/bacula-fd-conf
>>> md5 files   ;-) files/1.36.3/bacula-fd-init
>>> md5 files   ;-) files/1.36.3/bacula-sd-conf
>>> md5 files   ;-) files/1.36.3/bacula-sd-init
>>> md5 files   ;-) files/1.38.5/bacula-all-conf
>>> md5 files   ;-) files/1.38.5/bacula-all-init
>>> md5 files   ;-) files/1.38.5/bacula-dir-conf
>>> md5 files   ;-) files/1.38.5/bacula-dir-init
>>> md5 files   ;-) files/1.38.5/bacula-fd-conf
>>> md5 files   ;-) files/1.38.5/bacula-fd-init
>>> md5 files   ;-) files/1.38.5/bacula-sd-conf
>>> md5 files   ;-) files/1.38.5/bacula-sd-init
>>> md5 src_uri ;-) bacula-1.38.5.tar.gz
>>> Unpacking source...
>>> Unpacking bacula-1.38.5.tar.gz to /var/tmp/portage/portage/bacula-1.38.5/work

 * Cannot find $EPATCH_SOURCE!  Value for $EPATCH_SOURCE is:
 * 
 *   /usr/portage/app-backup/bacula/files/bacula-1.38.5-default-configs.patch
 *   ( bacula-1.38.5-default-configs.patch )


!!! ERROR: app-backup/bacula-1.38.5 failed.
!!! Function epatch, Line 207, Exitcode 0
!!! Cannot find $EPATCH_SOURCE!
!!! If you need support, post the topmost build error, NOT this status message.

"whoops"!  Added in cvs now.

>>> md5 files   ;-) files/1.38.5/bacula-sd-init
>>> md5 src_uri ;-) bacula-1.38.5.tar.gz
 * Adding user 'bacula' to your system ...
 *  - Userid: 109
 * Do not specify /bin/false yourself, use -1

Just change the "/bin/false" for -1 on enewuser and you're done ;-)

you might also want to quote all the ${D} etc variables, because they may point
to paths with spaces in them...

In my opinion, this bug should be closed. For what I've seen, both suggestions
have taken effect: Variables are quoted in conditionals and there's no
"/bin/false" in the whole file.

don't know which ebuild you're looking at, but bacula-1.38.9 is not quoted at
all...

Created an attachment (id=93543) [details]
Variables are now quoted.

I quoted here and there and now it seems to be ready.

for your information, don't quote ${A}, because if it contains multiple items,
they are seen as one, and your fetch will fail ;)

Can't commit (and close this bug) because hppa seems not to have logwatch
keyworded.
app-backup/bacula/bacula-1.36.3-r3.ebuild: ~hppa(default-linux/hppa/2005.0)
['sys-apps/logwatch']

@hppa: please keyword logwatch, or allow to remove your keyword from the (old)
bacula ebuild.  hppa keyword seems to be gone in later ebuilds.

patch fixed, enewuser fixed... Let's not make a dumpspace bug out of this. Go
file a proper keywording bug for sys-apps/logwatch and then you can fix the
quoting as desired for stupid people that put spaces into portage paths.